| Message ID | 20220819083858.3987590-1-Shyam-sundar.S-k@amd.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86/amd/pmf: Fix undefined reference to platform_profile | expand |
On 8/19/22 01:38, Shyam Sundar S K wrote: > Its reported that amd-pmf driver when built with config which does not > have ACPI_PLATFORM_PROFILE set/enabled throws a undefined references to > symbols used. > > --- > ld: vmlinux.o: in function `amd_pmf_init_sps': > /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:132: undefined reference to `platform_profile_register' > ld: vmlinux.o: in function `amd_pmf_deinit_sps': > /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:142: undefined reference to `platform_profile_remove' > --- > > Fix it by adding a "select" to the Kconfig. > > Fixes: da5ce22df5fe ("platform/x86/amd/pmf: Add support for PMF core layer") > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Thanks. > --- > > Based on "review-hans" branch. > > drivers/platform/x86/amd/pmf/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/amd/pmf/Kconfig b/drivers/platform/x86/amd/pmf/Kconfig > index e65ffa52229b..c375498c4071 100644 > --- a/drivers/platform/x86/amd/pmf/Kconfig > +++ b/drivers/platform/x86/amd/pmf/Kconfig > @@ -6,6 +6,7 @@ > config AMD_PMF > tristate "AMD Platform Management Framework" > depends on ACPI && PCI > + select ACPI_PLATFORM_PROFILE > help > This driver provides support for the AMD Platform Management Framework. > The goal is to enhance end user experience by making AMD PCs smarter,
Hi, On 8/19/22 10:38, Shyam Sundar S K wrote: > Its reported that amd-pmf driver when built with config which does not > have ACPI_PLATFORM_PROFILE set/enabled throws a undefined references to > symbols used. > > --- > ld: vmlinux.o: in function `amd_pmf_init_sps': > /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:132: undefined reference to `platform_profile_register' > ld: vmlinux.o: in function `amd_pmf_deinit_sps': > /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:142: undefined reference to `platform_profile_remove' > --- > > Fix it by adding a "select" to the Kconfig. > > Fixes: da5ce22df5fe ("platform/x86/amd/pmf: Add support for PMF core layer") > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> Thank you for your patch, I've applied this patch to the platform-drivers-x86-amd-pmf branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=platform-drivers-x86-amd-pmf Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > > Based on "review-hans" branch. > > drivers/platform/x86/amd/pmf/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/amd/pmf/Kconfig b/drivers/platform/x86/amd/pmf/Kconfig > index e65ffa52229b..c375498c4071 100644 > --- a/drivers/platform/x86/amd/pmf/Kconfig > +++ b/drivers/platform/x86/amd/pmf/Kconfig > @@ -6,6 +6,7 @@ > config AMD_PMF > tristate "AMD Platform Management Framework" > depends on ACPI && PCI > + select ACPI_PLATFORM_PROFILE > help > This driver provides support for the AMD Platform Management Framework. > The goal is to enhance end user experience by making AMD PCs smarter,
Hi, On 8/19/22 10:38, Shyam Sundar S K wrote: > Its reported that amd-pmf driver when built with config which does not > have ACPI_PLATFORM_PROFILE set/enabled throws a undefined references to > symbols used. > > --- p.s. I had to manual fixup the commit message because of the use of "---" here, this is a so called cut line normally used for remarks at the end of the commit msg which are to be disregarded when applying the patch. So this use causes the commit message to end here (without e.g. your S-o-b). I just noticed you've done the same for quoting the clang warnings in the other patch. In the future please dont't use "---" in the middle of the commit message. Thanks & Regards, Hans > ld: vmlinux.o: in function `amd_pmf_init_sps': > /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:132: undefined reference to `platform_profile_register' > ld: vmlinux.o: in function `amd_pmf_deinit_sps': > /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:142: undefined reference to `platform_profile_remove' > --- > > Fix it by adding a "select" to the Kconfig. > > Fixes: da5ce22df5fe ("platform/x86/amd/pmf: Add support for PMF core layer") > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> > --- > > Based on "review-hans" branch. > > drivers/platform/x86/amd/pmf/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/amd/pmf/Kconfig b/drivers/platform/x86/amd/pmf/Kconfig > index e65ffa52229b..c375498c4071 100644 > --- a/drivers/platform/x86/amd/pmf/Kconfig > +++ b/drivers/platform/x86/amd/pmf/Kconfig > @@ -6,6 +6,7 @@ > config AMD_PMF > tristate "AMD Platform Management Framework" > depends on ACPI && PCI > + select ACPI_PLATFORM_PROFILE > help > This driver provides support for the AMD Platform Management Framework. > The goal is to enhance end user experience by making AMD PCs smarter,
diff --git a/drivers/platform/x86/amd/pmf/Kconfig b/drivers/platform/x86/amd/pmf/Kconfig index e65ffa52229b..c375498c4071 100644 --- a/drivers/platform/x86/amd/pmf/Kconfig +++ b/drivers/platform/x86/amd/pmf/Kconfig @@ -6,6 +6,7 @@ config AMD_PMF tristate "AMD Platform Management Framework" depends on ACPI && PCI + select ACPI_PLATFORM_PROFILE help This driver provides support for the AMD Platform Management Framework. The goal is to enhance end user experience by making AMD PCs smarter,
Its reported that amd-pmf driver when built with config which does not have ACPI_PLATFORM_PROFILE set/enabled throws a undefined references to symbols used. --- ld: vmlinux.o: in function `amd_pmf_init_sps': /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:132: undefined reference to `platform_profile_register' ld: vmlinux.o: in function `amd_pmf_deinit_sps': /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:142: undefined reference to `platform_profile_remove' --- Fix it by adding a "select" to the Kconfig. Fixes: da5ce22df5fe ("platform/x86/amd/pmf: Add support for PMF core layer") Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> --- Based on "review-hans" branch. drivers/platform/x86/amd/pmf/Kconfig | 1 + 1 file changed, 1 insertion(+)