| Message ID | 20220910085836.84962-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | leds: simatic-ipc-leds-gpio: Make simatic_ipc_led_gpio_table static | expand |
Hi all, On 9/10/22 10:58, Hans de Goede wrote: > simatic_ipc_led_gpio_table is only used inside simatic-ipc-leds-gpio.c, > make it static. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > Note since this is a fix to a patch which I merged through the pdx86 > tree I plan to merge this today through the pdx86 tree as well. I've added this to my review-hans (soon to be for-next) branch now. Regards, Hans > --- > drivers/leds/simple/simatic-ipc-leds-gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.c b/drivers/leds/simple/simatic-ipc-leds-gpio.c > index 0d73dcbeec2d..b9eeb8702df0 100644 > --- a/drivers/leds/simple/simatic-ipc-leds-gpio.c > +++ b/drivers/leds/simple/simatic-ipc-leds-gpio.c > @@ -15,7 +15,7 @@ > #include <linux/platform_device.h> > #include <linux/platform_data/x86/simatic-ipc-base.h> > > -struct gpiod_lookup_table *simatic_ipc_led_gpio_table; > +static struct gpiod_lookup_table *simatic_ipc_led_gpio_table; > > static struct gpiod_lookup_table simatic_ipc_led_gpio_table_127e = { > .dev_id = "leds-gpio",
diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.c b/drivers/leds/simple/simatic-ipc-leds-gpio.c index 0d73dcbeec2d..b9eeb8702df0 100644 --- a/drivers/leds/simple/simatic-ipc-leds-gpio.c +++ b/drivers/leds/simple/simatic-ipc-leds-gpio.c @@ -15,7 +15,7 @@ #include <linux/platform_device.h> #include <linux/platform_data/x86/simatic-ipc-base.h> -struct gpiod_lookup_table *simatic_ipc_led_gpio_table; +static struct gpiod_lookup_table *simatic_ipc_led_gpio_table; static struct gpiod_lookup_table simatic_ipc_led_gpio_table_127e = { .dev_id = "leds-gpio",
simatic_ipc_led_gpio_table is only used inside simatic-ipc-leds-gpio.c, make it static. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- Note since this is a fix to a patch which I merged through the pdx86 tree I plan to merge this today through the pdx86 tree as well. --- drivers/leds/simple/simatic-ipc-leds-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)