| Message ID | 20220926033311.84765-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | acerhdf: remove unneeded semicolon | expand |
Hi, On 9/26/22 05:33, Jiapeng Chong wrote: > ./drivers/platform/x86/acerhdf.c:344:2-3: Unneeded semicolon. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2271 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/platform/x86/acerhdf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c > index a7407aa032ba..b48c6c5da147 100644 > --- a/drivers/platform/x86/acerhdf.c > +++ b/drivers/platform/x86/acerhdf.c > @@ -341,7 +341,7 @@ static void acerhdf_check_param(struct thermal_zone_device *thermal) > pr_err("fanoff temperature (%d) is above fanon temperature (%d), clamping to %d\n", > fanoff, fanon, fanon); > fanoff = fanon; > - }; > + } > > trips[0].temperature = fanon; > trips[0].hysteresis = fanon - fanoff; This patch does not apply on my current for-next branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next I guess that this might be based on the thermal-zone changes which are going upstream for 6.1 through another tree. Please rebase + resend this once 6.1-rc1 is out. Regards, Hans
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c index a7407aa032ba..b48c6c5da147 100644 --- a/drivers/platform/x86/acerhdf.c +++ b/drivers/platform/x86/acerhdf.c @@ -341,7 +341,7 @@ static void acerhdf_check_param(struct thermal_zone_device *thermal) pr_err("fanoff temperature (%d) is above fanon temperature (%d), clamping to %d\n", fanoff, fanon, fanon); fanoff = fanon; - }; + } trips[0].temperature = fanon; trips[0].hysteresis = fanon - fanoff;
./drivers/platform/x86/acerhdf.c:344:2-3: Unneeded semicolon. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2271 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/platform/x86/acerhdf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)