| Message ID | 20221108072023.17069-1-gaeher@mpi-sws.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | x86/thinkpad_acpi: Enable s2idle quirk for 21A1 machine type | expand |
On 11/8/2022 01:20, Lennard Gäher wrote: > Previously, the s2idle quirk was only active for the 21A0 machine type > of the P14s Gen2a product. This also enables it for the second 21A1 type, > thus reducing wake-up times from s2idle. > > Signed-off-by: Lennard Gäher <gaeher@mpi-sws.org> > Suggested-by: Mario Limonciello <mario.limonciello@amd.com> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2181 > --- > drivers/platform/x86/thinkpad_acpi.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index 20e5c043a8e8..8476dfef4e62 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -4497,6 +4497,14 @@ static const struct dmi_system_id fwbug_list[] __initconst = { > DMI_MATCH(DMI_PRODUCT_NAME, "21A0"), > } > }, > + { > + .ident = "P14s Gen2 AMD", > + .driver_data = &quirk_s2idle_bug, > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_NAME, "21A1"), > + } > + }, > {} > }; >
Hi, On 11/8/22 13:47, Limonciello, Mario wrote: > On 11/8/2022 01:20, Lennard Gäher wrote: >> Previously, the s2idle quirk was only active for the 21A0 machine type >> of the P14s Gen2a product. This also enables it for the second 21A1 type, >> thus reducing wake-up times from s2idle. >> >> Signed-off-by: Lennard Gäher <gaeher@mpi-sws.org> >> Suggested-by: Mario Limonciello <mario.limonciello@amd.com> > > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> > Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2181 Thank you, I've applied the patch with both tags added: Thank you for your patch, I've applied this patch to my fixes branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes Note it will show up in my fixes branch once I've pushed my local branch there, which might take a while. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > >> --- >> drivers/platform/x86/thinkpad_acpi.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c >> index 20e5c043a8e8..8476dfef4e62 100644 >> --- a/drivers/platform/x86/thinkpad_acpi.c >> +++ b/drivers/platform/x86/thinkpad_acpi.c >> @@ -4497,6 +4497,14 @@ static const struct dmi_system_id fwbug_list[] __initconst = { >> DMI_MATCH(DMI_PRODUCT_NAME, "21A0"), >> } >> }, >> + { >> + .ident = "P14s Gen2 AMD", >> + .driver_data = &quirk_s2idle_bug, >> + .matches = { >> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), >> + DMI_MATCH(DMI_PRODUCT_NAME, "21A1"), >> + } >> + }, >> {} >> }; >> >
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 20e5c043a8e8..8476dfef4e62 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -4497,6 +4497,14 @@ static const struct dmi_system_id fwbug_list[] __initconst = { DMI_MATCH(DMI_PRODUCT_NAME, "21A0"), } }, + { + .ident = "P14s Gen2 AMD", + .driver_data = &quirk_s2idle_bug, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "21A1"), + } + }, {} };
Previously, the s2idle quirk was only active for the 21A0 machine type of the P14s Gen2a product. This also enables it for the second 21A1 type, thus reducing wake-up times from s2idle. Signed-off-by: Lennard Gäher <gaeher@mpi-sws.org> Suggested-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/platform/x86/thinkpad_acpi.c | 8 ++++++++ 1 file changed, 8 insertions(+)