From patchwork Thu Mar 2 14:47:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13157383 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 744A3C7EE36 for ; Thu, 2 Mar 2023 14:48:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230116AbjCBOr7 (ORCPT ); Thu, 2 Mar 2023 09:47:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230075AbjCBOrw (ORCPT ); Thu, 2 Mar 2023 09:47:52 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0345041B72 for ; Thu, 2 Mar 2023 06:47:50 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDg-00045R-B7; Thu, 02 Mar 2023 15:47:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDe-001Lsi-WE; Thu, 02 Mar 2023 15:47:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDe-001Zqw-4L; Thu, 02 Mar 2023 15:47:42 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 26/29] platform/x86: samsung-q10: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:29 +0100 Message-Id: <20230302144732.1903781-27-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1631; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=+GOxOWYmv6duofeGht03dZCq2oL/vZ0wyWmPfKijFXc=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbxZQvm4g0jdxlGvF1cAfRQJNgxIrXIFs7JD 6/CIRehgNSJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC28QAKCRDB/BR4rcrs CblBB/sFtXfcdHErOkkcEQ8hZ49eFrmoJjb63KCPW+FGF2714vGdahbqBDkUlqhs9JJurJ9/KEL QpaH8/JbmF+gYceOJT10k10EU+oOvOxbOWtd5Yoa8p72Pwu5JR89xjLfYT7FFNyFd16Clb+lLG6 XcXu4K8enCI5fh6hTnk18uruU6G51Y3SbQr8KIbTr/insJrWBvl4zaLxke9oQ3SVWN7kwIc2/iQ 3VZtClYPMdpLMo9pNM9ntQEDbkkq06044P+8IFmVXe7yB8wy4qvCO5FtflsOlavbbH1mZ5lh16E k4uvo6NVrVx/Ebej/kuVTIJdQy/SW6J2wfJlUHVR/lKtf4Bf X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: platform-driver-x86@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/samsung-q10.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/samsung-q10.c b/drivers/platform/x86/samsung-q10.c index 6eb08b539311..134e2c3d91ca 100644 --- a/drivers/platform/x86/samsung-q10.c +++ b/drivers/platform/x86/samsung-q10.c @@ -65,14 +65,12 @@ static int samsungq10_probe(struct platform_device *pdev) return 0; } -static int samsungq10_remove(struct platform_device *pdev) +static void samsungq10_remove(struct platform_device *pdev) { struct backlight_device *bd = platform_get_drvdata(pdev); backlight_device_unregister(bd); - - return 0; } static struct platform_driver samsungq10_driver = { @@ -80,7 +78,7 @@ static struct platform_driver samsungq10_driver = { .name = KBUILD_MODNAME, }, .probe = samsungq10_probe, - .remove = samsungq10_remove, + .remove_new = samsungq10_remove, }; static struct platform_device *samsungq10_device;