| Message ID | 20230309094035.18736-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2] platform/x86: x86-android-tablets: Add depends on PMIC_OPREGION | expand |
Hi, On 3/9/23 10:40, Hans de Goede wrote: > Add a depends on PMIC_OPREGION to x86-android-tablets Kconfig to fix > the following build error: > > ERROR: modpost: "intel_soc_pmic_exec_mipi_pmic_seq_element" > [drivers/platform/x86/x86-android-tablets/x86-android-tablets.ko] undefined! > > Fixes: 9b1d2662b8c5 ("platform/x86: x86-android-tablets: Add touchscreen support for Lenovo Yoga Tab 3 Pro YT3-X90F") > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/oe-kbuild-all/202303091711.howZNrIY-lkp@intel.com/ > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > Changes in v2: > - Add Fixes tag I've pushed this out to the pdx86/for-next branch now. Regards, Hans > --- > drivers/platform/x86/x86-android-tablets/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/x86-android-tablets/Kconfig b/drivers/platform/x86/x86-android-tablets/Kconfig > index 2b3daca5380b..6603461d4273 100644 > --- a/drivers/platform/x86/x86-android-tablets/Kconfig > +++ b/drivers/platform/x86/x86-android-tablets/Kconfig > @@ -5,7 +5,7 @@ > > config X86_ANDROID_TABLETS > tristate "X86 Android tablet support" > - depends on I2C && SPI && SERIAL_DEV_BUS && ACPI && EFI && GPIOLIB > + depends on I2C && SPI && SERIAL_DEV_BUS && ACPI && EFI && GPIOLIB && PMIC_OPREGION > help > X86 tablets which ship with Android as (part of) the factory image > typically have various problems with their DSDTs. The factory kernels
diff --git a/drivers/platform/x86/x86-android-tablets/Kconfig b/drivers/platform/x86/x86-android-tablets/Kconfig index 2b3daca5380b..6603461d4273 100644 --- a/drivers/platform/x86/x86-android-tablets/Kconfig +++ b/drivers/platform/x86/x86-android-tablets/Kconfig @@ -5,7 +5,7 @@ config X86_ANDROID_TABLETS tristate "X86 Android tablet support" - depends on I2C && SPI && SERIAL_DEV_BUS && ACPI && EFI && GPIOLIB + depends on I2C && SPI && SERIAL_DEV_BUS && ACPI && EFI && GPIOLIB && PMIC_OPREGION help X86 tablets which ship with Android as (part of) the factory image typically have various problems with their DSDTs. The factory kernels
Add a depends on PMIC_OPREGION to x86-android-tablets Kconfig to fix the following build error: ERROR: modpost: "intel_soc_pmic_exec_mipi_pmic_seq_element" [drivers/platform/x86/x86-android-tablets/x86-android-tablets.ko] undefined! Fixes: 9b1d2662b8c5 ("platform/x86: x86-android-tablets: Add touchscreen support for Lenovo Yoga Tab 3 Pro YT3-X90F") Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/oe-kbuild-all/202303091711.howZNrIY-lkp@intel.com/ Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- Changes in v2: - Add Fixes tag --- drivers/platform/x86/x86-android-tablets/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)