| Message ID | 20230714144435.1239776-1-Shyam-sundar.S-k@amd.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2,1/2] platform/x86/amd/pmf: reduce verbosity of apmf_get_system_params | expand |
Hi, On 7/14/23 16:44, Shyam Sundar S K wrote: > apmf_get_system_params() failure is not a critical event, reduce its > verbosity from dev_err to dev_dbg. > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > v1->v2: > - Rebase to review-hans branch > > drivers/platform/x86/amd/pmf/acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c > index 081e84e116e7..732b15b392ab 100644 > --- a/drivers/platform/x86/amd/pmf/acpi.c > +++ b/drivers/platform/x86/amd/pmf/acpi.c > @@ -289,7 +289,7 @@ int apmf_acpi_init(struct amd_pmf_dev *pmf_dev) > > ret = apmf_get_system_params(pmf_dev); > if (ret) { > - dev_err(pmf_dev->dev, "APMF apmf_get_system_params failed :%d\n", ret); > + dev_dbg(pmf_dev->dev, "APMF apmf_get_system_params failed :%d\n", ret); > goto out; > } >
On 7/14/23 12:12, Hans de Goede wrote: > Hi, > > On 7/14/23 16:44, Shyam Sundar S K wrote: >> apmf_get_system_params() failure is not a critical event, reduce its >> verbosity from dev_err to dev_dbg. >> >> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> >> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> > > Thank you for your patch-series, I've applied the series to my > review-hans branch: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans > > Note it will show up in my review-hans branch once I've pushed my > local branch there, which might take a while. > > Once I've run some tests on this branch the patches there will be > added to the platform-drivers-x86/for-next branch and eventually > will be included in the pdx86 pull-request to Linus for the next > merge-window. So this isn't a fix persay, but the function introduced by this actually is part of the functions mentioned in the SPS bug: https://bugzilla.kernel.org/show_bug.cgi?id=217571 That is - that system should have exported a SPS, but it wasn't associated with values stored in a table parsed by the PMF driver. The EC can still potentially react to SPS events. So I wonder if maybe this should actually go for -fixes so that this system at least gets a slider. Thanks! > > Regards, > > Hans > > > >> --- >> v1->v2: >> - Rebase to review-hans branch >> >> drivers/platform/x86/amd/pmf/acpi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c >> index 081e84e116e7..732b15b392ab 100644 >> --- a/drivers/platform/x86/amd/pmf/acpi.c >> +++ b/drivers/platform/x86/amd/pmf/acpi.c >> @@ -289,7 +289,7 @@ int apmf_acpi_init(struct amd_pmf_dev *pmf_dev) >> >> ret = apmf_get_system_params(pmf_dev); >> if (ret) { >> - dev_err(pmf_dev->dev, "APMF apmf_get_system_params failed :%d\n", ret); >> + dev_dbg(pmf_dev->dev, "APMF apmf_get_system_params failed :%d\n", ret); >> goto out; >> } >> >
diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c index 081e84e116e7..732b15b392ab 100644 --- a/drivers/platform/x86/amd/pmf/acpi.c +++ b/drivers/platform/x86/amd/pmf/acpi.c @@ -289,7 +289,7 @@ int apmf_acpi_init(struct amd_pmf_dev *pmf_dev) ret = apmf_get_system_params(pmf_dev); if (ret) { - dev_err(pmf_dev->dev, "APMF apmf_get_system_params failed :%d\n", ret); + dev_dbg(pmf_dev->dev, "APMF apmf_get_system_params failed :%d\n", ret); goto out; }