| Message ID | 20231006175352.1753017-5-teackot@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Hans de Goede |
| Headers | show |
| Series | platform/x86: msi-ec: add and fix EC configs | expand |
On Fri, 6 Oct 2023, Nikita Kravets wrote: > Fix the charge control address of CONF3 and remove an incorrect firmware > version which turned out to be a BIOS firmware and not an EC firmware. > > Fixes: 392cacf2aa10 ("platform/x86: Add new msi-ec driver") > Cc: Aakash Singh <mail@singhaakash.dev> > Cc: Jose Angel Pastrana <japp0005@red.ujaen.es> > Signed-off-by: Nikita Kravets <teackot@gmail.com> > --- > drivers/platform/x86/msi-ec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/msi-ec.c b/drivers/platform/x86/msi-ec.c > index f26a3121092f..492eb383ee7a 100644 > --- a/drivers/platform/x86/msi-ec.c > +++ b/drivers/platform/x86/msi-ec.c > @@ -276,14 +276,13 @@ static struct msi_ec_conf CONF2 __initdata = { > > static const char * const ALLOWED_FW_3[] __initconst = { > "1592EMS1.111", > - "E1592IMS.10C", > NULL > }; > > static struct msi_ec_conf CONF3 __initdata = { > .allowed_fw = ALLOWED_FW_3, > .charge_control = { > - .address = 0xef, > + .address = 0xd7, > .offset_start = 0x8a, > .offset_end = 0x80, > .range_min = 0x8a, Thanks. Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Hi, On 10/6/23 19:53, Nikita Kravets wrote: > Fix the charge control address of CONF3 and remove an incorrect firmware > version which turned out to be a BIOS firmware and not an EC firmware. > > Fixes: 392cacf2aa10 ("platform/x86: Add new msi-ec driver") > Cc: Aakash Singh <mail@singhaakash.dev> > Cc: Jose Angel Pastrana <japp0005@red.ujaen.es> > Signed-off-by: Nikita Kravets <teackot@gmail.com> Thank you for your patch/series, I've applied this patch (series) to the pdx86 fixes branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes Note it will show up in the pdx86 fixes branch once I've pushed my local branch there, which might take a while. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > --- > drivers/platform/x86/msi-ec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/msi-ec.c b/drivers/platform/x86/msi-ec.c > index f26a3121092f..492eb383ee7a 100644 > --- a/drivers/platform/x86/msi-ec.c > +++ b/drivers/platform/x86/msi-ec.c > @@ -276,14 +276,13 @@ static struct msi_ec_conf CONF2 __initdata = { > > static const char * const ALLOWED_FW_3[] __initconst = { > "1592EMS1.111", > - "E1592IMS.10C", > NULL > }; > > static struct msi_ec_conf CONF3 __initdata = { > .allowed_fw = ALLOWED_FW_3, > .charge_control = { > - .address = 0xef, > + .address = 0xd7, > .offset_start = 0x8a, > .offset_end = 0x80, > .range_min = 0x8a,
diff --git a/drivers/platform/x86/msi-ec.c b/drivers/platform/x86/msi-ec.c index f26a3121092f..492eb383ee7a 100644 --- a/drivers/platform/x86/msi-ec.c +++ b/drivers/platform/x86/msi-ec.c @@ -276,14 +276,13 @@ static struct msi_ec_conf CONF2 __initdata = { static const char * const ALLOWED_FW_3[] __initconst = { "1592EMS1.111", - "E1592IMS.10C", NULL }; static struct msi_ec_conf CONF3 __initdata = { .allowed_fw = ALLOWED_FW_3, .charge_control = { - .address = 0xef, + .address = 0xd7, .offset_start = 0x8a, .offset_end = 0x80, .range_min = 0x8a,
Fix the charge control address of CONF3 and remove an incorrect firmware version which turned out to be a BIOS firmware and not an EC firmware. Fixes: 392cacf2aa10 ("platform/x86: Add new msi-ec driver") Cc: Aakash Singh <mail@singhaakash.dev> Cc: Jose Angel Pastrana <japp0005@red.ujaen.es> Signed-off-by: Nikita Kravets <teackot@gmail.com> --- drivers/platform/x86/msi-ec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)