| Message ID | 20231010125917.138225-12-Shyam-sundar.S-k@amd.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Introduce PMF Smart PC Solution Builder Feature | expand |
On Tue, 10 Oct 2023, Shyam Sundar S K wrote: > Sometimes policy binary retrieved from the BIOS maybe incorrect that can > end up in failing to enable the Smart PC solution feature. > > Use print_hex_dump_debug() to dump the policy binary in hex, so that we > debug the issues related to the binary even before sending that to TA. > > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> > --- > drivers/platform/x86/amd/pmf/tee-if.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c > index 994daf945795..e4386f503ad0 100644 > --- a/drivers/platform/x86/amd/pmf/tee-if.c > +++ b/drivers/platform/x86/amd/pmf/tee-if.c > @@ -275,6 +275,12 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_dev *dev) > } > > #ifdef CONFIG_AMD_PMF_DEBUG > +static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev) > +{ > + print_hex_dump_debug("(pb): ", DUMP_PREFIX_OFFSET, 16, 1, dev->policy_buf, > + dev->policy_sz, false); > +} > + You forgot to add the empty version of amd_pmf_hex_dump_pb function into #else part (so the compile fails if CONFIG_AMD_PMF_DEBUG is not set). > static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf, > size_t length, loff_t *pos) > { > @@ -289,6 +295,7 @@ static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf, > if (copy_from_user(dev->policy_buf, buf, dev->policy_sz)) > return -EFAULT; > > + amd_pmf_hex_dump_pb(dev); > ret = amd_pmf_start_policy_engine(dev); > if (ret) > return -EINVAL; > @@ -327,6 +334,7 @@ static int amd_pmf_open_pb(struct amd_pmf_dev *dev, struct dentry *debugfs_root) > } > > static void amd_pmf_remove_pb(struct amd_pmf_dev *dev) {} > +static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev) {} > #endif > > static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev) > @@ -341,6 +349,7 @@ static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev) > > memcpy(dev->policy_buf, dev->policy_base, dev->policy_sz); > > + amd_pmf_hex_dump_pb(dev); > if (pb_side_load) > amd_pmf_open_pb(dev, dev->dbgfs_dir); > >
On 10/10/2023 6:38 PM, Ilpo Järvinen wrote: > On Tue, 10 Oct 2023, Shyam Sundar S K wrote: > >> Sometimes policy binary retrieved from the BIOS maybe incorrect that can >> end up in failing to enable the Smart PC solution feature. >> >> Use print_hex_dump_debug() to dump the policy binary in hex, so that we >> debug the issues related to the binary even before sending that to TA. >> >> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> >> --- >> drivers/platform/x86/amd/pmf/tee-if.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c >> index 994daf945795..e4386f503ad0 100644 >> --- a/drivers/platform/x86/amd/pmf/tee-if.c >> +++ b/drivers/platform/x86/amd/pmf/tee-if.c >> @@ -275,6 +275,12 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_dev *dev) >> } >> >> #ifdef CONFIG_AMD_PMF_DEBUG >> +static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev) >> +{ >> + print_hex_dump_debug("(pb): ", DUMP_PREFIX_OFFSET, 16, 1, dev->policy_buf, >> + dev->policy_sz, false); >> +} >> + > > You forgot to add the empty version of amd_pmf_hex_dump_pb function into > #else part (so the compile fails if CONFIG_AMD_PMF_DEBUG is not set). > It's there (see below). I have just grouped the functions that come under #ifdef CONFIG_AMD_PMF_DEBUG and #else so that's more readable. >> static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf, >> size_t length, loff_t *pos) >> { >> @@ -289,6 +295,7 @@ static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf, >> if (copy_from_user(dev->policy_buf, buf, dev->policy_sz)) >> return -EFAULT; >> >> + amd_pmf_hex_dump_pb(dev); >> ret = amd_pmf_start_policy_engine(dev); >> if (ret) >> return -EINVAL; >> @@ -327,6 +334,7 @@ static int amd_pmf_open_pb(struct amd_pmf_dev *dev, struct dentry *debugfs_root) >> } >> >> static void amd_pmf_remove_pb(struct amd_pmf_dev *dev) {} >> +static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev) {} Here is the empty amd_pmf_hex_dump_pb(). Thanks, Shyam >> #endif >> >> static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev) >> @@ -341,6 +349,7 @@ static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev) >> >> memcpy(dev->policy_buf, dev->policy_base, dev->policy_sz); >> >> + amd_pmf_hex_dump_pb(dev); >> if (pb_side_load) >> amd_pmf_open_pb(dev, dev->dbgfs_dir); >> >> >
On Tue, 10 Oct 2023, Shyam Sundar S K wrote: > On 10/10/2023 6:38 PM, Ilpo Järvinen wrote: > > On Tue, 10 Oct 2023, Shyam Sundar S K wrote: > > > >> Sometimes policy binary retrieved from the BIOS maybe incorrect that can > >> end up in failing to enable the Smart PC solution feature. > >> > >> Use print_hex_dump_debug() to dump the policy binary in hex, so that we > >> debug the issues related to the binary even before sending that to TA. > >> > >> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> > >> --- > >> drivers/platform/x86/amd/pmf/tee-if.c | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c > >> index 994daf945795..e4386f503ad0 100644 > >> --- a/drivers/platform/x86/amd/pmf/tee-if.c > >> +++ b/drivers/platform/x86/amd/pmf/tee-if.c > >> @@ -275,6 +275,12 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_dev *dev) > >> } > >> > >> #ifdef CONFIG_AMD_PMF_DEBUG > >> +static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev) > >> +{ > >> + print_hex_dump_debug("(pb): ", DUMP_PREFIX_OFFSET, 16, 1, dev->policy_buf, > >> + dev->policy_sz, false); > >> +} > >> + > > > > You forgot to add the empty version of amd_pmf_hex_dump_pb function into > > #else part (so the compile fails if CONFIG_AMD_PMF_DEBUG is not set). > > > > It's there (see below). I have just grouped the functions that come > under #ifdef CONFIG_AMD_PMF_DEBUG and #else so that's more readable. > > >> static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf, > >> size_t length, loff_t *pos) > >> { > >> @@ -289,6 +295,7 @@ static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf, > >> if (copy_from_user(dev->policy_buf, buf, dev->policy_sz)) > >> return -EFAULT; > >> > >> + amd_pmf_hex_dump_pb(dev); > >> ret = amd_pmf_start_policy_engine(dev); > >> if (ret) > >> return -EINVAL; > >> @@ -327,6 +334,7 @@ static int amd_pmf_open_pb(struct amd_pmf_dev *dev, struct dentry *debugfs_root) > >> } > >> > >> static void amd_pmf_remove_pb(struct amd_pmf_dev *dev) {} > >> +static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev) {} > > Here is the empty amd_pmf_hex_dump_pb(). Ah, sorry. I was confused by the intermediate change.
On 10/10/2023 07:59, Shyam Sundar S K wrote: > Sometimes policy binary retrieved from the BIOS maybe incorrect that can > end up in failing to enable the Smart PC solution feature. > > Use print_hex_dump_debug() to dump the policy binary in hex, so that we > debug the issues related to the binary even before sending that to TA. > > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/platform/x86/amd/pmf/tee-if.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c > index 994daf945795..e4386f503ad0 100644 > --- a/drivers/platform/x86/amd/pmf/tee-if.c > +++ b/drivers/platform/x86/amd/pmf/tee-if.c > @@ -275,6 +275,12 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_dev *dev) > } > > #ifdef CONFIG_AMD_PMF_DEBUG > +static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev) > +{ > + print_hex_dump_debug("(pb): ", DUMP_PREFIX_OFFSET, 16, 1, dev->policy_buf, > + dev->policy_sz, false); > +} > + > static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf, > size_t length, loff_t *pos) > { > @@ -289,6 +295,7 @@ static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf, > if (copy_from_user(dev->policy_buf, buf, dev->policy_sz)) > return -EFAULT; > > + amd_pmf_hex_dump_pb(dev); > ret = amd_pmf_start_policy_engine(dev); > if (ret) > return -EINVAL; > @@ -327,6 +334,7 @@ static int amd_pmf_open_pb(struct amd_pmf_dev *dev, struct dentry *debugfs_root) > } > > static void amd_pmf_remove_pb(struct amd_pmf_dev *dev) {} > +static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev) {} > #endif > > static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev) > @@ -341,6 +349,7 @@ static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev) > > memcpy(dev->policy_buf, dev->policy_base, dev->policy_sz); > > + amd_pmf_hex_dump_pb(dev); > if (pb_side_load) > amd_pmf_open_pb(dev, dev->dbgfs_dir); >
diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c index 994daf945795..e4386f503ad0 100644 --- a/drivers/platform/x86/amd/pmf/tee-if.c +++ b/drivers/platform/x86/amd/pmf/tee-if.c @@ -275,6 +275,12 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_dev *dev) } #ifdef CONFIG_AMD_PMF_DEBUG +static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev) +{ + print_hex_dump_debug("(pb): ", DUMP_PREFIX_OFFSET, 16, 1, dev->policy_buf, + dev->policy_sz, false); +} + static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf, size_t length, loff_t *pos) { @@ -289,6 +295,7 @@ static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf, if (copy_from_user(dev->policy_buf, buf, dev->policy_sz)) return -EFAULT; + amd_pmf_hex_dump_pb(dev); ret = amd_pmf_start_policy_engine(dev); if (ret) return -EINVAL; @@ -327,6 +334,7 @@ static int amd_pmf_open_pb(struct amd_pmf_dev *dev, struct dentry *debugfs_root) } static void amd_pmf_remove_pb(struct amd_pmf_dev *dev) {} +static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev) {} #endif static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev) @@ -341,6 +349,7 @@ static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev) memcpy(dev->policy_buf, dev->policy_base, dev->policy_sz); + amd_pmf_hex_dump_pb(dev); if (pb_side_load) amd_pmf_open_pb(dev, dev->dbgfs_dir);
Sometimes policy binary retrieved from the BIOS maybe incorrect that can end up in failing to enable the Smart PC solution feature. Use print_hex_dump_debug() to dump the policy binary in hex, so that we debug the issues related to the binary even before sending that to TA. Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> --- drivers/platform/x86/amd/pmf/tee-if.c | 9 +++++++++ 1 file changed, 9 insertions(+)