| Message ID | 20231219-hp-password-v1-1-052fe7b6b7f1@google.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86: hp-bioscfg: Removed needless asm-generic | expand |
On Tue, Dec 19, 2023 at 10:10:52PM +0000, Tanzir Hasan wrote: > asm-generic/posix-types.h is obtained through bioscfg.h so there is no > need to include it. I verified that by: 1. building with V=1 2. taking the compiler invocation and adding -H . drivers/platform/x86/hp/hp-bioscfg/bioscfg.h .. ./include/linux/wmi.h ... ./include/linux/device.h .... ./include/linux/dev_printk.h ..... ./include/linux/compiler.h ...... ./arch/x86/include/generated/asm/rwonce.h ....... ./include/asm-generic/rwonce.h ........ ./include/linux/kasan-checks.h ......... ./include/linux/types.h .......... ./include/uapi/linux/types.h ........... ./arch/x86/include/generated/uapi/asm/types.h ............ ./arch/x86/include/asm/posix_types.h ............. ./arch/x86/include/uapi/asm/posix_types_64.h .............. ./include/uapi/asm-generic/posix_types.h > It is also an asm-generic file which should be > avoided if possible. Correct, though there is a linux/posix_types.h file. biocfg.h hasn't seen any changes since introduction; perhaps some reference was removed in follow up changes to passwdobj-attributes.c, but nothing stood out. Regardless, this file builds just fine without either (asm/posix_types.h or linux/posix_types.h), and asm-generic should not be used (as suggested by Al). Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Tested-by: Nick Desaulniers <ndesaulniers@google.com> > > Suggest-by: Al Viro <viro@zeniv.linux.org.uk> > Signed-off-by: Tanzir Hasan <tanzirh@google.com> > --- > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c > index 03d0188804ba..f7efe217a4bb 100644 > --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c > +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c > @@ -7,7 +7,6 @@ > */ > > #include "bioscfg.h" > -#include <asm-generic/posix_types.h> > > GET_INSTANCE_ID(password); > /* > > --- > base-commit: 3fb7c66ac51a87984e043d9f47b7a509e3f53906 > change-id: 20231219-hp-password-19068dc438b5 > > Best regards, > -- > Tanzir Hasan <tanzirh@google.com> >
Hi, On 12/20/23 20:24, Nick Desaulniers wrote: > On Tue, Dec 19, 2023 at 10:10:52PM +0000, Tanzir Hasan wrote: >> asm-generic/posix-types.h is obtained through bioscfg.h so there is no >> need to include it. > > I verified that by: > 1. building with V=1 > 2. taking the compiler invocation and adding -H > > . drivers/platform/x86/hp/hp-bioscfg/bioscfg.h > .. ./include/linux/wmi.h > ... ./include/linux/device.h > .... ./include/linux/dev_printk.h > ..... ./include/linux/compiler.h > ...... ./arch/x86/include/generated/asm/rwonce.h > ....... ./include/asm-generic/rwonce.h > ........ ./include/linux/kasan-checks.h > ......... ./include/linux/types.h > .......... ./include/uapi/linux/types.h > ........... ./arch/x86/include/generated/uapi/asm/types.h > ............ ./arch/x86/include/asm/posix_types.h > ............. ./arch/x86/include/uapi/asm/posix_types_64.h > .............. ./include/uapi/asm-generic/posix_types.h > >> It is also an asm-generic file which should be >> avoided if possible. > > Correct, though there is a linux/posix_types.h file. > > biocfg.h hasn't seen any changes since introduction; perhaps some reference was > removed in follow up changes to passwdobj-attributes.c, but nothing stood out. > > Regardless, this file builds just fine without either (asm/posix_types.h or > linux/posix_types.h), and asm-generic should not be used (as suggested by Al). > > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > Tested-by: Nick Desaulniers <ndesaulniers@google.com> Thank you both for the patch + review, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans >> Suggest-by: Al Viro <viro@zeniv.linux.org.uk> >> Signed-off-by: Tanzir Hasan <tanzirh@google.com> >> --- >> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c >> index 03d0188804ba..f7efe217a4bb 100644 >> --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c >> +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c >> @@ -7,7 +7,6 @@ >> */ >> >> #include "bioscfg.h" >> -#include <asm-generic/posix_types.h> >> >> GET_INSTANCE_ID(password); >> /* >> >> --- >> base-commit: 3fb7c66ac51a87984e043d9f47b7a509e3f53906 >> change-id: 20231219-hp-password-19068dc438b5 >> >> Best regards, >> -- >> Tanzir Hasan <tanzirh@google.com> >> >
diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c index 03d0188804ba..f7efe217a4bb 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c @@ -7,7 +7,6 @@ */ #include "bioscfg.h" -#include <asm-generic/posix_types.h> GET_INSTANCE_ID(password); /*
asm-generic/posix-types.h is obtained through bioscfg.h so there is no need to include it. It is also an asm-generic file which should be avoided if possible. Suggest-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Tanzir Hasan <tanzirh@google.com> --- drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 1 - 1 file changed, 1 deletion(-) --- base-commit: 3fb7c66ac51a87984e043d9f47b7a509e3f53906 change-id: 20231219-hp-password-19068dc438b5 Best regards,