| Message ID | 20240220054513.2832-3-W_Armin@gmx.de (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/3] platform/x86/amd/pmf: Add missing __iomem attribute to policy_base | expand |
On 2/19/24 9:45 PM, Armin Wolf wrote: > The variable is only used internally and has no external users, > so it should me made static. > > Compile-tested only. > > Fixes: 663cc18861a0 ("platform/x86: intel_scu_ipcutil: Convert to use new SCU IPC API") > Signed-off-by: Armin Wolf <W_Armin@gmx.de> > --- Since it is not a bug fix, I am not sure whether it makes sense to add Fixes: tag. But the change wise, it is fine. Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > drivers/platform/x86/intel_scu_ipcutil.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c > index b7c10c15a3d6..7d87cbd4b9c6 100644 > --- a/drivers/platform/x86/intel_scu_ipcutil.c > +++ b/drivers/platform/x86/intel_scu_ipcutil.c > @@ -22,7 +22,7 @@ > > static int major; > > -struct intel_scu_ipc_dev *scu; > +static struct intel_scu_ipc_dev *scu; > static DEFINE_MUTEX(scu_lock); > > /* IOCTL commands */ > -- > 2.39.2 > >
diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c index b7c10c15a3d6..7d87cbd4b9c6 100644 --- a/drivers/platform/x86/intel_scu_ipcutil.c +++ b/drivers/platform/x86/intel_scu_ipcutil.c @@ -22,7 +22,7 @@ static int major; -struct intel_scu_ipc_dev *scu; +static struct intel_scu_ipc_dev *scu; static DEFINE_MUTEX(scu_lock); /* IOCTL commands */
The variable is only used internally and has no external users, so it should me made static. Compile-tested only. Fixes: 663cc18861a0 ("platform/x86: intel_scu_ipcutil: Convert to use new SCU IPC API") Signed-off-by: Armin Wolf <W_Armin@gmx.de> --- drivers/platform/x86/intel_scu_ipcutil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.39.2