| Message ID | 20240223163901.13504-3-W_Armin@gmx.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2,1/3] platform/x86/amd/pmf: Add missing __iomem attribute to policy_base | expand |
On Fri, Feb 23, 2024 at 05:39:01PM +0100, Armin Wolf wrote: > The variable is only used internally and has no external users, > so it should me made static. > > Compile-tested only. > > Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > Signed-off-by: Armin Wolf <W_Armin@gmx.de> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On Fri, 23 Feb 2024, Armin Wolf wrote: > The variable is only used internally and has no external users, > so it should me made static. > > Compile-tested only. > > Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > Signed-off-by: Armin Wolf <W_Armin@gmx.de> > --- > Changes since v1: > - remove Fixes tag > - add Reviewed-by tag > --- > drivers/platform/x86/intel_scu_ipcutil.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c > index b7c10c15a3d6..7d87cbd4b9c6 100644 > --- a/drivers/platform/x86/intel_scu_ipcutil.c > +++ b/drivers/platform/x86/intel_scu_ipcutil.c > @@ -22,7 +22,7 @@ > > static int major; > > -struct intel_scu_ipc_dev *scu; > +static struct intel_scu_ipc_dev *scu; > static DEFINE_MUTEX(scu_lock); > > /* IOCTL commands */ Thanks, I took this 3/3 and 1/3 into review-ilpo. Please check the comment I raised against 2/3.
diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c index b7c10c15a3d6..7d87cbd4b9c6 100644 --- a/drivers/platform/x86/intel_scu_ipcutil.c +++ b/drivers/platform/x86/intel_scu_ipcutil.c @@ -22,7 +22,7 @@ static int major; -struct intel_scu_ipc_dev *scu; +static struct intel_scu_ipc_dev *scu; static DEFINE_MUTEX(scu_lock); /* IOCTL commands */