From patchwork Thu Apr 4 12:34:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13617779 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0828F82C7E; Thu, 4 Apr 2024 12:34:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712234081; cv=none; b=I3te3nqVRevbxngnFHxA8hrO5/wSCsDrBaGyrEuVxh8UqTBgPEIGnG0+rYRiOv/P7Esc9ArKcM8MhNroPxwPpORinc2SW7Fel/xIgRAWiAkJBY2MPTV1zW7mlPP3Vus2EpjKWRC5E4F3hdgTbEp/yZyoQM9LcNjgcyy34Xd2l4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712234081; c=relaxed/simple; bh=qRL6MwLDG8IPLhfSjCuwK6KP5RYuL8xbctvnKfUT7mM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ZGl+UL+oAN55f4dIWbIA8jfSFoRE5Sd7fixrbAK3rKXLffbwT83KxrNqde713qXBbRS8yi4tOWJtG2Wh5yjxin3KZKYD2lbD1sfu9y4CZPTPFHtMjeDK7mdsDXXLERLrRfbeM+iUwvHMK3tgb9N0FHYKD8TFaaN56Tr/WQKATiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OCNY2xJS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OCNY2xJS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C1D0C433F1; Thu, 4 Apr 2024 12:34:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712234080; bh=qRL6MwLDG8IPLhfSjCuwK6KP5RYuL8xbctvnKfUT7mM=; h=From:To:Cc:Subject:Date:From; b=OCNY2xJS84pGPBlxbcPSDeueeEIqS4uSPHhZQj4tbWIQpJdN2laGMBmLTeamMzlkE mD5mIZQZOzesu+AfwDx9IE7M6ngJcIt6pDRksGtLnNs9VFzaBIfrrL9x2Cr6CVFT9S LDsmXcDrdLFws7CtMI70MafQesKtsYS/rVC7Wz83MatI5CZY8cATZXcXnKPNaEAG58 QRVSYtGO/vA9k7pD08APhMzAVYnSmKG1uOih2zhyUG0VeMZqecnx/0fLwZjR0fkD2Y y4Fao/dyRFeK4Opb2jHq80KB0Vm9pFnP930lsKYCGjitdh2gAtthrAcg1k2KpfIJIp J19nyl1Es9bgA== From: Arnd Bergmann To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Armin Wolf Cc: Arnd Bergmann , Henning Schild , SungHwan Jung , Ai Chao , Robert Joslyn , Henry Shi , Heiner Kallweit , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] platform/x86: quickstart: fix Kconfig selects Date: Thu, 4 Apr 2024 14:34:30 +0200 Message-Id: <20240404123435.2684819-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Arnd Bergmann The new driver Kconfig entry has a typo that causes a link failure when CONFIG_INPUT_SPARSEKMAP is disabled: x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_notify': quickstart.c:(.text+0x96): undefined reference to `sparse_keymap_report_event' x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_probe': quickstart.c:(.text+0x1da): undefined reference to `sparse_keymap_setup' Select this symbol instead of the incorrect INPUT_SPARSE_KEYMAP. Fixes: afd66f2a739e ("platform/x86: Add ACPI quickstart button (PNP0C32) driver") Signed-off-by: Arnd Bergmann Reviewed-by: Armin Wolf Reviewed-by: Kuppuswamy Sathyanarayanan --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index ba88a7f259f1..21a37f1b73ab 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -647,7 +647,7 @@ config ACPI_QUICKSTART tristate "ACPI Quickstart button driver" depends on ACPI depends on INPUT - select INPUT_SPARSE_KEYMAP + select INPUT_SPARSEKMAP help This driver adds support for ACPI quickstart button (PNP0C32) devices. The button emits a manufacturer-specific key value when pressed, so