| Message ID | 20240410140956.385-1-mario.limonciello@amd.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ilpo Järvinen |
| Headers | show |
| Series | [1/3] platform/x86/amd: pmf: Decrease error message to debug | expand |
Hi Mario, Ilpo, On 4/10/24 4:09 PM, Mario Limonciello wrote: > ASUS ROG Zephyrus G14 doesn't have _CRS in AMDI0102 device and so > there are no resources to walk. This is expected behavior because > it doesn't support Smart PC. Decrease error message to debug. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=218685 > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Thank you, this entire series looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> for the series. Ilpo, since this fixes a bug and does so based on a DMI match, so the chance for regressions is quite small I believe it would be best to merge this through the pdx86/fixes branch, can you pick this series up please ? Regards, Hans > --- > drivers/platform/x86/amd/pmf/acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c > index d0cf46e2fc8e..60fc71c9fb0f 100644 > --- a/drivers/platform/x86/amd/pmf/acpi.c > +++ b/drivers/platform/x86/amd/pmf/acpi.c > @@ -437,7 +437,7 @@ int apmf_check_smart_pc(struct amd_pmf_dev *pmf_dev) > > status = acpi_walk_resources(ahandle, METHOD_NAME__CRS, apmf_walk_resources, pmf_dev); > if (ACPI_FAILURE(status)) { > - dev_err(pmf_dev->dev, "acpi_walk_resources failed :%d\n", status); > + dev_dbg(pmf_dev->dev, "acpi_walk_resources failed :%d\n", status); > return -EINVAL; > } >
On Wed, 10 Apr 2024 09:09:54 -0500, Mario Limonciello wrote: > ASUS ROG Zephyrus G14 doesn't have _CRS in AMDI0102 device and so > there are no resources to walk. This is expected behavior because > it doesn't support Smart PC. Decrease error message to debug. > > Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/3] platform/x86/amd: pmf: Decrease error message to debug commit: 03cea821b82cbf0ee4a285f9dca6cc1d660dbef3 [2/3] platform/x86/amd: pmf: Add infrastructure for quirking supported funcs commit: ed13f622bcd594d6cefd6239b1722ed8b84ba98f [3/3] platform/x86/amd: pmf: Add quirk for ROG Zephyrus G14 commit: 9d893061ed68820de24b572d1e193b5e4737f2e0 -- i.
diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c index d0cf46e2fc8e..60fc71c9fb0f 100644 --- a/drivers/platform/x86/amd/pmf/acpi.c +++ b/drivers/platform/x86/amd/pmf/acpi.c @@ -437,7 +437,7 @@ int apmf_check_smart_pc(struct amd_pmf_dev *pmf_dev) status = acpi_walk_resources(ahandle, METHOD_NAME__CRS, apmf_walk_resources, pmf_dev); if (ACPI_FAILURE(status)) { - dev_err(pmf_dev->dev, "acpi_walk_resources failed :%d\n", status); + dev_dbg(pmf_dev->dev, "acpi_walk_resources failed :%d\n", status); return -EINVAL; }
ASUS ROG Zephyrus G14 doesn't have _CRS in AMDI0102 device and so there are no resources to walk. This is expected behavior because it doesn't support Smart PC. Decrease error message to debug. Link: https://bugzilla.kernel.org/show_bug.cgi?id=218685 Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/platform/x86/amd/pmf/acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)