| Message ID | 20240410141046.433-1-mario.limonciello@amd.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ilpo Järvinen |
| Headers | show |
| Series | platform/x86/amd: Extend Framework 13 quirk to more BIOSes | expand |
On 4/10/2024 09:10, Mario Limonciello wrote: > BIOS 03.05 still hasn't fixed the spurious IRQ1 issue. As it's still > being worked on there is still a possiblitiy that it won't need to Sorry for the typo I meant "possibility". > apply to future BIOS releases. > > Add a quirk for BIOS 03.05 as well. > Here is a link to the BIOS: Link: https://community.frame.work/t/framework-laptop-13-ryzen-7040-bios-3-05-release-and-driver-bundle-beta/48276 Also want to call out specifically "Known Issues" to show they are still working on a fix for it. IRQ1 will always be triggered on resume from standby. This issue mostly impacts Linux users. We have a potential root cause that we hope to fix in our next release. > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/platform/x86/amd/pmc/pmc-quirks.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c > index b456370166b6..b4f49720c87f 100644 > --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c > +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c > @@ -208,6 +208,15 @@ static const struct dmi_system_id fwbug_list[] = { > DMI_MATCH(DMI_BIOS_VERSION, "03.03"), > } > }, > + { > + .ident = "Framework Laptop 13 (Phoenix)", > + .driver_data = &quirk_spurious_8042, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Framework"), > + DMI_MATCH(DMI_PRODUCT_NAME, "Laptop 13 (AMD Ryzen 7040Series)"), > + DMI_MATCH(DMI_BIOS_VERSION, "03.05"), > + } > + }, > {} > }; >
Hi Mario, Ilpo, On 4/10/24 4:10 PM, Mario Limonciello wrote: > BIOS 03.05 still hasn't fixed the spurious IRQ1 issue. As it's still > being worked on there is still a possiblitiy that it won't need to > apply to future BIOS releases. > > Add a quirk for BIOS 03.05 as well. > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Ilpo, since this fixes a bug and does so based on a DMI match, so the chance for regressions is quite small, I believe it would be best to merge this through the pdx86/fixes branch, can you pick this patch up please ? Regards, Hans > --- > drivers/platform/x86/amd/pmc/pmc-quirks.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c > index b456370166b6..b4f49720c87f 100644 > --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c > +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c > @@ -208,6 +208,15 @@ static const struct dmi_system_id fwbug_list[] = { > DMI_MATCH(DMI_BIOS_VERSION, "03.03"), > } > }, > + { > + .ident = "Framework Laptop 13 (Phoenix)", > + .driver_data = &quirk_spurious_8042, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Framework"), > + DMI_MATCH(DMI_PRODUCT_NAME, "Laptop 13 (AMD Ryzen 7040Series)"), > + DMI_MATCH(DMI_BIOS_VERSION, "03.05"), > + } > + }, > {} > }; >
On Wed, 10 Apr 2024, Mario Limonciello wrote: > BIOS 03.05 still hasn't fixed the spurious IRQ1 issue. As it's still > being worked on there is still a possiblitiy that it won't need to > apply to future BIOS releases. Hi Mario, Could you explain/confirm what the second sentence is supposed to mean? Mainly I mean "it won't need to apply to future", did you perhaps mean it might need to be applied still to some future versions too besides this one because the fix is still being worked on, or what? There's also "possiblitiy" typo, in case you end up rewriting the message and send v2.
On 4/16/24 07:24, Ilpo Järvinen wrote: > On Wed, 10 Apr 2024, Mario Limonciello wrote: > >> BIOS 03.05 still hasn't fixed the spurious IRQ1 issue. As it's still >> being worked on there is still a possiblitiy that it won't need to >> apply to future BIOS releases. > > Hi Mario, > > Could you explain/confirm what the second sentence is supposed to mean? > Mainly I mean "it won't need to apply to future", did you perhaps mean it > might need to be applied still to some future versions too besides this > one because the fix is still being worked on, or what? > > There's also "possiblitiy" typo, in case you end up rewriting the message > and send v2. > You probably missed my follow up message in the thread, I tried to explain in more detail (and also caught the same typo; sorry!) https://lore.kernel.org/platform-driver-x86/ace9e5fe-0565-b24d-5394-ba4bd9f4305c@linux.intel.com/T/#mcf25cbfbd9dc5f4aace5b58c56a7f91671b2f0cc
On Tue, 16 Apr 2024, Mario Limonciello wrote: > On 4/16/24 07:24, Ilpo Järvinen wrote: > > On Wed, 10 Apr 2024, Mario Limonciello wrote: > > > > > BIOS 03.05 still hasn't fixed the spurious IRQ1 issue. As it's still > > > being worked on there is still a possiblitiy that it won't need to > > > apply to future BIOS releases. > > > > Hi Mario, > > > > Could you explain/confirm what the second sentence is supposed to mean? > > Mainly I mean "it won't need to apply to future", did you perhaps mean it > > might need to be applied still to some future versions too besides this > > one because the fix is still being worked on, or what? > > > > There's also "possiblitiy" typo, in case you end up rewriting the message > > and send v2. > > > > You probably missed my follow up message in the thread, I tried to explain in > more detail (and also caught the same typo; sorry!) > > https://lore.kernel.org/platform-driver-x86/ace9e5fe-0565-b24d-5394-ba4bd9f4305c@linux.intel.com/T/#mcf25cbfbd9dc5f4aace5b58c56a7f91671b2f0cc Okay, I had indeed missed that (or probably seen it but didn't recall/make the connection now while I started to apply patches). I'll fix the possibility typo while applying.
On Wed, 10 Apr 2024 09:10:46 -0500, Mario Limonciello wrote: > BIOS 03.05 still hasn't fixed the spurious IRQ1 issue. As it's still > being worked on there is still a possiblitiy that it won't need to > apply to future BIOS releases. > > Add a quirk for BIOS 03.05 as well. > > > [...] Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/1] platform/x86/amd: Extend Framework 13 quirk to more BIOSes commit: 978af6121b4b000befd9a45f5b65c00e39920273 -- i.
diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c index b456370166b6..b4f49720c87f 100644 --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c @@ -208,6 +208,15 @@ static const struct dmi_system_id fwbug_list[] = { DMI_MATCH(DMI_BIOS_VERSION, "03.03"), } }, + { + .ident = "Framework Laptop 13 (Phoenix)", + .driver_data = &quirk_spurious_8042, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Framework"), + DMI_MATCH(DMI_PRODUCT_NAME, "Laptop 13 (AMD Ryzen 7040Series)"), + DMI_MATCH(DMI_BIOS_VERSION, "03.05"), + } + }, {} };
BIOS 03.05 still hasn't fixed the spurious IRQ1 issue. As it's still being worked on there is still a possiblitiy that it won't need to apply to future BIOS releases. Add a quirk for BIOS 03.05 as well. Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/platform/x86/amd/pmc/pmc-quirks.c | 9 +++++++++ 1 file changed, 9 insertions(+)