| Message ID | 20240522074813.379b9fc2@gandalf.local.home (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Hans de Goede |
| Headers | show |
| Series | platform/x86: thinkpad_acpi: Select INPUT_SPARSEKMAP in Kconfig | expand |
Hi, On 5/22/24 1:48 PM, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" <rostedt@goodmis.org> > > Now that drivers/platform/x86/thinkpad_acpi.c uses > sparse_keymap_report_event(), it must select INPUT_SPARSEKMAP in its > Kconfig option otherwise the build fails with: > > ld: vmlinux.o: in function `tpacpi_input_send_key': > thinkpad_acpi.c:(.text+0xd4d27f): undefined reference to `sparse_keymap_report_event' > ld: vmlinux.o: in function `hotkey_init': > thinkpad_acpi.c:(.init.text+0x66cb6): undefined reference to `sparse_keymap_setup' > > Fixes: 42f7b965de9d ("platform/x86: thinkpad_acpi: Switch to using sparse-keymap helpers") > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> I'll include this in the next pdx86 fixes pull-request for Linus. Regards, Hans > --- > drivers/platform/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 0ec952b5d03e..1953317541ea 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -515,6 +515,7 @@ config THINKPAD_ACPI > select NVRAM > select NEW_LEDS > select LEDS_CLASS > + select INPUT_SPARSEKMAP > help > This is a driver for the IBM and Lenovo ThinkPad laptops. It adds > support for Fn-Fx key combinations, Bluetooth control, video
Hi, On 5/22/24 1:48 PM, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" <rostedt@goodmis.org> > > Now that drivers/platform/x86/thinkpad_acpi.c uses > sparse_keymap_report_event(), it must select INPUT_SPARSEKMAP in its > Kconfig option otherwise the build fails with: > > ld: vmlinux.o: in function `tpacpi_input_send_key': > thinkpad_acpi.c:(.text+0xd4d27f): undefined reference to `sparse_keymap_report_event' > ld: vmlinux.o: in function `hotkey_init': > thinkpad_acpi.c:(.init.text+0x66cb6): undefined reference to `sparse_keymap_setup' > > Fixes: 42f7b965de9d ("platform/x86: thinkpad_acpi: Switch to using sparse-keymap helpers") > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > --- > drivers/platform/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 0ec952b5d03e..1953317541ea 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -515,6 +515,7 @@ config THINKPAD_ACPI > select NVRAM > select NEW_LEDS > select LEDS_CLASS > + select INPUT_SPARSEKMAP > help > This is a driver for the IBM and Lenovo ThinkPad laptops. It adds > support for Fn-Fx key combinations, Bluetooth control, video
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 0ec952b5d03e..1953317541ea 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -515,6 +515,7 @@ config THINKPAD_ACPI select NVRAM select NEW_LEDS select LEDS_CLASS + select INPUT_SPARSEKMAP help This is a driver for the IBM and Lenovo ThinkPad laptops. It adds support for Fn-Fx key combinations, Bluetooth control, video