From patchwork Wed May 22 11:48:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 13670810 X-Patchwork-Delegate: hdegoede@redhat.com Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EB4B81748; Wed, 22 May 2024 11:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716378453; cv=none; b=cDOszeEIqLnAESv9/SAIPLlVpybuNi84xjgqziTAOs09gDfjOw/CyVDYtJ5E4HtQFvkTjW764HOWAgN1x5GTj9yBqQ72H1NLJf0MEXKbtM71YzQpNJLRmz0IPtgJNGpAJySZyfWrNNvtU19qFR97KXGUoXSW31wkLXKJoUGRCZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716378453; c=relaxed/simple; bh=ppwqjPG9mdV4Umy1sHG2Px7mW5uUSyzM6jDoXKQ5aQk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=JEtT26r6p0N0vR7dqiwwUENrMeIGEO189pyesMsC/FQhd5kq5DCDT+6Jyixt5xlTHjEvVxaQbM26WjuJcHrfc7DDQtzX7KUBl5ZnQvdDFcKoSs6ESq2LGT+Rryhwt2Cu4Ih0iAzjy0X3S4k8oYuo/S0B4Ojjgbxq61ohn/Fr6yo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEDA8C2BD11; Wed, 22 May 2024 11:47:31 +0000 (UTC) Date: Wed, 22 May 2024 07:48:13 -0400 From: Steven Rostedt To: LKML Cc: Linus Torvalds , Hans de Goede , "Ilpo =?utf-8?b?SsOkcnZpbmVu?= " , platform-driver-x86@vger.kernel.org Subject: [PATCH] platform/x86: thinkpad_acpi: Select INPUT_SPARSEKMAP in Kconfig Message-ID: <20240522074813.379b9fc2@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Steven Rostedt (Google)" Now that drivers/platform/x86/thinkpad_acpi.c uses sparse_keymap_report_event(), it must select INPUT_SPARSEKMAP in its Kconfig option otherwise the build fails with: ld: vmlinux.o: in function `tpacpi_input_send_key': thinkpad_acpi.c:(.text+0xd4d27f): undefined reference to `sparse_keymap_report_event' ld: vmlinux.o: in function `hotkey_init': thinkpad_acpi.c:(.init.text+0x66cb6): undefined reference to `sparse_keymap_setup' Fixes: 42f7b965de9d ("platform/x86: thinkpad_acpi: Switch to using sparse-keymap helpers") Signed-off-by: Steven Rostedt (Google) Reviewed-by: Hans de Goede --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 0ec952b5d03e..1953317541ea 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -515,6 +515,7 @@ config THINKPAD_ACPI select NVRAM select NEW_LEDS select LEDS_CLASS + select INPUT_SPARSEKMAP help This is a driver for the IBM and Lenovo ThinkPad laptops. It adds support for Fn-Fx key combinations, Bluetooth control, video