[1/9] platform/x86:intel/pmc: Use the return value of pmc_core_send_msg

Commit Message

Xi Pardee June 24, 2024, 8:32 p.m. UTC

From: Xi Pardee <[e-mail]>

Use the return value of pmc_core_send_msg() directly instead of
assigning another code when an error occurs.

Signed-off-by: Xi Pardee <[e-mail]>
---
 drivers/platform/x86/intel/pmc/core.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

Patch

diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c
index 65eb09c7af6a..e656d51e7ad5 100644
--- a/drivers/platform/x86/intel/pmc/core.c
+++ b/drivers/platform/x86/intel/pmc/core.c
@@ -403,18 +403,16 @@  static int pmc_core_mphy_pg_show(struct seq_file *s, void *unused)
 
 	mutex_lock(&pmcdev->lock);
 
-	if (pmc_core_send_msg(pmc, &mphy_core_reg_low) != 0) {
-		err = -EBUSY;
+	err = pmc_core_send_msg(pmc, &mphy_core_reg_low);
+	if (err)
 		goto out_unlock;
-	}
 
 	msleep(10);
 	val_low = pmc_core_reg_read(pmc, SPT_PMC_MFPMC_OFFSET);
 
-	if (pmc_core_send_msg(pmc, &mphy_core_reg_high) != 0) {
-		err = -EBUSY;
+	err = pmc_core_send_msg(pmc, &mphy_core_reg_high);
+	if (err)
 		goto out_unlock;
-	}
 
 	msleep(10);
 	val_high = pmc_core_reg_read(pmc, SPT_PMC_MFPMC_OFFSET);
@@ -455,10 +453,9 @@  static int pmc_core_pll_show(struct seq_file *s, void *unused)
 	mphy_common_reg  = (SPT_PMC_MPHY_COM_STS_0 << 16);
 	mutex_lock(&pmcdev->lock);
 
-	if (pmc_core_send_msg(pmc, &mphy_common_reg) != 0) {
-		err = -EBUSY;
+	err = pmc_core_send_msg(pmc, &mphy_common_reg);
+	if (err)
 		goto out_unlock;
-	}
 
 	/* Observed PMC HW response latency for MTPMC-MFPMC is ~10 ms */
 	msleep(10);