Message ID | 20240930000046.51388-3-luke@ljones.dev (mailing list archive) |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | platform/x86: introduce asus-armoury driver | expand |
On Mon, 30 Sep 2024, Luke D. Jones wrote: > A small change to asus_wmi_evaluate_method() was introduced during > asus-armoury driver development to put the exports behind a namespace. > > Import that namespace here. > > Signed-off-by: Luke D. Jones <luke@ljones.dev> > Acked-by: Jiri Kosina <jkosina@suse.com> > --- > drivers/hid/hid-asus.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c > index a4b47319ad8e..9540e3e19cce 100644 > --- a/drivers/hid/hid-asus.c > +++ b/drivers/hid/hid-asus.c > @@ -1301,4 +1301,5 @@ static struct hid_driver asus_driver = { > }; > module_hid_driver(asus_driver); > > +MODULE_IMPORT_NS(ASUS_WMI); > MODULE_LICENSE("GPL"); This order of patches will break the build since 1/9 put asus_wmi_evaluate_method() into that namespace so this module will fail build until this patch 2/9. IMO, this change should just be part of 1/9 or perhaps better approach would be to make a new first patch into the series that does this and moves the export of asus_wmi_evaluate_method() into the namespace. The rest of the patch 1/9 would then become 2/9.
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index a4b47319ad8e..9540e3e19cce 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -1301,4 +1301,5 @@ static struct hid_driver asus_driver = { }; module_hid_driver(asus_driver); +MODULE_IMPORT_NS(ASUS_WMI); MODULE_LICENSE("GPL");