diff mbox series

[v1] platform/x86: classmate-laptop: Replace snprintf in show functions with sysfs_emit

Message ID 20241019054426.8182-1-zenghongling@kylinos.cn (mailing list archive)
State Accepted, archived
Headers show
Series [v1] platform/x86: classmate-laptop: Replace snprintf in show functions with sysfs_emit | expand

Commit Message

Hongling Zeng Oct. 19, 2024, 5:44 a.m. UTC 
show() must not use snprintf() when formatting the value to be
returned to user space.

Signed-off-by: Hongling Zeng<zenghongling@kylinos.cn>
---
 drivers/platform/x86/classmate-laptop.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Ilpo Järvinen Oct. 21, 2024, 10:51 a.m. UTC | #1 
On Sat, 19 Oct 2024, Hongling Zeng wrote:

>   show() must not use snprintf() when formatting the value to be
> returned to user space.
> 
> Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>

Hi,

I've applied this with modifications:

- I had to cleanup the extra spaces before show() in the text above which
  I had already earlier noted you should fix. :-(
- Added #include <linux/sysfs.h>
diff mbox series

Patch

diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
index cb6fce6..14c238f 100644
--- a/drivers/platform/x86/classmate-laptop.c
+++ b/drivers/platform/x86/classmate-laptop.c
@@ -208,7 +208,7 @@  static ssize_t cmpc_accel_sensitivity_show_v4(struct device *dev,
 	inputdev = dev_get_drvdata(&acpi->dev);
 	accel = dev_get_drvdata(&inputdev->dev);
 
-	return sprintf(buf, "%d\n", accel->sensitivity);
+	return sysfs_emit(buf, "%d\n", accel->sensitivity);
 }
 
 static ssize_t cmpc_accel_sensitivity_store_v4(struct device *dev,
@@ -257,7 +257,7 @@  static ssize_t cmpc_accel_g_select_show_v4(struct device *dev,
 	inputdev = dev_get_drvdata(&acpi->dev);
 	accel = dev_get_drvdata(&inputdev->dev);
 
-	return sprintf(buf, "%d\n", accel->g_select);
+	return sysfs_emit(buf, "%d\n", accel->g_select);
 }
 
 static ssize_t cmpc_accel_g_select_store_v4(struct device *dev,
@@ -550,7 +550,7 @@  static ssize_t cmpc_accel_sensitivity_show(struct device *dev,
 	inputdev = dev_get_drvdata(&acpi->dev);
 	accel = dev_get_drvdata(&inputdev->dev);
 
-	return sprintf(buf, "%d\n", accel->sensitivity);
+	return sysfs_emit(buf, "%d\n", accel->sensitivity);
 }
 
 static ssize_t cmpc_accel_sensitivity_store(struct device *dev,