| Message ID | 20241031040952.109057-18-mario.limonciello@amd.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add support for binding ACPI platform profile to multiple drivers | expand |
On Thu, Oct 31, 2024, at 12:09 AM, Mario Limonciello wrote: > When two profile handlers don't agree on the current profile it's ambiguous > what to show to the legacy sysfs interface. > > Add a "custom" profile string that userspace will be able to distinguish > this situation when using the legacy sysfs interface. > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/acpi/platform_profile.c | 1 + > include/linux/platform_profile.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c > index c2bb325ba531c..3128bd16615b6 100644 > --- a/drivers/acpi/platform_profile.c > +++ b/drivers/acpi/platform_profile.c > @@ -20,6 +20,7 @@ static const char * const profile_names[] = { > [PLATFORM_PROFILE_BALANCED] = "balanced", > [PLATFORM_PROFILE_BALANCED_PERFORMANCE] = "balanced-performance", > [PLATFORM_PROFILE_PERFORMANCE] = "performance", > + [PLATFORM_PROFILE_CUSTOM] = "custom", > }; > static_assert(ARRAY_SIZE(profile_names) == PLATFORM_PROFILE_LAST); > > diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h > index 6aad98f4abaf4..da009c8a402c9 100644 > --- a/include/linux/platform_profile.h > +++ b/include/linux/platform_profile.h > @@ -23,6 +23,7 @@ enum platform_profile_option { > PLATFORM_PROFILE_BALANCED, > PLATFORM_PROFILE_BALANCED_PERFORMANCE, > PLATFORM_PROFILE_PERFORMANCE, > + PLATFORM_PROFILE_CUSTOM, > PLATFORM_PROFILE_LAST, /*must always be last */ > }; > > -- > 2.43.0 Looks good to me. Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca> Mark
diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c index c2bb325ba531c..3128bd16615b6 100644 --- a/drivers/acpi/platform_profile.c +++ b/drivers/acpi/platform_profile.c @@ -20,6 +20,7 @@ static const char * const profile_names[] = { [PLATFORM_PROFILE_BALANCED] = "balanced", [PLATFORM_PROFILE_BALANCED_PERFORMANCE] = "balanced-performance", [PLATFORM_PROFILE_PERFORMANCE] = "performance", + [PLATFORM_PROFILE_CUSTOM] = "custom", }; static_assert(ARRAY_SIZE(profile_names) == PLATFORM_PROFILE_LAST); diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h index 6aad98f4abaf4..da009c8a402c9 100644 --- a/include/linux/platform_profile.h +++ b/include/linux/platform_profile.h @@ -23,6 +23,7 @@ enum platform_profile_option { PLATFORM_PROFILE_BALANCED, PLATFORM_PROFILE_BALANCED_PERFORMANCE, PLATFORM_PROFILE_PERFORMANCE, + PLATFORM_PROFILE_CUSTOM, PLATFORM_PROFILE_LAST, /*must always be last */ };
When two profile handlers don't agree on the current profile it's ambiguous what to show to the legacy sysfs interface. Add a "custom" profile string that userspace will be able to distinguish this situation when using the legacy sysfs interface. Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/acpi/platform_profile.c | 1 + include/linux/platform_profile.h | 1 + 2 files changed, 2 insertions(+)