| Message ID | 20241105120728.21646-1-yuancan@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | platform/x86/intel/ifs: Add missing destroy_work_on_stack() | expand |
On Tue, 5 Nov 2024, Yuan Can wrote: > This commit add missed destroy_work_on_stack() operations for > local_work.w in scan_chunks_sanity_check(). The commit 3279decb2c3c ("platform/x86/intel/ifs: Annotate work queue on stack so object debug does not complain") missed calling destroy_work_on_stack() for ...
On 11/5/2024 4:07 AM, Yuan Can wrote: > This commit add missed destroy_work_on_stack() operations for > local_work.w in scan_chunks_sanity_check(). > If you were seeing any specific warnings, might be helpful to mention that too in the commit > Fixes: 3279decb2c3c ("platform/x86/intel/ifs: Annotate work queue on stack so object debug does not complain") > Signed-off-by: Yuan Can <yuancan@huawei.com> > --- > drivers/platform/x86/intel/ifs/load.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86/intel/ifs/load.c > index de54bd1a5970..2faeb1ffbd92 100644 > --- a/drivers/platform/x86/intel/ifs/load.c > +++ b/drivers/platform/x86/intel/ifs/load.c > @@ -347,6 +347,7 @@ static int scan_chunks_sanity_check(struct device *dev) > INIT_WORK_ONSTACK(&local_work.w, copy_hashes_authenticate_chunks); > schedule_work_on(cpu, &local_work.w); > wait_for_completion(&ifs_done); > + destroy_work_on_stack(&local_work.w); > if (ifsd->loading_error) { > ret = -EIO; > goto out; The change looks good to me. (I see other users of INIT_WORK_ONSTACK having a corresponding destroy_xxx()) Reviewed-by: Jithu Joseph <jithu.joseph@intel.com> Thanks Jithu
diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86/intel/ifs/load.c index de54bd1a5970..2faeb1ffbd92 100644 --- a/drivers/platform/x86/intel/ifs/load.c +++ b/drivers/platform/x86/intel/ifs/load.c @@ -347,6 +347,7 @@ static int scan_chunks_sanity_check(struct device *dev) INIT_WORK_ONSTACK(&local_work.w, copy_hashes_authenticate_chunks); schedule_work_on(cpu, &local_work.w); wait_for_completion(&ifs_done); + destroy_work_on_stack(&local_work.w); if (ifsd->loading_error) { ret = -EIO; goto out;
This commit add missed destroy_work_on_stack() operations for local_work.w in scan_chunks_sanity_check(). Fixes: 3279decb2c3c ("platform/x86/intel/ifs: Annotate work queue on stack so object debug does not complain") Signed-off-by: Yuan Can <yuancan@huawei.com> --- drivers/platform/x86/intel/ifs/load.c | 1 + 1 file changed, 1 insertion(+)