From patchwork Thu Nov 7 20:59:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Stowell X-Patchwork-Id: 13867159 Received: from mail-0301.mail-europe.com (mail-0301.mail-europe.com [188.165.51.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3AE721894F for ; Thu, 7 Nov 2024 20:59:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.165.51.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731013196; cv=none; b=LTmaWInszTHPReip8nnfv/3vCB91kGwDutqGewqDoMzAc9swLgI1Vk4OhaEznPR/UBoo0eYRxJZaZ6wTCYEsCqK3Cr+kE7ORQtlsn8L4efnKuh5Mc69dSnBKg6V2xL3Vx9dbMzsf0Hn4Rr5Ed1ujQIdkha7FvVnaoJr6oAiF5Iw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731013196; c=relaxed/simple; bh=VoW+AYdBn5gDEVrzqejl/zPu6fJnlNOqEnSv20OCuAQ=; h=Date:To:From:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=htXQanjsefsGWUQ8PpR8zRAQB4oAY6L6kEYvnH4Vj5kl4xXK+HePW2wPcGzDr/i6TIo5K/cGNCI5x5oVv93z4kDt40DcBLxt7uwOg+zMWH5e3lRwtVkZJlW1WGJyfdm7/PB0eNKY6SImzQELthRTL6OLTNNNW6/0P5yEqAesHEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=stowell.pro; spf=pass smtp.mailfrom=stowell.pro; dkim=pass (2048-bit key) header.d=stowell.pro header.i=@stowell.pro header.b=W7RzPxiv; arc=none smtp.client-ip=188.165.51.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=stowell.pro Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=stowell.pro Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=stowell.pro header.i=@stowell.pro header.b="W7RzPxiv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stowell.pro; s=protonmail2; t=1731013179; x=1731272379; bh=2KKVWwxWrzZiJudXl2IJdjfWIC9VUE6VdAF45niX7AM=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=W7RzPxiv7EtzhX1UMj/Qg9pERHAxVGzL0LF6Wukm0V7OxtcS0kt0RvoiGwYhEkge7 3H6DbfIOZLuqrDErGdkTbe67f3rRoNgXwLSjciFxRdnYHDFjcirFzotUxBMIJNae1g diM5nTvxJ1Xb4QLyrELIsh/2AN1Ka85Yye5DQNqujAZvyY8q2r4IMxdQDN0FVuRJW2 Ued6PaMPGAQy/Z0txjBJA1Lq18YZvxCinca5SOEBleYu8cILYZlVW/yVdicTKc4OrC B4eNEpZCOtVu3Apb61SrYHwIKg3s9ihMhbCfzrUs3A5zJHFfqp9DUyG+LlNOxsjRo6 /XQu3KmTg7ADw== Date: Thu, 07 Nov 2024 20:59:34 +0000 To: platform-driver-x86@vger.kernel.org From: Cole Stowell Cc: linux-kernel@vger.kernel.org, ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com, alexhung@gmail.com, Cole Stowell , Mary Strodl Subject: [PATCH] intel-hid: fix volume buttons on Thinkpad X12 Detachable Tablet Gen 1 Message-ID: <20241107205908.69279-1-cole@stowell.pro> Feedback-ID: 52027723:user:proton X-Pm-Message-ID: 69dba8408ba6a9b7f1ea045692cf3f00a9751864 Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Volume buttons on Lenovo Thinkpad X12 Detachable Tablet Gen 1 did not send any input events when pressed. When loading intel-hid with the 5 Button Array explicitly enabled, the buttons functioned normally. Adds the X12 Detachable Tablet Gen 1 to the `button_array_table`. However, the driver is unable to call INTEL_HID_DSM_BTNE_FN and prints the warning "failed to set button capability" when attempting to enable or disable the 5 Button Array. I'm not sure if this is normal, but the warning seems harmless. Co-developed-by: Mary Strodl Signed-off-by: Mary Strodl Signed-off-by: Cole Stowell Reviewed-by: Hans de Goede --- drivers/platform/x86/intel/hid.c | 7 +++++++ 1 file changed, 7 insertions(+) .matches = { diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c index 445e7a59beb4..48ad75a56199 100644 --- a/drivers/platform/x86/intel/hid.c +++ b/drivers/platform/x86/intel/hid.c @@ -118,6 +118,13 @@ static const s truct dmi_system_id button_array_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x2 Detachable"), }, }, + { + .ident = "Lenovo ThinkPad X1 Tablet Gen 1", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X12 Detachable Gen 1"), + }, + }, { .ident = "Lenovo ThinkPad X1 Tablet Gen 2",