| Message ID | 20241121130028.6259-1-liujing@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | tools/power/x86/intel-speed-select: Fix the wrong format specifier | expand |
On Thu, 2024-11-21 at 21:00 +0800, liujing wrote: > Because clos_config->clos_min and clos_config->clos_max > are unsigned int types, the output format should be %u. > > Signed-off-by: liujing <liujing@cmss.chinamobile.com> You need to have for your tag: Full Name <email address> Thanks, Srinivas > > diff --git a/tools/power/x86/intel-speed-select/isst-display.c > b/tools/power/x86/intel-speed-select/isst-display.c > index 07ebd08f3202..5ecf24bda6dd 100644 > --- a/tools/power/x86/intel-speed-select/isst-display.c > +++ b/tools/power/x86/intel-speed-select/isst-display.c > @@ -617,14 +617,14 @@ void isst_clos_display_information(struct > isst_id *id, FILE *outf, int clos, > format_and_print(outf, level + 2, header, value); > > snprintf(header, sizeof(header), "clos-min"); > - snprintf(value, sizeof(value), "%d MHz", clos_config- > >clos_min * isst_get_disp_freq_multiplier()); > + snprintf(value, sizeof(value), "%u MHz", clos_config- > >clos_min * isst_get_disp_freq_multiplier()); > format_and_print(outf, level + 2, header, value); > > snprintf(header, sizeof(header), "clos-max"); > if ((clos_config->clos_max * > isst_get_disp_freq_multiplier()) == 25500) > snprintf(value, sizeof(value), "Max Turbo > frequency"); > else > - snprintf(value, sizeof(value), "%d MHz", > clos_config->clos_max * isst_get_disp_freq_multiplier()); > + snprintf(value, sizeof(value), "%u MHz", > clos_config->clos_max * isst_get_disp_freq_multiplier()); > format_and_print(outf, level + 2, header, value); > > snprintf(header, sizeof(header), "clos-desired");
diff --git a/tools/power/x86/intel-speed-select/isst-display.c b/tools/power/x86/intel-speed-select/isst-display.c index 07ebd08f3202..5ecf24bda6dd 100644 --- a/tools/power/x86/intel-speed-select/isst-display.c +++ b/tools/power/x86/intel-speed-select/isst-display.c @@ -617,14 +617,14 @@ void isst_clos_display_information(struct isst_id *id, FILE *outf, int clos, format_and_print(outf, level + 2, header, value); snprintf(header, sizeof(header), "clos-min"); - snprintf(value, sizeof(value), "%d MHz", clos_config->clos_min * isst_get_disp_freq_multiplier()); + snprintf(value, sizeof(value), "%u MHz", clos_config->clos_min * isst_get_disp_freq_multiplier()); format_and_print(outf, level + 2, header, value); snprintf(header, sizeof(header), "clos-max"); if ((clos_config->clos_max * isst_get_disp_freq_multiplier()) == 25500) snprintf(value, sizeof(value), "Max Turbo frequency"); else - snprintf(value, sizeof(value), "%d MHz", clos_config->clos_max * isst_get_disp_freq_multiplier()); + snprintf(value, sizeof(value), "%u MHz", clos_config->clos_max * isst_get_disp_freq_multiplier()); format_and_print(outf, level + 2, header, value); snprintf(header, sizeof(header), "clos-desired");
Because clos_config->clos_min and clos_config->clos_max are unsigned int types, the output format should be %u. Signed-off-by: liujing <liujing@cmss.chinamobile.com>