| Message ID | 20241204204227.95757-3-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86: x86-android-tablets: Add Bluetooth support for Vexia EDU ATLA 10 | expand |
On Wed, Dec 04, 2024 at 09:42:13PM +0100, Hans de Goede wrote: > Commit 06f876def346 ("platform/x86: x86-android-tablets: Add support for > Vexia EDU ATLA 10 tablet") omitted the static keyword from some variables > which are only used inside other.c . > > Add the missing static keyword to these, this fixes the following warnings: > > drivers/platform/x86/x86-android-tablets/other.c:605:12: sparse: sparse: symbol 'crystal_cove_pwrsrc_psy' was not declared. Should it be static? > drivers/platform/x86/x86-android-tablets/other.c:612:28: sparse: sparse: symbol 'vexia_edu_atla10_ulpmc_node' was not declared. Should it be static? I believe you can shorten these lines like .../x86-android-tablets/<and so on> (Note '...' instead of PDx86 root path.) Reviewed-by: Andy Shevchenko <andy@kernel.org>
Hi, On 5-Dec-24 10:03 AM, Andy Shevchenko wrote: > On Wed, Dec 04, 2024 at 09:42:13PM +0100, Hans de Goede wrote: >> Commit 06f876def346 ("platform/x86: x86-android-tablets: Add support for >> Vexia EDU ATLA 10 tablet") omitted the static keyword from some variables >> which are only used inside other.c . >> >> Add the missing static keyword to these, this fixes the following warnings: >> >> drivers/platform/x86/x86-android-tablets/other.c:605:12: sparse: sparse: symbol 'crystal_cove_pwrsrc_psy' was not declared. Should it be static? >> drivers/platform/x86/x86-android-tablets/other.c:612:28: sparse: sparse: symbol 'vexia_edu_atla10_ulpmc_node' was not declared. Should it be static? > > I believe you can shorten these lines like > > .../x86-android-tablets/<and so on> > > (Note '...' instead of PDx86 root path.) Fine by me, note that the warning will still not fit on a single 75 char line then though. Ilpo do you want me to send a new version of the series for this? > Reviewed-by: Andy Shevchenko <andy@kernel.org> Thank you. Regards, Hans
diff --git a/drivers/platform/x86/x86-android-tablets/other.c b/drivers/platform/x86/x86-android-tablets/other.c index 725948044da4..de5b3f1ce9a7 100644 --- a/drivers/platform/x86/x86-android-tablets/other.c +++ b/drivers/platform/x86/x86-android-tablets/other.c @@ -602,14 +602,14 @@ const struct x86_dev_info whitelabel_tm800a550l_info __initconst = { * Vexia EDU ATLA 10 tablet, Android 4.2 / 4.4 + Guadalinex Ubuntu tablet * distributed to schools in the Spanish Andalucía region. */ -const char * const crystal_cove_pwrsrc_psy[] = { "crystal_cove_pwrsrc" }; +static const char * const crystal_cove_pwrsrc_psy[] = { "crystal_cove_pwrsrc" }; static const struct property_entry vexia_edu_atla10_ulpmc_props[] = { PROPERTY_ENTRY_STRING_ARRAY("supplied-from", crystal_cove_pwrsrc_psy), { } }; -const struct software_node vexia_edu_atla10_ulpmc_node = { +static const struct software_node vexia_edu_atla10_ulpmc_node = { .properties = vexia_edu_atla10_ulpmc_props, };
Commit 06f876def346 ("platform/x86: x86-android-tablets: Add support for Vexia EDU ATLA 10 tablet") omitted the static keyword from some variables which are only used inside other.c . Add the missing static keyword to these, this fixes the following warnings: drivers/platform/x86/x86-android-tablets/other.c:605:12: sparse: sparse: symbol 'crystal_cove_pwrsrc_psy' was not declared. Should it be static? drivers/platform/x86/x86-android-tablets/other.c:612:28: sparse: sparse: symbol 'vexia_edu_atla10_ulpmc_node' was not declared. Should it be static? Fixes: 06f876def346 ("platform/x86: x86-android-tablets: Add support for Vexia EDU ATLA 10 tablet") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202411301001.1glTy7Xm-lkp@intel.com/ Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/platform/x86/x86-android-tablets/other.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)