| Message ID | 20241216083409.1885677-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86/intel: bytcrc_pwrsrc: fix power_supply dependency | expand |
On Mon, Dec 16, 2024 at 09:34:05AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The driver now fails to link when the power supply core is missing > or in a loadable module: > > _64-linux/bin/x86_64-linux-ld: drivers/platform/x86/intel/bytcrc_pwrsrc.o: in function `crc_pwrsrc_irq_handler': > bytcrc_pwrsrc.c:(.text+0x2aa): undefined reference to `power_supply_changed' > x86_64-linux-ld: drivers/platform/x86/intel/bytcrc_pwrsrc.o: in function `crc_pwrsrc_psy_get_property': > bytcrc_pwrsrc.c:(.text+0x2f6): undefined reference to `power_supply_get_drvdata' > x86_64-linux-ld: drivers/platform/x86/intel/bytcrc_pwrsrc.o: in function `crc_pwrsrc_probe': > bytcrc_pwrsrc.c:(.text+0x644): undefined reference to `devm_power_supply_register' > > Add the appropriate dependency for it. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
On Mon, 16 Dec 2024 09:34:05 +0100, Arnd Bergmann wrote: > The driver now fails to link when the power supply core is missing > or in a loadable module: > > _64-linux/bin/x86_64-linux-ld: drivers/platform/x86/intel/bytcrc_pwrsrc.o: in function `crc_pwrsrc_irq_handler': > bytcrc_pwrsrc.c:(.text+0x2aa): undefined reference to `power_supply_changed' > x86_64-linux-ld: drivers/platform/x86/intel/bytcrc_pwrsrc.o: in function `crc_pwrsrc_psy_get_property': > bytcrc_pwrsrc.c:(.text+0x2f6): undefined reference to `power_supply_get_drvdata' > x86_64-linux-ld: drivers/platform/x86/intel/bytcrc_pwrsrc.o: in function `crc_pwrsrc_probe': > bytcrc_pwrsrc.c:(.text+0x644): undefined reference to `devm_power_supply_register' > > [...] Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/1] platform/x86/intel: bytcrc_pwrsrc: fix power_supply dependency commit: 6bcb50954580caa48fceeeb4b4af0fef746a89d6 -- i.
diff --git a/drivers/platform/x86/intel/Kconfig b/drivers/platform/x86/intel/Kconfig index eb698dcb9af9..19a2246f2770 100644 --- a/drivers/platform/x86/intel/Kconfig +++ b/drivers/platform/x86/intel/Kconfig @@ -83,6 +83,7 @@ config INTEL_BXTWC_PMIC_TMU config INTEL_BYTCRC_PWRSRC tristate "Intel Bay Trail Crystal Cove power source driver" depends on INTEL_SOC_PMIC + depends on POWER_SUPPLY help This option adds a power source driver for Crystal Cove PMICs on Intel Bay Trail devices.