| Message ID | 20250129033932.2576077-1-raj.khem@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | tools/power/x86/intel-speed-select: Prefix header search path with sysroot | expand |
On Tue, 2025-01-28 at 19:39 -0800, Khem Raj wrote: > This helps when using a cross-compiler for building intel-speed- > select, > currently, its hardcoded to pick libnl3 headers from build host which > may > not be same as build target when cross compiling. > > cc -print-sysroot will print nothing if compiler is configured > without > a sysroot and result in same string as it is now. > > Fixes errors with gcc configured with host include poisoning e.g. > > cc1: error: include location "/usr/include/libnl3" is unsafe for > cross-compilation [-Werror=poison-system-directories] > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: Len Brown <len.brown@intel.com> Thanks. will take for the next release. -Srinivas > --- > tools/power/x86/intel-speed-select/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/power/x86/intel-speed-select/Makefile > b/tools/power/x86/intel-speed-select/Makefile > index 7221f2f55e8b..8d3a02a20f3d 100644 > --- a/tools/power/x86/intel-speed-select/Makefile > +++ b/tools/power/x86/intel-speed-select/Makefile > @@ -13,7 +13,7 @@ endif > # Do not use make's built-in rules > # (this improves performance and avoids hard-to-debug behaviour); > MAKEFLAGS += -r > -override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include - > I/usr/include/libnl3 > +override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include - > I$(shell $(CC) -print-sysroot)/usr/include/libnl3 > override LDFLAGS += -lnl-genl-3 -lnl-3 > > ALL_TARGETS := intel-speed-select
diff --git a/tools/power/x86/intel-speed-select/Makefile b/tools/power/x86/intel-speed-select/Makefile index 7221f2f55e8b..8d3a02a20f3d 100644 --- a/tools/power/x86/intel-speed-select/Makefile +++ b/tools/power/x86/intel-speed-select/Makefile @@ -13,7 +13,7 @@ endif # Do not use make's built-in rules # (this improves performance and avoids hard-to-debug behaviour); MAKEFLAGS += -r -override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include -I/usr/include/libnl3 +override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include -I$(shell $(CC) -print-sysroot)/usr/include/libnl3 override LDFLAGS += -lnl-genl-3 -lnl-3 ALL_TARGETS := intel-speed-select
This helps when using a cross-compiler for building intel-speed-select, currently, its hardcoded to pick libnl3 headers from build host which may not be same as build target when cross compiling. cc -print-sysroot will print nothing if compiler is configured without a sysroot and result in same string as it is now. Fixes errors with gcc configured with host include poisoning e.g. cc1: error: include location "/usr/include/libnl3" is unsafe for cross-compilation [-Werror=poison-system-directories] Signed-off-by: Khem Raj <raj.khem@gmail.com> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: Len Brown <len.brown@intel.com> --- tools/power/x86/intel-speed-select/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)