diff mbox series

platform/x86: intel-hid: fix volume buttons on Microsoft Surface Go 4 tablet

Message ID 20250220154016.3620917-1-dmitry@d-systems.ee (mailing list archive)
State New
Headers show
Series platform/x86: intel-hid: fix volume buttons on Microsoft Surface Go 4 tablet | expand

Commit Message

Dmitry Panchenko | d-Systems Feb. 20, 2025, 3:39 p.m. UTC
From: Dmitry Panchenko <dmitry@d-systems.ee>

Volume buttons on Microsoft Surface Go 4 tablet didn't send any events.
Add Surface Go 4 DMI match to button_array_table to fix this.

Signed-off-by: Dmitry Panchenko <dmitry@d-systems.ee>
---
 drivers/platform/x86/intel/hid.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Hans de Goede Feb. 20, 2025, 4 p.m. UTC | #1
Hi,

On 20-Feb-25 4:39 PM, Dmitry Panchenko | d-Systems wrote:
> From: Dmitry Panchenko <dmitry@d-systems.ee>
> 
> Volume buttons on Microsoft Surface Go 4 tablet didn't send any events.
> Add Surface Go 4 DMI match to button_array_table to fix this.
> 
> Signed-off-by: Dmitry Panchenko <dmitry@d-systems.ee>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>  drivers/platform/x86/intel/hid.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
> index 927a2993f616..88a1a9ff2f34 100644
> --- a/drivers/platform/x86/intel/hid.c
> +++ b/drivers/platform/x86/intel/hid.c
> @@ -139,6 +139,13 @@ static const struct dmi_system_id button_array_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go 3"),
>  		},
>  	},
> +	{
> +		.ident = "Microsoft Surface Go 4",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go 4"),
> +		},
> +	},
>  	{ }
>  };
>
diff mbox series

Patch

diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
index 927a2993f616..88a1a9ff2f34 100644
--- a/drivers/platform/x86/intel/hid.c
+++ b/drivers/platform/x86/intel/hid.c
@@ -139,6 +139,13 @@  static const struct dmi_system_id button_array_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go 3"),
 		},
 	},
+	{
+		.ident = "Microsoft Surface Go 4",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go 4"),
+		},
+	},
 	{ }
 };