| Message ID | 20250304160639.4295-2-ilpo.jarvinen@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [1/2] platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: Make symbol static | expand |
On 3/4/2025 10:06, Ilpo Järvinen wrote: > Sparse reports: > > dell-uart-backlight.c:328:29: warning: symbol > 'dell_uart_bl_serdev_driver' was not declared. Should it be static? > > Fix it by making the symbol static. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Fixes: 484bae9e4d6ac ("platform/x86: Add new Dell UART backlight driver") Reviewed-by: Mario Limonciello <maroi.limonciello@amd.com> > --- > drivers/platform/x86/dell/dell-uart-backlight.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/dell/dell-uart-backlight.c b/drivers/platform/x86/dell/dell-uart-backlight.c > index 50002ef13d5d..8f868f845350 100644 > --- a/drivers/platform/x86/dell/dell-uart-backlight.c > +++ b/drivers/platform/x86/dell/dell-uart-backlight.c > @@ -325,7 +325,7 @@ static int dell_uart_bl_serdev_probe(struct serdev_device *serdev) > return PTR_ERR_OR_ZERO(dell_bl->bl); > } > > -struct serdev_device_driver dell_uart_bl_serdev_driver = { > +static struct serdev_device_driver dell_uart_bl_serdev_driver = { > .probe = dell_uart_bl_serdev_probe, > .driver = { > .name = KBUILD_MODNAME,
Hi Ilpo, On 4-Mar-25 5:06 PM, Ilpo Järvinen wrote: > Sparse reports: > > dell-uart-backlight.c:328:29: warning: symbol > 'dell_uart_bl_serdev_driver' was not declared. Should it be static? > > Fix it by making the symbol static. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/platform/x86/dell/dell-uart-backlight.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/dell/dell-uart-backlight.c b/drivers/platform/x86/dell/dell-uart-backlight.c > index 50002ef13d5d..8f868f845350 100644 > --- a/drivers/platform/x86/dell/dell-uart-backlight.c > +++ b/drivers/platform/x86/dell/dell-uart-backlight.c > @@ -325,7 +325,7 @@ static int dell_uart_bl_serdev_probe(struct serdev_device *serdev) > return PTR_ERR_OR_ZERO(dell_bl->bl); > } > > -struct serdev_device_driver dell_uart_bl_serdev_driver = { > +static struct serdev_device_driver dell_uart_bl_serdev_driver = { > .probe = dell_uart_bl_serdev_probe, > .driver = { > .name = KBUILD_MODNAME,
diff --git a/drivers/platform/x86/dell/dell-uart-backlight.c b/drivers/platform/x86/dell/dell-uart-backlight.c index 50002ef13d5d..8f868f845350 100644 --- a/drivers/platform/x86/dell/dell-uart-backlight.c +++ b/drivers/platform/x86/dell/dell-uart-backlight.c @@ -325,7 +325,7 @@ static int dell_uart_bl_serdev_probe(struct serdev_device *serdev) return PTR_ERR_OR_ZERO(dell_bl->bl); } -struct serdev_device_driver dell_uart_bl_serdev_driver = { +static struct serdev_device_driver dell_uart_bl_serdev_driver = { .probe = dell_uart_bl_serdev_probe, .driver = { .name = KBUILD_MODNAME,
Sparse reports: dell-uart-backlight.c:328:29: warning: symbol 'dell_uart_bl_serdev_driver' was not declared. Should it be static? Fix it by making the symbol static. Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- drivers/platform/x86/dell/dell-uart-backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)