@@ -275,9 +275,9 @@ static const struct dmi_system_id dmi_table[] = {
/* Helper functions to handle EC read/write */
static int read_from_ec(u8 reg, int size, long *val)
{
- int i;
- int ret;
u8 buffer;
+ int ret;
+ int i;
if (!lock_global_acpi_lock())
return -EBUSY;
@@ -389,8 +389,8 @@ static ssize_t tt_toggle_store(struct device *dev,
struct device_attribute *attr, const char *buf,
size_t count)
{
- int rval;
bool value;
+ int rval;
rval = kstrtobool(buf, &value);
if (rval)
@@ -411,8 +411,8 @@ static ssize_t tt_toggle_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
int retval;
- u8 reg;
long val;
+ u8 reg;
switch (board) {
case oxp_mini_amd_a07:
Since the rest of the driver follows this convention, apply it to the tt_toggle attribute as well. Suggested-by: Derek J. Clark <derekjohn.clark@gmail.com> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> --- drivers/platform/x86/oxpec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)