| Message ID | 20250322102804.418000-7-lkml@antheas.dev (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | HID: asus: Add RGB Support to Asus Z13, Ally, unify backlight asus-wmi, and Z13 QOL | expand |
On 22/03/25 23:28, Antheas Kapenekakis wrote: > The quirk for selecting whether keyboard backlight should be controlled > by HID or WMI is not needed anymore, so remove it. > > Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> > --- > include/linux/platform_data/x86/asus-wmi.h | 40 ---------------------- > 1 file changed, 40 deletions(-) > > diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h > index ec8b0c585a63f..c513b5a732323 100644 > --- a/include/linux/platform_data/x86/asus-wmi.h > +++ b/include/linux/platform_data/x86/asus-wmi.h > @@ -183,44 +183,4 @@ static inline void asus_hid_unregister_listener(struct asus_hid_listener *bdev) > } > #endif > > -/* To be used by both hid-asus and asus-wmi to determine which controls kbd_brightness */ > -static const struct dmi_system_id asus_use_hid_led_dmi_ids[] = { > - { > - .matches = { > - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Zephyrus"), > - }, > - }, > - { > - .matches = { > - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Strix"), > - }, > - }, > - { > - .matches = { > - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Flow"), > - }, > - }, > - { > - .matches = { > - DMI_MATCH(DMI_PRODUCT_FAMILY, "ProArt P16"), > - }, > - }, > - { > - .matches = { > - DMI_MATCH(DMI_BOARD_NAME, "GA403U"), > - }, > - }, > - { > - .matches = { > - DMI_MATCH(DMI_BOARD_NAME, "GU605M"), > - }, > - }, > - { > - .matches = { > - DMI_MATCH(DMI_BOARD_NAME, "RC71L"), > - }, > - }, > - { }, > -}; > - > #endif /* __PLATFORM_DATA_X86_ASUS_WMI_H */ I might have mentioned it already but I think you should squash this commit into where asus_use_hid_led_dmi_ids use is removed. It's something I've been asked to do on a few occasions to prevent possible error/warning on patch tests (unused). Otherwise if it stays separate: Reviewed-by: Luke D. Jones <luke@ljones.dev>
diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h index ec8b0c585a63f..c513b5a732323 100644 --- a/include/linux/platform_data/x86/asus-wmi.h +++ b/include/linux/platform_data/x86/asus-wmi.h @@ -183,44 +183,4 @@ static inline void asus_hid_unregister_listener(struct asus_hid_listener *bdev) } #endif -/* To be used by both hid-asus and asus-wmi to determine which controls kbd_brightness */ -static const struct dmi_system_id asus_use_hid_led_dmi_ids[] = { - { - .matches = { - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Zephyrus"), - }, - }, - { - .matches = { - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Strix"), - }, - }, - { - .matches = { - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Flow"), - }, - }, - { - .matches = { - DMI_MATCH(DMI_PRODUCT_FAMILY, "ProArt P16"), - }, - }, - { - .matches = { - DMI_MATCH(DMI_BOARD_NAME, "GA403U"), - }, - }, - { - .matches = { - DMI_MATCH(DMI_BOARD_NAME, "GU605M"), - }, - }, - { - .matches = { - DMI_MATCH(DMI_BOARD_NAME, "RC71L"), - }, - }, - { }, -}; - #endif /* __PLATFORM_DATA_X86_ASUS_WMI_H */
The quirk for selecting whether keyboard backlight should be controlled by HID or WMI is not needed anymore, so remove it. Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> --- include/linux/platform_data/x86/asus-wmi.h | 40 ---------------------- 1 file changed, 40 deletions(-)