| Message ID | 20430731173417.2692-1-xingtong_wu@163.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | None | expand |
On Sat, 1 Aug 2043, xingtong_wu@163.com wrote: > From: "xingtong.wu" <xingtong.wu@siemens.com> > > The variable "priv.devmode" is missing from if statement that leads > to a logical error. Add the missing variable to the if condition. > > Fixes: c56beff20375 ("platform/x86/siemens: simatic-ipc-batt: add support for module BX-59A") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202308010001.BGYCSQrl-lkp@intel.com/ > > Signed-off-by: xingtong.wu <xingtong.wu@siemens.com> The tags block should not have extra newlines like there's now one in between Closes and Signed-off-by. For patches 1-2: Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> (In case you end up submitting a new version, you should collect the tags other people have given you, except e.g., if you did major modifications to the patch.)
On Sat, Aug 01, 2043 at 01:34:17AM +0800, xingtong_wu@163.com wrote: ^^^^^^^^^^^^^^^^^^^^ Nice way to keep your mail on top of the sort :-).. You need to fixup your system date. > From: "xingtong.wu" <xingtong.wu@siemens.com> > > The variable "priv.devmode" is missing from if statement that leads > to a logical error. Add the missing variable to the if condition. > > Fixes: c56beff20375 ("platform/x86/siemens: simatic-ipc-batt: add support for module BX-59A") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202308010001.BGYCSQrl-lkp@intel.com/ > > Signed-off-by: xingtong.wu <xingtong.wu@siemens.com> > --- > drivers/platform/x86/siemens/simatic-ipc-batt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/siemens/simatic-ipc-batt.c b/drivers/platform/x86/siemens/simatic-ipc-batt.c > index d66b9969234b..e6c12c52843c 100644 > --- a/drivers/platform/x86/siemens/simatic-ipc-batt.c > +++ b/drivers/platform/x86/siemens/simatic-ipc-batt.c > @@ -194,7 +194,8 @@ int simatic_ipc_batt_probe(struct platform_device *pdev, struct gpiod_lookup_tab > > if (table->table[2].key) { > flags = GPIOD_OUT_HIGH; > - if (priv.devmode == SIMATIC_IPC_DEVICE_BX_21A || SIMATIC_IPC_DEVICE_BX_59A) > + if (priv.devmode == SIMATIC_IPC_DEVICE_BX_21A || > + priv.devmode == SIMATIC_IPC_DEVICE_BX_59A) > flags = GPIOD_OUT_LOW; > priv.gpios[2] = devm_gpiod_get_index(dev, "CMOSBattery meter", 2, flags); > if (IS_ERR(priv.gpios[2])) { > -- > 2.25.1 >
On 2023/8/16 23:45, Ashok Raj wrote: > On Sat, Aug 01, 2043 at 01:34:17AM +0800, xingtong_wu@163.com wrote: > ^^^^^^^^^^^^^^^^^^^^ > > Nice way to keep your mail on top of the sort :-).. You need to fixup your > system date. I'm sorry that there are time problem on my local machine which lead to a wrong time in email, but I just sent an email to remind hdegoede@redhat.com individually, the time problem was solved by him on his branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=review-hans&id=b01c1e022f7f0c327ecc7544dc44d5f80a2d2bd9 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=review-hans&id=7abf253afa5c72c0c7eb21f67da1d443f036737a > >> From: "xingtong.wu" <xingtong.wu@siemens.com> >> >> The variable "priv.devmode" is missing from if statement that leads >> to a logical error. Add the missing variable to the if condition. >> >> Fixes: c56beff20375 ("platform/x86/siemens: simatic-ipc-batt: add support for module BX-59A") >> Reported-by: kernel test robot <lkp@intel.com> >> Closes: https://lore.kernel.org/oe-kbuild-all/202308010001.BGYCSQrl-lkp@intel.com/ >> >> Signed-off-by: xingtong.wu <xingtong.wu@siemens.com> >> --- >> drivers/platform/x86/siemens/simatic-ipc-batt.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/siemens/simatic-ipc-batt.c b/drivers/platform/x86/siemens/simatic-ipc-batt.c >> index d66b9969234b..e6c12c52843c 100644 >> --- a/drivers/platform/x86/siemens/simatic-ipc-batt.c >> +++ b/drivers/platform/x86/siemens/simatic-ipc-batt.c >> @@ -194,7 +194,8 @@ int simatic_ipc_batt_probe(struct platform_device *pdev, struct gpiod_lookup_tab >> >> if (table->table[2].key) { >> flags = GPIOD_OUT_HIGH; >> - if (priv.devmode == SIMATIC_IPC_DEVICE_BX_21A || SIMATIC_IPC_DEVICE_BX_59A) >> + if (priv.devmode == SIMATIC_IPC_DEVICE_BX_21A || >> + priv.devmode == SIMATIC_IPC_DEVICE_BX_59A) >> flags = GPIOD_OUT_LOW; >> priv.gpios[2] = devm_gpiod_get_index(dev, "CMOSBattery meter", 2, flags); >> if (IS_ERR(priv.gpios[2])) { >> -- >> 2.25.1 >>
diff --git a/drivers/platform/x86/siemens/simatic-ipc-batt.c b/drivers/platform/x86/siemens/simatic-ipc-batt.c index d66b9969234b..e6c12c52843c 100644 --- a/drivers/platform/x86/siemens/simatic-ipc-batt.c +++ b/drivers/platform/x86/siemens/simatic-ipc-batt.c @@ -194,7 +194,8 @@ int simatic_ipc_batt_probe(struct platform_device *pdev, struct gpiod_lookup_tab if (table->table[2].key) { flags = GPIOD_OUT_HIGH; - if (priv.devmode == SIMATIC_IPC_DEVICE_BX_21A || SIMATIC_IPC_DEVICE_BX_59A) + if (priv.devmode == SIMATIC_IPC_DEVICE_BX_21A || + priv.devmode == SIMATIC_IPC_DEVICE_BX_59A) flags = GPIOD_OUT_LOW; priv.gpios[2] = devm_gpiod_get_index(dev, "CMOSBattery meter", 2, flags); if (IS_ERR(priv.gpios[2])) {