| Message ID | 33d40e976f08f82b9227d0ecae38c787fcc0c0b2.1712154684.git.soyer@irl.hu (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86: lg-laptop: fix %s null argument warning | expand |
On 4/3/24 7:34 AM, Gergo Koteles wrote: > W=1 warns about null argument to kprintf: > warning: ‘%s’ directive argument is null [-Wformat-overflow=] > pr_info("product: %s year: %d\n", product, year); > > Use "unknown" instead of NULL. > > Signed-off-by: Gergo Koteles <soyer@irl.hu> > --- Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > drivers/platform/x86/lg-laptop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c > index ad3c39e9e9f5..e714ee6298dd 100644 > --- a/drivers/platform/x86/lg-laptop.c > +++ b/drivers/platform/x86/lg-laptop.c > @@ -736,7 +736,7 @@ static int acpi_add(struct acpi_device *device) > default: > year = 2019; > } > - pr_info("product: %s year: %d\n", product, year); > + pr_info("product: %s year: %d\n", product ?: "unknown", year); > > if (year >= 2019) > battery_limit_use_wmbb = 1; > > base-commit: 39cd87c4eb2b893354f3b850f916353f2658ae6f
On Wed, 03 Apr 2024 16:34:27 +0200, Gergo Koteles wrote: > W=1 warns about null argument to kprintf: > warning: ‘%s’ directive argument is null [-Wformat-overflow=] > pr_info("product: %s year: %d\n", product, year); > > Use "unknown" instead of NULL. > > > [...] Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/1] platform/x86: lg-laptop: fix %s null argument warning commit: e71c8481692582c70cdfd0996c20cdcc71e425d3 -- i.
diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c index ad3c39e9e9f5..e714ee6298dd 100644 --- a/drivers/platform/x86/lg-laptop.c +++ b/drivers/platform/x86/lg-laptop.c @@ -736,7 +736,7 @@ static int acpi_add(struct acpi_device *device) default: year = 2019; } - pr_info("product: %s year: %d\n", product, year); + pr_info("product: %s year: %d\n", product ?: "unknown", year); if (year >= 2019) battery_limit_use_wmbb = 1;
W=1 warns about null argument to kprintf: warning: ‘%s’ directive argument is null [-Wformat-overflow=] pr_info("product: %s year: %d\n", product, year); Use "unknown" instead of NULL. Signed-off-by: Gergo Koteles <soyer@irl.hu> --- drivers/platform/x86/lg-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 39cd87c4eb2b893354f3b850f916353f2658ae6f