From patchwork Fri Feb 23 19:19:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Limonciello, Mario" X-Patchwork-Id: 10239209 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 862AA60225 for ; Fri, 23 Feb 2018 19:19:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76C0929645 for ; Fri, 23 Feb 2018 19:19:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6B318298B2; Fri, 23 Feb 2018 19:19:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E9F4929645 for ; Fri, 23 Feb 2018 19:19:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754544AbeBWTTe (ORCPT ); Fri, 23 Feb 2018 14:19:34 -0500 Received: from esa7.dell-outbound.iphmx.com ([68.232.153.96]:28114 "EHLO esa7.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754057AbeBWTTc (ORCPT ); Fri, 23 Feb 2018 14:19:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dell.com; i=@dell.com; q=dns/txt; s=smtpout; t=1519413480; x=1550949480; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=HeZLrN82+sYHNoK0xDLF7OoUl1S4RyGPuhKTXW9Nt4Q=; b=t7n5h7VZcVIHMJwZ7KAwljcK500oWEPAxPOPMIDMDim3qakW0bCibgjn FkAOxGX8XNpZhzFk0s25ULW5AFXoJQPHY15ie4UaVoaR3DfSDuSwLvd4Z 9ce+24m+es71mGHRL3WOVQaaZ6mjvkfiDzdyp2IxhWwKdCchS3OC23bq+ 8=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2GmAQCsaJBamMuZ6ERdGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYQlgQAoCpt+ggKBFogBjlAUggIKhTMCgjhVFwECAQEBAQEBAgE?= =?us-ascii?q?CEAEBAQEBCAsLBigvgjgigkoBAQEEOjQLDAQCAQgRBAEBAR4JByElCQgCBAENB?= =?us-ascii?q?QiKAwMVrhuHOQ2BMoIeAQEBAQEFAQEBAQEBASGFGIInhmqCaoIEARIBJoV1BYs?= =?us-ascii?q?PmH41CZEFhQKCKIYpi31Ijg2JVoE8IQKBFnFwT4JDgmSCEniKXIElgRkBAQE?= X-IPAS-Result: =?us-ascii?q?A2GmAQCsaJBamMuZ6ERdGQEBAQEBAQEBAQEBAQcBAQEBAYQ?= =?us-ascii?q?lgQAoCpt+ggKBFogBjlAUggIKhTMCgjhVFwECAQEBAQEBAgECEAEBAQEBCAsLB?= =?us-ascii?q?igvgjgigkoBAQEEOjQLDAQCAQgRBAEBAR4JByElCQgCBAENBQiKAwMVrhuHOQ2?= =?us-ascii?q?BMoIeAQEBAQEFAQEBAQEBASGFGIInhmqCaoIEARIBJoV1BYsPmH41CZEFhQKCK?= =?us-ascii?q?IYpi31Ijg2JVoE8IQKBFnFwT4JDgmSCEniKXIElgRkBAQE?= Received: from esa5.dell-outbound2.iphmx.com ([68.232.153.203]) by esa7.dell-outbound.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Feb 2018 13:18:00 -0600 From: Received: from ausxipps301.us.dell.com ([143.166.148.223]) by esa5.dell-outbound2.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2018 01:16:56 +0600 X-LoopCount0: from 10.166.132.187 X-IronPort-AV: E=Sophos;i="5.47,383,1515477600"; d="scan'208";a="138124626" X-DLP: DLP_GlobalPCIDSS To: , , CC: , Subject: RE: dell_smbios in 4.15 and keyboard backlight Thread-Topic: dell_smbios in 4.15 and keyboard backlight Thread-Index: AQHTrNm5slXmoTDsqkGomqt/s3ipcKOyWfoQ Date: Fri, 23 Feb 2018 19:19:30 +0000 Message-ID: <37740d49c7404fae824ff075fb87fbe9@ausx13mpc120.AMER.DELL.COM> References: <20180223133330.GA12066@bongo.bofh.it> <20180223190615.GA23961@bongo.bofh.it> In-Reply-To: <20180223190615.GA23961@bongo.bofh.it> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP > -----Original Message----- > From: Marco d'Itri [mailto:md@linux.it] > Sent: Friday, February 23, 2018 1:06 PM > To: Limonciello, Mario > Cc: pali.rohar@gmail.com > Subject: Re: dell_smbios in 4.15 and keyboard backlight > > On Feb 23, Mario Limonciello wrote: > > > Can you please email me on mario.limonciello@dell.com for this topic? > > > > I would be interested to know do you have dell-smbios-smm or > > dell-smbios-wmi not loading or compiling? > Oops... The new modules have not been enabled yet by the Debian kernel > team, so this explains why I could not find them. > Thank you for your help, I will get back to you if I will still have > troubles with the new kernel. > If you don't mind I'm going to CC this to the mailing list for discussion. I think you identified a valid config problem. Andy, Darren, Marco (CC'ed) privately emailed Pali and I to discuss an issue that dell-laptop wasn't working properly for him and dell-smbios couldn't find a backend. I thought at first it was an issue of the race condition recently discussed but it's actually a case that the distro kernel he's using compiled: DELL_SMBIOS DELL_LAPTOP But didn't select DELL_SMBIOS_WMI or DELL_SMBIOS_SMM. I remember hypothesizing about this with one of the earlier versions of the patch series but the decision was to just hide config DELL_SMBIOS as an invisible tristate. Because this is a real problem happening I think we need something like this: Thoughts? diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 9a8f964..f2f548b 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -107,6 +107,7 @@ config ASUS_LAPTOP config DELL_SMBIOS tristate + depends on DELL_SMBIOS_WMI || DELL_SMBIOS_SMM config DELL_SMBIOS_WMI tristate "Dell SMBIOS calling interface (WMI implementation)"