diff mbox

[2/2] ABI: ibm_rtl: the "What:" fields are incomplete

Message ID 650a057df924aff3b70a445694fcb1e3af524c8d.1477735797.git.mchehab@s-opensource.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Mauro Carvalho Chehab Oct. 29, 2016, 10:10 a.m. UTC 
The "What:" field at the ABI should describe the location of
the ABI, e. g. the position under a mounted sysfs. However,
this file has only the basename without the path.

Fix it.

Cc: Vernon Mauery <vernux@us.ibm.com>
Cc: Darren Hart <dvhart@infradead.org>
Cc: platform-driver-x86@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
 Documentation/ABI/testing/sysfs-devices-system-ibm-rtl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Darren Hart Nov. 1, 2016, 4:15 p.m. UTC | #1 
On Sat, Oct 29, 2016 at 08:10:03AM -0200, Mauro Carvalho Chehab wrote:
> The "What:" field at the ABI should describe the location of
> the ABI, e. g. the position under a mounted sysfs. However,
> this file has only the basename without the path.
> 
> Fix it.
> 
> Cc: Vernon Mauery <vernux@us.ibm.com>
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: platform-driver-x86@vger.kernel.org
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

Thanks, applied.
Darren Hart Nov. 1, 2016, 4:21 p.m. UTC | #2 
On Sat, Oct 29, 2016 at 08:10:03AM -0200, Mauro Carvalho Chehab wrote:
> The "What:" field at the ABI should describe the location of
> the ABI, e. g. the position under a mounted sysfs. However,
> this file has only the basename without the path.
> 
> Fix it.
> 
> Cc: Vernon Mauery <vernux@us.ibm.com>
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: platform-driver-x86@vger.kernel.org
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

Jon,

Is it OK with you if I push this through my platform driver x86 tree?

Thanks,

Darren

> ---
>  Documentation/ABI/testing/sysfs-devices-system-ibm-rtl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-devices-system-ibm-rtl b/Documentation/ABI/testing/sysfs-devices-system-ibm-rtl
> index b82deeaec314..470def06ab0a 100644
> --- a/Documentation/ABI/testing/sysfs-devices-system-ibm-rtl
> +++ b/Documentation/ABI/testing/sysfs-devices-system-ibm-rtl
> @@ -1,4 +1,4 @@
> -What:           state
> +What:           /sys/devices/system/ibm_rtl/state
>  Date:           Sep 2010
>  KernelVersion:  2.6.37
>  Contact:        Vernon Mauery <vernux@us.ibm.com>
> @@ -10,7 +10,7 @@ Description:    The state file allows a means by which to change in and
>  Users:          The ibm-prtm userspace daemon uses this interface.
>  
>  
> -What:           version
> +What:           /sys/devices/system/ibm_rtl/version
>  Date:           Sep 2010
>  KernelVersion:  2.6.37
>  Contact:        Vernon Mauery <vernux@us.ibm.com>
> -- 
> 2.7.4
> 
>
diff mbox

Patch

diff --git a/Documentation/ABI/testing/sysfs-devices-system-ibm-rtl b/Documentation/ABI/testing/sysfs-devices-system-ibm-rtl
index b82deeaec314..470def06ab0a 100644
--- a/Documentation/ABI/testing/sysfs-devices-system-ibm-rtl
+++ b/Documentation/ABI/testing/sysfs-devices-system-ibm-rtl
@@ -1,4 +1,4 @@ 
-What:           state
+What:           /sys/devices/system/ibm_rtl/state
 Date:           Sep 2010
 KernelVersion:  2.6.37
 Contact:        Vernon Mauery <vernux@us.ibm.com>
@@ -10,7 +10,7 @@  Description:    The state file allows a means by which to change in and
 Users:          The ibm-prtm userspace daemon uses this interface.
 
 
-What:           version
+What:           /sys/devices/system/ibm_rtl/version
 Date:           Sep 2010
 KernelVersion:  2.6.37
 Contact:        Vernon Mauery <vernux@us.ibm.com>