From patchwork Mon Jan 15 05:11:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 10163057 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8A04B601C0 for ; Mon, 15 Jan 2018 05:11:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8140B287B2 for ; Mon, 15 Jan 2018 05:11:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 75B822881A; Mon, 15 Jan 2018 05:11:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 61F67287E9 for ; Mon, 15 Jan 2018 05:11:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753302AbeAOFL0 (ORCPT ); Mon, 15 Jan 2018 00:11:26 -0500 Received: from merlin.infradead.org ([205.233.59.134]:35668 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753258AbeAOFLW (ORCPT ); Mon, 15 Jan 2018 00:11:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Date:Message-ID:Cc:To:Subject:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tbFFnGcMiVD6qkSaQjFb1n7Tih/06jMmjOHUx1RvmVA=; b=I1ZK/mzJDBcYI8U1pmDdwJVSeC C+7RemGz+yRviv3fiY2hvIsFXQOyOetPBl36gexSjOfDYI9QhRrMmaj32PbfDMhFcG4fvg06Io85o 3nngheVAdH+qiHeJ/gSXS4tL4Yv9jpXCHkn6RpYAiYiyM3adZgWSJLYwl0adjZYCKl8211qUgNCgS hwBOSUpHQqH5aUokrhzFQ7tOYA/NvoYgXgGPQEgnOwlLeaKNJzPPnEziVY++04TNib9Kg7ZxnWf+E XnH5i3dDT7WkeozhSAizPz5hFCFi1NspoQp7E7eOGt53ubZLvPGk90MmAJhqN5ChlZLGTU4PSKFTQ NykgL5QA==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=dragon.site) by merlin.infradead.org with esmtpsa (Exim 4.89 #1 (Red Hat Linux)) id 1eax3H-0003px-PP; Mon, 15 Jan 2018 05:11:19 +0000 From: Randy Dunlap Subject: [PATCH] platform/x86: have ACPI_CMPC use depends instead of select for INPUT To: Platform Driver , LKML Cc: Darren Hart , Andy Shevchenko Message-ID: <913480bb-d06a-3f13-e8fc-20f83ff499a0@infradead.org> Date: Sun, 14 Jan 2018 21:11:18 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Language: en-US Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap Drivers should not 'select' a subsystem. Instead they should depend on it. If the subsystem is disabled, the user probably did that for a purpose and one driver shouldn't be changing that. This also makes all platform/x86/ drivers consistent w.r.t depending on INPUT instead of selecting it. Signed-off-by: Randy Dunlap Cc: Darren Hart Cc: Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org --- drivers/platform/x86/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- lnx-415-rc8.orig/drivers/platform/x86/Kconfig +++ lnx-415-rc8/drivers/platform/x86/Kconfig @@ -812,9 +812,8 @@ config TOSHIBA_WMI config ACPI_CMPC tristate "CMPC Laptop Extras" - depends on ACPI + depends on ACPI && INPUT depends on RFKILL || RFKILL=n - select INPUT select BACKLIGHT_CLASS_DEVICE help Support for Intel Classmate PC ACPI devices, including some