| Message ID | b6153ced6dc75c057429a69f2d8994d784f9768e.1506451187.git.mario.limonciello@dell.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Darren Hart |
| Headers | show |
On Tue, Sep 26, 2017 at 01:50:01PM -0500, Mario Limonciello wrote: > The descriptor GUID is not used to indicate that WMI notifications > in the dell-wmi driver work properly. As such a modalias should > not be present that causes this driver to load on systems with this > GUID. > > Reviewed-by: Pali Pohar <pali.rohar@gmail.com> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> I can do this manually, but for future reference: Nit, in general, the author's sign off should be first, followed by reviewers and testers. The maintainer will add their sign off at the end - this keeps things clear regarding the development and delivery path. In general, assume chronological order and you'll have the right idea. Informational tags, like Reported, Suggested, Tested, and Fixes can come before the Author sign off, which is consistent with the chronological order.
> -----Original Message----- > From: Darren Hart [mailto:dvhart@infradead.org] > Sent: Wednesday, September 27, 2017 1:22 PM > To: Limonciello, Mario <Mario_Limonciello@Dell.com> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com>; LKML <linux- > kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org; > quasisec@google.com; pali.rohar@gmail.com > Subject: Re: [PATCH v2 03/14] platform/x86: dell-wmi: Don't match on descriptor > GUID modalias > > On Tue, Sep 26, 2017 at 01:50:01PM -0500, Mario Limonciello wrote: > > The descriptor GUID is not used to indicate that WMI notifications > > in the dell-wmi driver work properly. As such a modalias should > > not be present that causes this driver to load on systems with this > > GUID. > > > > Reviewed-by: Pali Pohar <pali.rohar@gmail.com> > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > > I can do this manually, but for future reference: > > Nit, in general, the author's sign off should be first, followed by > reviewers and testers. The maintainer will add their sign off at the end > - this keeps things clear regarding the development and delivery path. > In general, assume chronological order and you'll have the right idea. > > Informational tags, like Reported, Suggested, Tested, and Fixes can come > before the Author sign off, which is consistent with the chronological > order. > Operationally is there is a flag I'm missing in git-format-patch that does this? git format-patch -s puts my sign off at the very bottom, so this is a manual action to re-order if I'm adding in Reviewed-by: in the patch description.
On Wed, Sep 27, 2017 at 05:30:40PM +0000, Mario.Limonciello@dell.com wrote: > > -----Original Message----- > > From: Darren Hart [mailto:dvhart@infradead.org] > > Sent: Wednesday, September 27, 2017 1:22 PM > > To: Limonciello, Mario <Mario_Limonciello@Dell.com> > > Cc: Andy Shevchenko <andy.shevchenko@gmail.com>; LKML <linux- > > kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org; > > quasisec@google.com; pali.rohar@gmail.com > > Subject: Re: [PATCH v2 03/14] platform/x86: dell-wmi: Don't match on descriptor > > GUID modalias > > > > On Tue, Sep 26, 2017 at 01:50:01PM -0500, Mario Limonciello wrote: > > > The descriptor GUID is not used to indicate that WMI notifications > > > in the dell-wmi driver work properly. As such a modalias should > > > not be present that causes this driver to load on systems with this > > > GUID. > > > > > > Reviewed-by: Pali Pohar <pali.rohar@gmail.com> > > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > > > > I can do this manually, but for future reference: > > > > Nit, in general, the author's sign off should be first, followed by > > reviewers and testers. The maintainer will add their sign off at the end > > - this keeps things clear regarding the development and delivery path. > > In general, assume chronological order and you'll have the right idea. > > > > Informational tags, like Reported, Suggested, Tested, and Fixes can come > > before the Author sign off, which is consistent with the chronological > > order. > > > > Operationally is there is a flag I'm missing in git-format-patch that does > this? git format-patch -s puts my sign off at the very bottom, so this is a > manual action to re-order if I'm adding in Reviewed-by: in the patch > description. Yes, this is a manual step. Git will add your sign off for you, but it doesn't do it contextually, always at the end. Works for the first writing, after that you have to manage the tags manually. (or at least that is what I do)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c index 28d9f8696081..1fbef560ca67 100644 --- a/drivers/platform/x86/dell-wmi.c +++ b/drivers/platform/x86/dell-wmi.c @@ -51,7 +51,6 @@ MODULE_LICENSE("GPL"); static bool wmi_requires_smbios_request; MODULE_ALIAS("wmi:"DELL_EVENT_GUID); -MODULE_ALIAS("wmi:"DELL_DESCRIPTOR_GUID); struct dell_wmi_priv { struct input_dev *input_dev;