From patchwork Sat May 27 05:16:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Darren Hart X-Patchwork-Id: 9751491 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B638C6037E for ; Sat, 27 May 2017 05:16:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA2F428448 for ; Sat, 27 May 2017 05:16:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9F1C02846A; Sat, 27 May 2017 05:16:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5566328448 for ; Sat, 27 May 2017 05:16:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752069AbdE0FQ1 (ORCPT ); Sat, 27 May 2017 01:16:27 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:54740 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065AbdE0FQX (ORCPT ); Sat, 27 May 2017 01:16:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Bbo3lA9PnmmtmRmXKwU326QIjo5e4TX7Gd4ZETgfWm4=; b=q13LR+f071EaZDtG41VGoOyoS 4vKkGLjWo9sQN7DcCw2XvkaXQB+Y1xwdLEB00iVwI/GZnF2FHz3II+LRcTW/OLA8Bhasd0TKTNvOs L7Yz30sS58hHsehMCnIHUsb5M27K7lMTVqwBVhQwcuT3MtE75U4ilmY8cmfK3PDMGkLAh2Lp0P3m3 5cQ2GdN1iSk7tiVI7MuPa2FQWujyGkEWM9ti0N9QHPDXKSl5XoeqZHcVZMkqng+ONMuEIwucYcgtA lGtGoqPdO4/vsckElyBTbN8SNehuzwpOnUbGEzuJZJfHwaR+8EAF41xeKMNRmFNrrOXF5voQD6gZm M1Wslx6Dw==; Received: from dvhart by bombadil.infradead.org with local (Exim 4.87 #1 (Red Hat Linux)) id 1dEU5O-0003zU-8b; Sat, 27 May 2017 05:16:22 +0000 From: Darren Hart To: platform-driver-x86@vger.kernel.org Cc: LKML , Andy Lutomirski , Mario Limonciello , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Darren Hart Subject: [PATCH] platform/x86: dell-rbtn: Improve explanation about DELLABC6 Date: Fri, 26 May 2017 22:16:19 -0700 Message-Id: X-Mailer: git-send-email 2.9.4 MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Andy Lutomirski According to Mario at Dell, the DELLABC6 device should not be used on a Linux system. It also conflicts with Intel-HID and its interactions with Network Manager. Document that we are aware of the device, but that we are intentionally ignoring it. Signed-off-by: Andy Lutomirski [dvhart: New commit message and minor comment wording fixes] Cc: Mario Limonciello Cc: "Pali Rohár" Signed-off-by: Darren Hart (VMware) Reviewed-by: Andy Shevchenko --- drivers/platform/x86/dell-rbtn.c | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c index dcd9f40..2eeef03 100644 --- a/drivers/platform/x86/dell-rbtn.c +++ b/drivers/platform/x86/dell-rbtn.c @@ -223,14 +223,26 @@ static const struct acpi_device_id rbtn_ids[] = { * This driver can also handle the "DELLABC6" device that * appears on the XPS 13 9350, but that device is disabled * by the DSDT unless booted with acpi_osi="!Windows 2012" - * acpi_osi="!Windows 2013". Even if we boot that and bind - * the driver, we seem to have inconsistent behavior in - * which NetworkManager can get out of sync with the rfkill - * state. + * acpi_osi="!Windows 2013". * - * On the XPS 13 9350 and similar laptops, we're not supposed to - * use DELLABC6 at all. Instead, we handle the rfkill button - * via the intel-hid driver. + * According to Mario at Dell: + * + * DELLABC6 is a custom interface that was created solely to + * have airplane mode support for Windows 7. For Windows 10 + * the proper interface is to use that which is handled by + * intel-hid. A OEM airplane mode driver is not used. + * + * Since the kernel doesn't identify as Windows 7 it would be + * incorrect to do attempt to use that interface. + * + * Even if we override _OSI and bind to DELLABC6, we end up + * with inconsistent behavior in which NetworkManager can get + * out of sync with the rfkill state. This happens because + * NetworkManager receives events from intel-hid and fights with + * dell-rbtn for control. + * + * The upshot is that it's better to just ignore DELLABC6 + * devices. */ { "", 0 },