| Message ID | c455b3c7-f408-4d7c-979f-83f07f94e845@d-systems.ee (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | intel-hid: fix volume buttons on Microsoft Surface Go 4 tablet | expand |
Hi Dmitry, On 19-Feb-25 11:08 PM, Dmitry Panchenko | d-Systems wrote: > Hello, > > Volume buttons on Microsoft Surface Go 4 tablet didn't send any events. Adding Surface Go 4 to button_array_table fix this. > > The patch is attached. > > Signed-off-by: Dmitry Panchenko <dmitry@d-systems.ee> Thank you for your patch. Unfortunately this is not in the correct format for submitting patches. It is close though, good job for a first try. To turn this into a proper patch, make the changes from your attached patch to a git clone of a recent kernel tree (e.g, Linus Torvald's tree) and then after making the changes do: git commit -as and for the commit message use: """ platform/x86: intel-hid: fix volume buttons on Microsoft Surface Go 4 tablet Volume buttons on Microsoft Surface Go 4 tablet didn't send any events. Add Surface Go 4 DMI match to button_array_table to fix this. Signed-off-by: Dmitry Panchenko <dmitry@d-systems.ee> """ and then do: git format-patch HEAD~ to get a 0001-xxxxxx.patch file, followed by: git send-email 0001-xxxxxx.patch to send an email. Note this also requires that you first setup a ~/.gitconfig for your name + email, as well as send-email config, e.g. I have: """ [user] name = Hans de Goede email = hdegoede@redhat.com [sendemail] from = Hans de Goede <hdegoede@redhat.com> smtpserver = smtp.corp.redhat.com """ Or alternatively I can send a v2 patch for your putting things in the right format. Regards, Hans
Dear Hans de Goede, Thank you for the reply and suggestions. I have obtained kernel sources using distro's packet manager (apt-get source linux-source) for the running kernel in order to build single module. Building the whole kernel on a super low-power device is not an option. The distro's source is not a git repository. Is it possible to provide patch without git? Or the only option is to git clone linux source, replace hid.c and git? Kind regards, Dmitry Panchenko On 20.02.25 15:47, Hans de Goede wrote: > Hi Dmitry, > > On 19-Feb-25 11:08 PM, Dmitry Panchenko | d-Systems wrote: >> Hello, >> >> Volume buttons on Microsoft Surface Go 4 tablet didn't send any events. Adding Surface Go 4 to button_array_table fix this. >> >> The patch is attached. >> >> Signed-off-by: Dmitry Panchenko <dmitry@d-systems.ee> > Thank you for your patch. Unfortunately this is not in the correct format > for submitting patches. It is close though, good job for a first try. > > To turn this into a proper patch, make the changes from your attached > patch to a git clone of a recent kernel tree (e.g, Linus Torvald's tree) > and then after making the changes do: > > git commit -as > > and for the commit message use: > > """ > platform/x86: intel-hid: fix volume buttons on Microsoft Surface Go 4 tablet > > Volume buttons on Microsoft Surface Go 4 tablet didn't send any events. > Add Surface Go 4 DMI match to button_array_table to fix this. > > Signed-off-by: Dmitry Panchenko <dmitry@d-systems.ee> > """ > > and then do: > > git format-patch HEAD~ > > to get a 0001-xxxxxx.patch file, followed by: > > git send-email 0001-xxxxxx.patch > > to send an email. > > Note this also requires that you first setup a ~/.gitconfig for your > name + email, as well as send-email config, e.g. I have: > > """ > [user] > name = Hans de Goede > email = hdegoede@redhat.com > > [sendemail] > from = Hans de Goede <hdegoede@redhat.com> > smtpserver = smtp.corp.redhat.com > """ > > Or alternatively I can send a v2 patch for your putting things in > the right format. > > Regards, > > Hans > >
Hi, On 20-Feb-25 3:04 PM, Dmitry Panchenko | d-Systems wrote: > Dear Hans de Goede, > > Thank you for the reply and suggestions. I have obtained kernel sources using distro's packet manager (apt-get source linux-source) for the running kernel in order to build single module. Building the whole kernel on a super low-power device is not an option. The distro's source is not a git repository. Is it possible to provide patch without git? Or the only option is to git clone linux source, replace hid.c and git? The kernel workflow is very much setup expecting that git is used. As I mentioned in my previous email, I can take your patch, apply it manually and then send out a new version in the proper git format-patch format for Ilpo to pickup and merge that. You will of course be kept as author of the patch and your Signed-off-by will also be kept. Shall I do this (send out a v2 with the proper format) ? Regards, Hans > On 20.02.25 15:47, Hans de Goede wrote: >> Hi Dmitry, >> >> On 19-Feb-25 11:08 PM, Dmitry Panchenko | d-Systems wrote: >>> Hello, >>> >>> Volume buttons on Microsoft Surface Go 4 tablet didn't send any events. Adding Surface Go 4 to button_array_table fix this. >>> >>> The patch is attached. >>> >>> Signed-off-by: Dmitry Panchenko <dmitry@d-systems.ee> >> Thank you for your patch. Unfortunately this is not in the correct format >> for submitting patches. It is close though, good job for a first try. >> >> To turn this into a proper patch, make the changes from your attached >> patch to a git clone of a recent kernel tree (e.g, Linus Torvald's tree) >> and then after making the changes do: >> >> git commit -as >> >> and for the commit message use: >> >> """ >> platform/x86: intel-hid: fix volume buttons on Microsoft Surface Go 4 tablet >> >> Volume buttons on Microsoft Surface Go 4 tablet didn't send any events. >> Add Surface Go 4 DMI match to button_array_table to fix this. >> >> Signed-off-by: Dmitry Panchenko <dmitry@d-systems.ee> >> """ >> >> and then do: >> >> git format-patch HEAD~ >> >> to get a 0001-xxxxxx.patch file, followed by: >> >> git send-email 0001-xxxxxx.patch >> >> to send an email. >> >> Note this also requires that you first setup a ~/.gitconfig for your >> name + email, as well as send-email config, e.g. I have: >> >> """ >> [user] >> name = Hans de Goede >> email = hdegoede@redhat.com >> >> [sendemail] >> from = Hans de Goede <hdegoede@redhat.com> >> smtpserver = smtp.corp.redhat.com >> """ >> >> Or alternatively I can send a v2 patch for your putting things in >> the right format. >> >> Regards, >> >> Hans >> >> >
--- original/drivers/platform/x86/intel/hid.c 2025-01-17 16:10:22.000000000 +0200 +++ fixed/drivers/platform/x86/intel/hid.c 2025-02-19 22:22:51.682382249 +0200 @@ -128,6 +128,13 @@ DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go 3"), }, }, + { + .ident = "Microsoft Surface Go 4", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"), + DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go 4"), + }, + }, { } };
Hello, Volume buttons on Microsoft Surface Go 4 tablet didn't send any events. Adding Surface Go 4 to button_array_table fix this. The patch is attached. Signed-off-by: Dmitry Panchenko <dmitry@d-systems.ee>