| Message ID | e095a34ec411e46a6e890f5215b1f85ee7338795.1505999739.git.mario.limonciello@dell.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Thursday 21 September 2017 08:57:07 Mario Limonciello wrote: > The descriptor GUID is not used to indicate that WMI notifications > in the dell-wmi driver work properly. As such a modalias should > not be present that causes this driver to load on systems with this > GUID. Ok, understood. What we need there is to load driver in case both aliases are present in system. But I have no idea if kernel supports such logic. So, add my: Reviewed-by: Pali Rohár <pali.rohar@gmail.com> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > --- > drivers/platform/x86/dell-wmi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > index 28d9f8696081..1fbef560ca67 100644 > --- a/drivers/platform/x86/dell-wmi.c > +++ b/drivers/platform/x86/dell-wmi.c > @@ -51,7 +51,6 @@ MODULE_LICENSE("GPL"); > static bool wmi_requires_smbios_request; > > MODULE_ALIAS("wmi:"DELL_EVENT_GUID); > -MODULE_ALIAS("wmi:"DELL_DESCRIPTOR_GUID); > > struct dell_wmi_priv { > struct input_dev *input_dev;
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c index 28d9f8696081..1fbef560ca67 100644 --- a/drivers/platform/x86/dell-wmi.c +++ b/drivers/platform/x86/dell-wmi.c @@ -51,7 +51,6 @@ MODULE_LICENSE("GPL"); static bool wmi_requires_smbios_request; MODULE_ALIAS("wmi:"DELL_EVENT_GUID); -MODULE_ALIAS("wmi:"DELL_DESCRIPTOR_GUID); struct dell_wmi_priv { struct input_dev *input_dev;
The descriptor GUID is not used to indicate that WMI notifications in the dell-wmi driver work properly. As such a modalias should not be present that causes this driver to load on systems with this GUID. Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> --- drivers/platform/x86/dell-wmi.c | 1 - 1 file changed, 1 deletion(-)