From patchwork Sat May 27 05:15:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Darren Hart X-Patchwork-Id: 9751485 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9970F6037E for ; Sat, 27 May 2017 05:16:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 893F028448 for ; Sat, 27 May 2017 05:16:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 79B5D2846A; Sat, 27 May 2017 05:16:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E31B428448 for ; Sat, 27 May 2017 05:16:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751364AbdE0FQS (ORCPT ); Sat, 27 May 2017 01:16:18 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:48699 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbdE0FQR (ORCPT ); Sat, 27 May 2017 01:16:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dOzpM1hciBdx4Yoxyl1cYVHKnimMfdfr2gQnEY6pANU=; b=CSJEhJGsfqcWqWx9Wrh9Whb7U gFJLiAxAnpbp5nSUdZYTfsXsAITveDUaMd36wfsPEsx1DL5Q+dO33Uet2ckCMfz+WvTUzm9HScM3Y bq5FaE3mk+d+QI2/rR52wcHpfJ7oYZ8hYWEWVur1eesE4hyQBl1Ac7DRN4syfBWsZPUK/rvQKhagl StZJ23GTCiTUl3OBtjSl89Rfor/P5gDCHI2s5JLdaG/uGl7/ppJuhdqJLsGDOLpKQtyvAZmt7Cqf0 viFahISFL1UG17CPkuY3S7gVIS9vdEUpBwnPBudzbkCo3LMvaPJlqj12BuIcbr1uJwTISIF5bRWye sK9+HPYIQ==; Received: from dvhart by bombadil.infradead.org with local (Exim 4.87 #1 (Red Hat Linux)) id 1dEU5B-0003xq-Q4; Sat, 27 May 2017 05:16:09 +0000 From: Darren Hart To: platform-driver-x86@vger.kernel.org Cc: LKML , Andy Lutomirski , Matthew Garrett , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Andy Shevchenko , Darren Hart Subject: [PATCH] platform/x86: dell-wmi: Add a comment explaining the 0xb2 magic number Date: Fri, 26 May 2017 22:15:28 -0700 Message-Id: X-Mailer: git-send-email 2.9.4 MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Andy Lutomirski The hotkey table is 0xb2, add a comment for clarity. Suggested-by: Darren Hart Signed-off-by: Andy Lutomirski Cc: Matthew Garrett Cc: "Pali Rohár" Cc: Andy Shevchenko Signed-off-by: Darren Hart (VMware) Reviewed-by: Andy Shevchenko --- drivers/platform/x86/dell-wmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c index 8a64c79..24467b1 100644 --- a/drivers/platform/x86/dell-wmi.c +++ b/drivers/platform/x86/dell-wmi.c @@ -449,6 +449,7 @@ static void __init handle_dmi_entry(const struct dmi_header *dm, if (results->err || results->keymap) return; /* We already found the hotkey table. */ + /* The Dell hotkey table is type 0xB2. Scan until we find it. */ if (dm->type != 0xb2) return;