| Message ID | f134070fe93b5ce81ceea9071497d853b7e7db9c.1455553470.git.luto@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Mon, Feb 15, 2016 at 08:32:34AM -0800, Andy Lutomirski wrote: > dell-wmi and dell-laptop will compile but won't work right if DMI > isn't selected. Was this necessitated by patch 1/5, or was this an existing problem? If the former, I'd prefer to just include this in 1/5. If the latter, this is fine. > > Signed-off-by: Andy Lutomirski <luto@kernel.org> > --- > > Changes from v2 and v3: None > > Changes from v1: > - New patch. > > drivers/platform/x86/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 3e4d9c3e83fd..659e13b1e6f0 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -112,6 +112,7 @@ config DELL_LAPTOP > select POWER_SUPPLY > select LEDS_CLASS > select NEW_LEDS > + select DMI > default n > ---help--- > This driver adds support for rfkill and backlight control to Dell > @@ -123,6 +124,7 @@ config DELL_WMI > depends on INPUT > depends on ACPI_VIDEO || ACPI_VIDEO = n > select INPUT_SPARSEKMAP > + select DMI > ---help--- > Say Y here if you want to support WMI-based hotkeys on Dell laptops. > > -- > 2.5.0 > >
On Feb 16, 2016 10:39 PM, "Darren Hart" <dvhart@infradead.org> wrote: > > On Mon, Feb 15, 2016 at 08:32:34AM -0800, Andy Lutomirski wrote: > > dell-wmi and dell-laptop will compile but won't work right if DMI > > isn't selected. > > Was this necessitated by patch 1/5, or was this an existing problem? If the > former, I'd prefer to just include this in 1/5. If the latter, this is fine. It's an existing problem, I believe. Jean noticed when reviewing an earlier version of patch 1 IIRC. --Andy -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 3e4d9c3e83fd..659e13b1e6f0 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -112,6 +112,7 @@ config DELL_LAPTOP select POWER_SUPPLY select LEDS_CLASS select NEW_LEDS + select DMI default n ---help--- This driver adds support for rfkill and backlight control to Dell @@ -123,6 +124,7 @@ config DELL_WMI depends on INPUT depends on ACPI_VIDEO || ACPI_VIDEO = n select INPUT_SPARSEKMAP + select DMI ---help--- Say Y here if you want to support WMI-based hotkeys on Dell laptops.
dell-wmi and dell-laptop will compile but won't work right if DMI isn't selected. Signed-off-by: Andy Lutomirski <luto@kernel.org> --- Changes from v2 and v3: None Changes from v1: - New patch. drivers/platform/x86/Kconfig | 2 ++ 1 file changed, 2 insertions(+)