| Message ID | f5d261460d60c546005d126a7629bfd5e4deeaba.camel@intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [GIT,PULL] : tools/power/x86/intel-speed-select pull request for 5.20-rc1 | expand |
Hi, On 7/18/22 19:05, Pandruvada, Srinivas wrote: > Hi Hans, > > There are two minor fixes: > - One for just removing unneeded semicolon > - Another for array range check > > These changes are on top of > https://kernel.googlesource.com/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86/+/refs/heads/for-next > > The following changes since commit > 7a4a04f4e90d746928501a6d551de87d02c28323: > > platform/surface: tabletsw: Fix __le32 integer access (2022-07-17 > 16:20:35 +0200) > > are available in the Git repository at: > > https://github.com/spandruvada/linux-kernel.git intel-sst > > for you to fetch changes up to > 7d565542f8bdc097d611030572ecf8d9706f14dc: > > tools/power/x86/intel-speed-select:Unneeded semicolon (2022-07-18 > 09:51:09 -0700) Thanks. Both commits did not include your Signed-off-by though, if you apply patches of others you must at your S-o-b since you are part of the chain how they got upstream. After pulling I ended up with 2 commits where the S-o-b of the committer of the patch was not present. Instead I've picked both patches directly from the list, now setting me as the committer (and added my own S-o-b). So this is resolved now and both patches are in my review-hans branch now. But the next time when applying patches from others for a pull-req please don't forget to add your own S-o-b. Regards, Hans > > ---------------------------------------------------------------- > Dan Carpenter (1): > tools/power/x86/intel-speed-select: Fix off by one check > > Xin Gao (1): > tools/power/x86/intel-speed-select:Unneeded semicolon > > tools/power/x86/intel-speed-select/hfi-events.c | 2 +- > tools/power/x86/intel-speed-select/isst-daemon.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > Thanks, > Srinivas
On Thu, 2022-07-28 at 16:20 +0200, Hans de Goede wrote: > Hi, > > On 7/18/22 19:05, Pandruvada, Srinivas wrote: > > Hi Hans, > > > > There are two minor fixes: > > - One for just removing unneeded semicolon > > - Another for array range check > > > > These changes are on top of > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86/+/refs/heads/for-next > > > > The following changes since commit > > 7a4a04f4e90d746928501a6d551de87d02c28323: > > > > platform/surface: tabletsw: Fix __le32 integer access (2022-07-17 > > 16:20:35 +0200) > > > > are available in the Git repository at: > > > > https://github.com/spandruvada/linux-kernel.git intel-sst > > > > for you to fetch changes up to > > 7d565542f8bdc097d611030572ecf8d9706f14dc: > > > > tools/power/x86/intel-speed-select:Unneeded semicolon (2022-07-18 > > 09:51:09 -0700) > > Thanks. Both commits did not include your Signed-off-by though, > if you apply patches of others you must at your S-o-b since you > are part of the chain how they got upstream. > > After pulling I ended up with 2 commits where the S-o-b of > the committer of the patch was not present. > > Instead I've picked both patches directly from the list, > now setting me as the committer (and added my own S-o-b). > > So this is resolved now and both patches are in my review-hans > branch now. But the next time when applying patches from others > for a pull-req please don't forget to add your own S-o-b. Sorry about that. Thanks, Srinivas > > Regards, > > Hans > > > > > > > > ---------------------------------------------------------------- > > Dan Carpenter (1): > > tools/power/x86/intel-speed-select: Fix off by one check > > > > Xin Gao (1): > > tools/power/x86/intel-speed-select:Unneeded semicolon > > > > tools/power/x86/intel-speed-select/hfi-events.c | 2 +- > > tools/power/x86/intel-speed-select/isst-daemon.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > Thanks, > > Srinivas >
Hi Hans, There are two minor fixes: - One for just removing unneeded semicolon - Another for array range check These changes are on top of https://kernel.googlesource.com/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86/+/refs/heads/for-next The following changes since commit 7a4a04f4e90d746928501a6d551de87d02c28323: platform/surface: tabletsw: Fix __le32 integer access (2022-07-17 16:20:35 +0200) are available in the Git repository at: https://github.com/spandruvada/linux-kernel.git intel-sst for you to fetch changes up to 7d565542f8bdc097d611030572ecf8d9706f14dc: tools/power/x86/intel-speed-select:Unneeded semicolon (2022-07-18 09:51:09 -0700) ---------------------------------------------------------------- Dan Carpenter (1): tools/power/x86/intel-speed-select: Fix off by one check Xin Gao (1): tools/power/x86/intel-speed-select:Unneeded semicolon tools/power/x86/intel-speed-select/hfi-events.c | 2 +- tools/power/x86/intel-speed-select/isst-daemon.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Thanks, Srinivas