mbox series

[v25,0/2] virtio-crypto: virtio crypto device specification

Message ID 1535071416-212072-1-git-send-email-longpeng2@huawei.com (mailing list archive)
Headers show
Series virtio-crypto: virtio crypto device specification | expand

Message

Longpeng(Mike) Aug. 24, 2018, 12:43 a.m. UTC 
---
v25 -> v24
 - fix some typos and letex grammar.

v24 -> v23
 - Some enhancements based on Halil's suggestion. [Halil]

v23 -> v22
 - rename MUX_MODE to REVISION_1 [Halil]
 - fixed-length paramenters' instead of 'header' and
   'variable-length parameters' instead of 'extra parameters' [Halil]
 - add guidance about VIRTIO_CRYPTO_FLAG_SESSION_MODE [Halil]
 - other fixes. [Longpeng]

v22 -> v21
 - fix some typos and grammar fixes [Halil, Stefan]
 - reorder names in alphabetical order [Stefan]
 - redescribe the date format [Halil]

v21 -> v20
 - rename 'queue_id' to 'reserved' [Halil]
 - redescribe the format of the structures which using 'union'
   in the previous version [Halil]

v20 -> v19
 - fix some typos and grammar fixes [Halil]
 - make queue_id reserved [Halil]
 - remove 'Steps of Operation'

v19 -> v18:
 - fix some typos and grammar fixes [Stefan, Halil]
 - rename VIRTIO_CRYPTO_F_STATELESS_MODE to VIRTIO_CRYPTO_F_MUX_MODE
 - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil]
 - refactor and redescribe the controlq/dataq request's format
   of mux mode. [Halil]
 - other small fixes. [Halil]

v18 -> v17:
 - fix many English grammar problems suggested by Stefan, Thanks a lot!

v17 -> v16:
 - Some grammar fixes [Stefan, Halil, Michael]
 - add a section named "Supported crypto services" in order to explain bit
   numbers and valuse clearly. [Halil, Cornelia]
 - avoid word reptition [Halil]
 - rename non-session mode to stateless mode [Halil]
 - change descriptions for all elements in struct virtio_crypto_config [Halil]
 - add Halil as a reviewer in the ackonwledgement part, thanks for his work.
 - other fixes here and there.

Changes since v15:
 - use feature bits for non-session mode in order to keep compatibility with
   pre-existing code. [Halil & Michael]
 - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all other
   non-session mode feature bits.
 - fix some typos. [Stefan]
 - introduce struct virtio_crypto_op_data_req_mux to support both session
   and non-session based crypto operations and keep compatibility with
   pre-existing code.

Changes since v14:
 - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia]
 - correct a sentence about dataqueue and controlq in the first paragraph. 
[Halil]
 - change a MAY to MUST about max_dataqueues. [Halil]
 - add non-session mode support
   a) add four features for different crypto services to identify wheather 
support session mode.
   b) rewrite some

For pervious versions of virtio crypto spec, Pls see:

[v18]:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg444897.html

[v14]:
https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html

[v13]:
https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html

For more information, please see:
 http://qemu-project.org/Features/VirtioCrypto

Longpeng(Mike) (2):
  virtio-crypto: Add virtio crypto device specification
  virtio-crypto: Add conformance clauses

 acknowledgements.tex |    4 +
 conformance.tex      |   29 +
 content.tex          |    2 +
 virtio-crypto.tex    | 1533 ++++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 1568 insertions(+)
 create mode 100644 virtio-crypto.tex

Comments

Longpeng(Mike) Aug. 24, 2018, 12:51 a.m. UTC | #1 
Hi all,

The v25 spec has no big change but some typos and grammar fix, I attach the PDF
for better review.

If there's no big argument on this version, maybe we can start a ballot in next
week.

On 2018/8/24 8:43, Longpeng(Mike) wrote:

> ---
> v25 -> v24
>  - fix some typos and letex grammar.
> 
> v24 -> v23
>  - Some enhancements based on Halil's suggestion. [Halil]
> 
> v23 -> v22
>  - rename MUX_MODE to REVISION_1 [Halil]
>  - fixed-length paramenters' instead of 'header' and
>    'variable-length parameters' instead of 'extra parameters' [Halil]
>  - add guidance about VIRTIO_CRYPTO_FLAG_SESSION_MODE [Halil]
>  - other fixes. [Longpeng]
> 
> v22 -> v21
>  - fix some typos and grammar fixes [Halil, Stefan]
>  - reorder names in alphabetical order [Stefan]
>  - redescribe the date format [Halil]
> 
> v21 -> v20
>  - rename 'queue_id' to 'reserved' [Halil]
>  - redescribe the format of the structures which using 'union'
>    in the previous version [Halil]
> 
> v20 -> v19
>  - fix some typos and grammar fixes [Halil]
>  - make queue_id reserved [Halil]
>  - remove 'Steps of Operation'
> 
> v19 -> v18:
>  - fix some typos and grammar fixes [Stefan, Halil]
>  - rename VIRTIO_CRYPTO_F_STATELESS_MODE to VIRTIO_CRYPTO_F_MUX_MODE
>  - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil]
>  - refactor and redescribe the controlq/dataq request's format
>    of mux mode. [Halil]
>  - other small fixes. [Halil]
> 
> v18 -> v17:
>  - fix many English grammar problems suggested by Stefan, Thanks a lot!
> 
> v17 -> v16:
>  - Some grammar fixes [Stefan, Halil, Michael]
>  - add a section named "Supported crypto services" in order to explain bit
>    numbers and valuse clearly. [Halil, Cornelia]
>  - avoid word reptition [Halil]
>  - rename non-session mode to stateless mode [Halil]
>  - change descriptions for all elements in struct virtio_crypto_config [Halil]
>  - add Halil as a reviewer in the ackonwledgement part, thanks for his work.
>  - other fixes here and there.
> 
> Changes since v15:
>  - use feature bits for non-session mode in order to keep compatibility with
>    pre-existing code. [Halil & Michael]
>  - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all other
>    non-session mode feature bits.
>  - fix some typos. [Stefan]
>  - introduce struct virtio_crypto_op_data_req_mux to support both session
>    and non-session based crypto operations and keep compatibility with
>    pre-existing code.
> 
> Changes since v14:
>  - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia]
>  - correct a sentence about dataqueue and controlq in the first paragraph. 
> [Halil]
>  - change a MAY to MUST about max_dataqueues. [Halil]
>  - add non-session mode support
>    a) add four features for different crypto services to identify wheather 
> support session mode.
>    b) rewrite some
> 
> For pervious versions of virtio crypto spec, Pls see:
> 
> [v18]:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg444897.html
> 
> [v14]:
> https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html
> 
> [v13]:
> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html
> 
> For more information, please see:
>  http://qemu-project.org/Features/VirtioCrypto
> 
> Longpeng(Mike) (2):
>   virtio-crypto: Add virtio crypto device specification
>   virtio-crypto: Add conformance clauses
> 
>  acknowledgements.tex |    4 +
>  conformance.tex      |   29 +
>  content.tex          |    2 +
>  virtio-crypto.tex    | 1533 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 1568 insertions(+)
>  create mode 100644 virtio-crypto.tex
>
Michael S. Tsirkin Aug. 24, 2018, 11:23 a.m. UTC | #2 
Is there a github issue? If not pls create one.

On Fri, Aug 24, 2018 at 08:51:20AM +0800, Longpeng (Mike) wrote:
> Hi all,
> 
> The v25 spec has no big change but some typos and grammar fix, I attach the PDF
> for better review.
> 
> If there's no big argument on this version, maybe we can start a ballot in next
> week.
> 
> On 2018/8/24 8:43, Longpeng(Mike) wrote:
> 
> > ---
> > v25 -> v24
> >  - fix some typos and letex grammar.
> > 
> > v24 -> v23
> >  - Some enhancements based on Halil's suggestion. [Halil]
> > 
> > v23 -> v22
> >  - rename MUX_MODE to REVISION_1 [Halil]
> >  - fixed-length paramenters' instead of 'header' and
> >    'variable-length parameters' instead of 'extra parameters' [Halil]
> >  - add guidance about VIRTIO_CRYPTO_FLAG_SESSION_MODE [Halil]
> >  - other fixes. [Longpeng]
> > 
> > v22 -> v21
> >  - fix some typos and grammar fixes [Halil, Stefan]
> >  - reorder names in alphabetical order [Stefan]
> >  - redescribe the date format [Halil]
> > 
> > v21 -> v20
> >  - rename 'queue_id' to 'reserved' [Halil]
> >  - redescribe the format of the structures which using 'union'
> >    in the previous version [Halil]
> > 
> > v20 -> v19
> >  - fix some typos and grammar fixes [Halil]
> >  - make queue_id reserved [Halil]
> >  - remove 'Steps of Operation'
> > 
> > v19 -> v18:
> >  - fix some typos and grammar fixes [Stefan, Halil]
> >  - rename VIRTIO_CRYPTO_F_STATELESS_MODE to VIRTIO_CRYPTO_F_MUX_MODE
> >  - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil]
> >  - refactor and redescribe the controlq/dataq request's format
> >    of mux mode. [Halil]
> >  - other small fixes. [Halil]
> > 
> > v18 -> v17:
> >  - fix many English grammar problems suggested by Stefan, Thanks a lot!
> > 
> > v17 -> v16:
> >  - Some grammar fixes [Stefan, Halil, Michael]
> >  - add a section named "Supported crypto services" in order to explain bit
> >    numbers and valuse clearly. [Halil, Cornelia]
> >  - avoid word reptition [Halil]
> >  - rename non-session mode to stateless mode [Halil]
> >  - change descriptions for all elements in struct virtio_crypto_config [Halil]
> >  - add Halil as a reviewer in the ackonwledgement part, thanks for his work.
> >  - other fixes here and there.
> > 
> > Changes since v15:
> >  - use feature bits for non-session mode in order to keep compatibility with
> >    pre-existing code. [Halil & Michael]
> >  - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all other
> >    non-session mode feature bits.
> >  - fix some typos. [Stefan]
> >  - introduce struct virtio_crypto_op_data_req_mux to support both session
> >    and non-session based crypto operations and keep compatibility with
> >    pre-existing code.
> > 
> > Changes since v14:
> >  - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia]
> >  - correct a sentence about dataqueue and controlq in the first paragraph. 
> > [Halil]
> >  - change a MAY to MUST about max_dataqueues. [Halil]
> >  - add non-session mode support
> >    a) add four features for different crypto services to identify wheather 
> > support session mode.
> >    b) rewrite some
> > 
> > For pervious versions of virtio crypto spec, Pls see:
> > 
> > [v18]:
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg444897.html
> > 
> > [v14]:
> > https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html
> > 
> > [v13]:
> > https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html
> > 
> > For more information, please see:
> >  http://qemu-project.org/Features/VirtioCrypto
> > 
> > Longpeng(Mike) (2):
> >   virtio-crypto: Add virtio crypto device specification
> >   virtio-crypto: Add conformance clauses
> > 
> >  acknowledgements.tex |    4 +
> >  conformance.tex      |   29 +
> >  content.tex          |    2 +
> >  virtio-crypto.tex    | 1533 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 1568 insertions(+)
> >  create mode 100644 virtio-crypto.tex
> > 
> 
> 
> -- 
> Regards,
> Longpeng(Mike)
Gonglei (Arei) Aug. 24, 2018, 12:07 p.m. UTC | #3 
Hi Michael,

> -----Original Message-----
> From: virtio-dev@lists.oasis-open.org [mailto:virtio-dev@lists.oasis-open.org]
> On Behalf Of Michael S. Tsirkin
> Sent: Friday, August 24, 2018 7:23 PM
> To: longpeng <longpeng2@huawei.com>
> Cc: xin.zeng@intel.com; Gonglei (Arei) <arei.gonglei@huawei.com>;
> pasic@linux.vnet.ibm.com; qemu-devel@nongnu.org;
> virtio-dev@lists.oasis-open.org; cohuck@redhat.com; stefanha@redhat.com;
> denglingli@chinamobile.com; Jani Kokkonen <Jani.Kokkonen@huawei.com>;
> Ola.Liljedahl@arm.com; Varun.Sethi@freescale.com;
> brian.a.keating@intel.com; liang.j.ma@intel.com; john.griffin@intel.com;
> agraf@suse.de; jasowang@redhat.com; vincent.jardin@6wind.com;
> Huangweidong (C) <weidong.huang@huawei.com>; wangxin (U)
> <wangxinxin.wang@huawei.com>; Zhoujian (jay) <jianjay.zhou@huawei.com>
> Subject: [virtio-dev] Re: [PATCH v25 0/2] virtio-crypto: virtio crypto device
> specification
> 
> Is there a github issue? If not pls create one.
> 

I just created one issue:

https://github.com/oasis-tcs/virtio-spec/issues/19


Thanks,
-Gonglei
Michael S. Tsirkin Aug. 24, 2018, 12:54 p.m. UTC | #4 
On Fri, Aug 24, 2018 at 12:07:44PM +0000, Gonglei (Arei) wrote:
> Hi Michael,
> 
> > -----Original Message-----
> > From: virtio-dev@lists.oasis-open.org [mailto:virtio-dev@lists.oasis-open.org]
> > On Behalf Of Michael S. Tsirkin
> > Sent: Friday, August 24, 2018 7:23 PM
> > To: longpeng <longpeng2@huawei.com>
> > Cc: xin.zeng@intel.com; Gonglei (Arei) <arei.gonglei@huawei.com>;
> > pasic@linux.vnet.ibm.com; qemu-devel@nongnu.org;
> > virtio-dev@lists.oasis-open.org; cohuck@redhat.com; stefanha@redhat.com;
> > denglingli@chinamobile.com; Jani Kokkonen <Jani.Kokkonen@huawei.com>;
> > Ola.Liljedahl@arm.com; Varun.Sethi@freescale.com;
> > brian.a.keating@intel.com; liang.j.ma@intel.com; john.griffin@intel.com;
> > agraf@suse.de; jasowang@redhat.com; vincent.jardin@6wind.com;
> > Huangweidong (C) <weidong.huang@huawei.com>; wangxin (U)
> > <wangxinxin.wang@huawei.com>; Zhoujian (jay) <jianjay.zhou@huawei.com>
> > Subject: [virtio-dev] Re: [PATCH v25 0/2] virtio-crypto: virtio crypto device
> > specification
> > 
> > Is there a github issue? If not pls create one.
> > 
> 
> I just created one issue:
> 
> https://github.com/oasis-tcs/virtio-spec/issues/19

All set to start voting whenever you request it.

> 
> Thanks,
> -Gonglei
Gonglei (Arei) Aug. 28, 2018, 3:31 a.m. UTC | #5 
> -----Original Message-----
> From: Michael S. Tsirkin [mailto:mst@redhat.com]
> Sent: Friday, August 24, 2018 8:54 PM
> 
> On Fri, Aug 24, 2018 at 12:07:44PM +0000, Gonglei (Arei) wrote:
> > Hi Michael,
> >
> > > -----Original Message-----
> > > From: virtio-dev@lists.oasis-open.org
> [mailto:virtio-dev@lists.oasis-open.org]
> > > On Behalf Of Michael S. Tsirkin
> > > Sent: Friday, August 24, 2018 7:23 PM
> > > To: longpeng <longpeng2@huawei.com>
> > > Cc: xin.zeng@intel.com; Gonglei (Arei) <arei.gonglei@huawei.com>;
> > > pasic@linux.vnet.ibm.com; qemu-devel@nongnu.org;
> > > virtio-dev@lists.oasis-open.org; cohuck@redhat.com;
> stefanha@redhat.com;
> > > denglingli@chinamobile.com; Jani Kokkonen
> <Jani.Kokkonen@huawei.com>;
> > > Ola.Liljedahl@arm.com; Varun.Sethi@freescale.com;
> > > brian.a.keating@intel.com; liang.j.ma@intel.com; john.griffin@intel.com;
> > > agraf@suse.de; jasowang@redhat.com; vincent.jardin@6wind.com;
> > > Huangweidong (C) <weidong.huang@huawei.com>; wangxin (U)
> > > <wangxinxin.wang@huawei.com>; Zhoujian (jay)
> <jianjay.zhou@huawei.com>
> > > Subject: [virtio-dev] Re: [PATCH v25 0/2] virtio-crypto: virtio crypto device
> > > specification
> > >
> > > Is there a github issue? If not pls create one.
> > >
> >
> > I just created one issue:
> >
> > https://github.com/oasis-tcs/virtio-spec/issues/19
> 
> All set to start voting whenever you request it.
> 

Hi Michael,

Since no comments currently, pls help to start a ballot for virtio crypto spec if you can. :)


Thanks,
-Gonglei
Michael S. Tsirkin Aug. 28, 2018, 12:12 p.m. UTC | #6 
On Tue, Aug 28, 2018 at 03:31:02AM +0000, Gonglei (Arei) wrote:
> 
> > -----Original Message-----
> > From: Michael S. Tsirkin [mailto:mst@redhat.com]
> > Sent: Friday, August 24, 2018 8:54 PM
> > 
> > On Fri, Aug 24, 2018 at 12:07:44PM +0000, Gonglei (Arei) wrote:
> > > Hi Michael,
> > >
> > > > -----Original Message-----
> > > > From: virtio-dev@lists.oasis-open.org
> > [mailto:virtio-dev@lists.oasis-open.org]
> > > > On Behalf Of Michael S. Tsirkin
> > > > Sent: Friday, August 24, 2018 7:23 PM
> > > > To: longpeng <longpeng2@huawei.com>
> > > > Cc: xin.zeng@intel.com; Gonglei (Arei) <arei.gonglei@huawei.com>;
> > > > pasic@linux.vnet.ibm.com; qemu-devel@nongnu.org;
> > > > virtio-dev@lists.oasis-open.org; cohuck@redhat.com;
> > stefanha@redhat.com;
> > > > denglingli@chinamobile.com; Jani Kokkonen
> > <Jani.Kokkonen@huawei.com>;
> > > > Ola.Liljedahl@arm.com; Varun.Sethi@freescale.com;
> > > > brian.a.keating@intel.com; liang.j.ma@intel.com; john.griffin@intel.com;
> > > > agraf@suse.de; jasowang@redhat.com; vincent.jardin@6wind.com;
> > > > Huangweidong (C) <weidong.huang@huawei.com>; wangxin (U)
> > > > <wangxinxin.wang@huawei.com>; Zhoujian (jay)
> > <jianjay.zhou@huawei.com>
> > > > Subject: [virtio-dev] Re: [PATCH v25 0/2] virtio-crypto: virtio crypto device
> > > > specification
> > > >
> > > > Is there a github issue? If not pls create one.
> > > >
> > >
> > > I just created one issue:
> > >
> > > https://github.com/oasis-tcs/virtio-spec/issues/19
> > 
> > All set to start voting whenever you request it.
> > 
> 
> Hi Michael,
> 
> Since no comments currently, pls help to start a ballot for virtio crypto spec if you can. :)
> 
> 
> Thanks,
> -Gonglei

Done. In the future please add a link to mailing list archives.

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
Gonglei (Arei) Aug. 28, 2018, 12:54 p.m. UTC | #7 
> 
> On Tue, Aug 28, 2018 at 03:31:02AM +0000, Gonglei (Arei) wrote:
> >
> > > -----Original Message-----
> > > From: Michael S. Tsirkin [mailto:mst@redhat.com]
> > > Sent: Friday, August 24, 2018 8:54 PM
> > >
> > > On Fri, Aug 24, 2018 at 12:07:44PM +0000, Gonglei (Arei) wrote:
> > > > Hi Michael,
> > > >
> > > > > -----Original Message-----
> > > > > From: virtio-dev@lists.oasis-open.org
> > > [mailto:virtio-dev@lists.oasis-open.org]
> > > > > On Behalf Of Michael S. Tsirkin
> > > > > Sent: Friday, August 24, 2018 7:23 PM
> > > > > To: longpeng <longpeng2@huawei.com>
> > > > > Cc: xin.zeng@intel.com; Gonglei (Arei) <arei.gonglei@huawei.com>;
> > > > > pasic@linux.vnet.ibm.com; qemu-devel@nongnu.org;
> > > > > virtio-dev@lists.oasis-open.org; cohuck@redhat.com;
> > > stefanha@redhat.com;
> > > > > denglingli@chinamobile.com; Jani Kokkonen
> > > <Jani.Kokkonen@huawei.com>;
> > > > > Ola.Liljedahl@arm.com; Varun.Sethi@freescale.com;
> > > > > brian.a.keating@intel.com; liang.j.ma@intel.com;
> john.griffin@intel.com;
> > > > > agraf@suse.de; jasowang@redhat.com; vincent.jardin@6wind.com;
> > > > > Huangweidong (C) <weidong.huang@huawei.com>; wangxin (U)
> > > > > <wangxinxin.wang@huawei.com>; Zhoujian (jay)
> > > <jianjay.zhou@huawei.com>
> > > > > Subject: [virtio-dev] Re: [PATCH v25 0/2] virtio-crypto: virtio crypto
> device
> > > > > specification
> > > > >
> > > > > Is there a github issue? If not pls create one.
> > > > >
> > > >
> > > > I just created one issue:
> > > >
> > > > https://github.com/oasis-tcs/virtio-spec/issues/19
> > >
> > > All set to start voting whenever you request it.
> > >
> >
> > Hi Michael,
> >
> > Since no comments currently, pls help to start a ballot for virtio crypto spec if
> you can. :)
> >
> >
> > Thanks,
> > -Gonglei
> 
> Done. In the future please add a link to mailing list archives.
> 

Sure. Ballot created at URL: https://www.oasis-open.org/committees/ballot.php?id=3242


Thanks,
-Gonglei
Michael S. Tsirkin Sept. 7, 2018, 9:30 p.m. UTC | #8 
OK it is time to apply this.
If I do I get latex errors (undefined and multiple-defined
labels). Please post patches on top to fix this up,
I will squash.


On Fri, Aug 24, 2018 at 08:43:34AM +0800, Longpeng(Mike) wrote:
> ---
> v25 -> v24
>  - fix some typos and letex grammar.
> 
> v24 -> v23
>  - Some enhancements based on Halil's suggestion. [Halil]
> 
> v23 -> v22
>  - rename MUX_MODE to REVISION_1 [Halil]
>  - fixed-length paramenters' instead of 'header' and
>    'variable-length parameters' instead of 'extra parameters' [Halil]
>  - add guidance about VIRTIO_CRYPTO_FLAG_SESSION_MODE [Halil]
>  - other fixes. [Longpeng]
> 
> v22 -> v21
>  - fix some typos and grammar fixes [Halil, Stefan]
>  - reorder names in alphabetical order [Stefan]
>  - redescribe the date format [Halil]
> 
> v21 -> v20
>  - rename 'queue_id' to 'reserved' [Halil]
>  - redescribe the format of the structures which using 'union'
>    in the previous version [Halil]
> 
> v20 -> v19
>  - fix some typos and grammar fixes [Halil]
>  - make queue_id reserved [Halil]
>  - remove 'Steps of Operation'
> 
> v19 -> v18:
>  - fix some typos and grammar fixes [Stefan, Halil]
>  - rename VIRTIO_CRYPTO_F_STATELESS_MODE to VIRTIO_CRYPTO_F_MUX_MODE
>  - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil]
>  - refactor and redescribe the controlq/dataq request's format
>    of mux mode. [Halil]
>  - other small fixes. [Halil]
> 
> v18 -> v17:
>  - fix many English grammar problems suggested by Stefan, Thanks a lot!
> 
> v17 -> v16:
>  - Some grammar fixes [Stefan, Halil, Michael]
>  - add a section named "Supported crypto services" in order to explain bit
>    numbers and valuse clearly. [Halil, Cornelia]
>  - avoid word reptition [Halil]
>  - rename non-session mode to stateless mode [Halil]
>  - change descriptions for all elements in struct virtio_crypto_config [Halil]
>  - add Halil as a reviewer in the ackonwledgement part, thanks for his work.
>  - other fixes here and there.
> 
> Changes since v15:
>  - use feature bits for non-session mode in order to keep compatibility with
>    pre-existing code. [Halil & Michael]
>  - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all other
>    non-session mode feature bits.
>  - fix some typos. [Stefan]
>  - introduce struct virtio_crypto_op_data_req_mux to support both session
>    and non-session based crypto operations and keep compatibility with
>    pre-existing code.
> 
> Changes since v14:
>  - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia]
>  - correct a sentence about dataqueue and controlq in the first paragraph. 
> [Halil]
>  - change a MAY to MUST about max_dataqueues. [Halil]
>  - add non-session mode support
>    a) add four features for different crypto services to identify wheather 
> support session mode.
>    b) rewrite some
> 
> For pervious versions of virtio crypto spec, Pls see:
> 
> [v18]:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg444897.html
> 
> [v14]:
> https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html
> 
> [v13]:
> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html
> 
> For more information, please see:
>  http://qemu-project.org/Features/VirtioCrypto
> 
> Longpeng(Mike) (2):
>   virtio-crypto: Add virtio crypto device specification
>   virtio-crypto: Add conformance clauses
> 
>  acknowledgements.tex |    4 +
>  conformance.tex      |   29 +
>  content.tex          |    2 +
>  virtio-crypto.tex    | 1533 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 1568 insertions(+)
>  create mode 100644 virtio-crypto.tex
> 
> -- 
> 1.8.3.1
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
Longpeng(Mike) Sept. 10, 2018, 12:54 a.m. UTC | #9 
Hi Michael,

On 2018/9/8 5:30, Michael S. Tsirkin wrote:

> OK it is time to apply this.


Thanks.

> If I do I get latex errors (undefined and multiple-defined
> labels). Please post patches on top to fix this up,
> I will squash.
> 

OK.

I'll keep working with the virtio-crypto spec and code.

> 
> On Fri, Aug 24, 2018 at 08:43:34AM +0800, Longpeng(Mike) wrote:
>> ---
>> v25 -> v24
>>  - fix some typos and letex grammar.
>>
>> v24 -> v23
>>  - Some enhancements based on Halil's suggestion. [Halil]
>>
>> v23 -> v22
>>  - rename MUX_MODE to REVISION_1 [Halil]
>>  - fixed-length paramenters' instead of 'header' and
>>    'variable-length parameters' instead of 'extra parameters' [Halil]
>>  - add guidance about VIRTIO_CRYPTO_FLAG_SESSION_MODE [Halil]
>>  - other fixes. [Longpeng]
>>
>> v22 -> v21
>>  - fix some typos and grammar fixes [Halil, Stefan]
>>  - reorder names in alphabetical order [Stefan]
>>  - redescribe the date format [Halil]
>>
>> v21 -> v20
>>  - rename 'queue_id' to 'reserved' [Halil]
>>  - redescribe the format of the structures which using 'union'
>>    in the previous version [Halil]
>>
>> v20 -> v19
>>  - fix some typos and grammar fixes [Halil]
>>  - make queue_id reserved [Halil]
>>  - remove 'Steps of Operation'
>>
>> v19 -> v18:
>>  - fix some typos and grammar fixes [Stefan, Halil]
>>  - rename VIRTIO_CRYPTO_F_STATELESS_MODE to VIRTIO_CRYPTO_F_MUX_MODE
>>  - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil]
>>  - refactor and redescribe the controlq/dataq request's format
>>    of mux mode. [Halil]
>>  - other small fixes. [Halil]
>>
>> v18 -> v17:
>>  - fix many English grammar problems suggested by Stefan, Thanks a lot!
>>
>> v17 -> v16:
>>  - Some grammar fixes [Stefan, Halil, Michael]
>>  - add a section named "Supported crypto services" in order to explain bit
>>    numbers and valuse clearly. [Halil, Cornelia]
>>  - avoid word reptition [Halil]
>>  - rename non-session mode to stateless mode [Halil]
>>  - change descriptions for all elements in struct virtio_crypto_config [Halil]
>>  - add Halil as a reviewer in the ackonwledgement part, thanks for his work.
>>  - other fixes here and there.
>>
>> Changes since v15:
>>  - use feature bits for non-session mode in order to keep compatibility with
>>    pre-existing code. [Halil & Michael]
>>  - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all other
>>    non-session mode feature bits.
>>  - fix some typos. [Stefan]
>>  - introduce struct virtio_crypto_op_data_req_mux to support both session
>>    and non-session based crypto operations and keep compatibility with
>>    pre-existing code.
>>
>> Changes since v14:
>>  - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia]
>>  - correct a sentence about dataqueue and controlq in the first paragraph. 
>> [Halil]
>>  - change a MAY to MUST about max_dataqueues. [Halil]
>>  - add non-session mode support
>>    a) add four features for different crypto services to identify wheather 
>> support session mode.
>>    b) rewrite some
>>
>> For pervious versions of virtio crypto spec, Pls see:
>>
>> [v18]:
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg444897.html
>>
>> [v14]:
>> https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html
>>
>> [v13]:
>> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html
>>
>> For more information, please see:
>>  http://qemu-project.org/Features/VirtioCrypto
>>
>> Longpeng(Mike) (2):
>>   virtio-crypto: Add virtio crypto device specification
>>   virtio-crypto: Add conformance clauses
>>
>>  acknowledgements.tex |    4 +
>>  conformance.tex      |   29 +
>>  content.tex          |    2 +
>>  virtio-crypto.tex    | 1533 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 1568 insertions(+)
>>  create mode 100644 virtio-crypto.tex
>>
>> -- 
>> 1.8.3.1
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
>> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
> 
> .
>