mbox series

[v2,0/4] iotests: check whitelisted formats

Message ID 1551965640-164939-1-git-send-email-andrey.shinkevich@virtuozzo.com (mailing list archive)
Headers show
Series iotests: check whitelisted formats | expand

Message

Andrey Shinkevich March 7, 2019, 1:33 p.m. UTC 
Some test cases require specific formats to be supported by QEMU. The
list of formats supported by the block layer doesn't take whitelists
into account. This series manages this issue. The method decorator
skip_if_unsupported() checks if requested formats are whitelisted.
The sample output is shown with the test #139.

v1:
Discussed in the email thread with the message ID:
<1551694120-768127-1-git-send-email-andrey.shinkevich@virtuozzo.com>
Fixes and amendments suggested by Kevin Wolf were applied in v2.

Andrey Shinkevich (4):
  iotests: open notrun files in text mode
  block: iterate_format with account of whitelisting
  iotests: ask QEMU for supported formats
  iotests: check whitelisted formats

 block.c                       | 23 ++++++++++++++++++----
 blockdev.c                    |  4 +++-
 include/block/block.h         |  2 +-
 qemu-img.c                    |  2 +-
 tests/qemu-iotests/139        |  3 +++
 tests/qemu-iotests/check      | 13 ++++++++++++-
 tests/qemu-iotests/iotests.py | 45 ++++++++++++++++++++++++++++++++++++++++++-
 7 files changed, 83 insertions(+), 9 deletions(-)

Comments

Kevin Wolf March 7, 2019, 3:11 p.m. UTC | #1 
Am 07.03.2019 um 14:33 hat Andrey Shinkevich geschrieben:
> Some test cases require specific formats to be supported by QEMU. The
> list of formats supported by the block layer doesn't take whitelists
> into account. This series manages this issue. The method decorator
> skip_if_unsupported() checks if requested formats are whitelisted.
> The sample output is shown with the test #139.

Thanks, applied to the block branch.

Kevin
Andrey Shinkevich March 7, 2019, 3:23 p.m. UTC | #2 
On 07/03/2019 18:11, Kevin Wolf wrote:
> Am 07.03.2019 um 14:33 hat Andrey Shinkevich geschrieben:
>> Some test cases require specific formats to be supported by QEMU. The
>> list of formats supported by the block layer doesn't take whitelists
>> into account. This series manages this issue. The method decorator
>> skip_if_unsupported() checks if requested formats are whitelisted.
>> The sample output is shown with the test #139.
> 
> Thanks, applied to the block branch.
> 
> Kevin
> 
Thank you too!