| Message ID | 1552098649-28341-1-git-send-email-guoheyi@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm/acpi: simplify aml code and enable SHPC | expand |
On Sat, Mar 09, 2019 at 10:30:47AM +0800, Heyi Guo wrote: > After the introduction of generic PCIe root port and PCIe-PCI bridge, we will > also have SHPC controller on ARM, and we don't support ACPI hot plug, so just > enable SHPC native hot plug. > > Igor also spotted the store operation outside of bit and/or is not necessary, so > simply the code at first. > > v5: > - Refine commit message of patch 1/2 > > v4: > - Improve the code indention. > > Cc: Shannon Zhao <shannon.zhaosl@gmail.com> > Cc: Peter Maydell <peter.maydell@linaro.org> > Cc: "Michael S. Tsirkin" <mst@redhat.com> > Cc: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > > > Heyi Guo (2): > hw/arm/acpi: simplify AML bit and/or statement > hw/arm/acpi: enable SHPC native hot plug > > hw/arm/virt-acpi-build.c | 21 +++++++++++++-------- > 1 file changed, 13 insertions(+), 8 deletions(-) > > -- > 1.8.3.1
On Sat, 9 Mar 2019 10:30:47 +0800 Heyi Guo <guoheyi@huawei.com> wrote: > After the introduction of generic PCIe root port and PCIe-PCI bridge, we will > also have SHPC controller on ARM, and we don't support ACPI hot plug, so just > enable SHPC native hot plug. Peter, could you queue it via your tree? > > Igor also spotted the store operation outside of bit and/or is not necessary, so > simply the code at first. > > v5: > - Refine commit message of patch 1/2 > > v4: > - Improve the code indention. > > Cc: Shannon Zhao <shannon.zhaosl@gmail.com> > Cc: Peter Maydell <peter.maydell@linaro.org> > Cc: "Michael S. Tsirkin" <mst@redhat.com> > Cc: Igor Mammedov <imammedo@redhat.com> > > > > Heyi Guo (2): > hw/arm/acpi: simplify AML bit and/or statement > hw/arm/acpi: enable SHPC native hot plug > > hw/arm/virt-acpi-build.c | 21 +++++++++++++-------- > 1 file changed, 13 insertions(+), 8 deletions(-) >
Hi Peter, Igor, I couldn't find these 2 patches in the latest tree. Could you help to merge them? Thanks, HG On 2019/3/13 0:09, Igor Mammedov wrote: > On Sat, 9 Mar 2019 10:30:47 +0800 > Heyi Guo <guoheyi@huawei.com> wrote: > >> After the introduction of generic PCIe root port and PCIe-PCI bridge, we will >> also have SHPC controller on ARM, and we don't support ACPI hot plug, so just >> enable SHPC native hot plug. > Peter, > could you queue it via your tree? > >> Igor also spotted the store operation outside of bit and/or is not necessary, so >> simply the code at first. >> >> v5: >> - Refine commit message of patch 1/2 >> >> v4: >> - Improve the code indention. >> >> Cc: Shannon Zhao <shannon.zhaosl@gmail.com> >> Cc: Peter Maydell <peter.maydell@linaro.org> >> Cc: "Michael S. Tsirkin" <mst@redhat.com> >> Cc: Igor Mammedov <imammedo@redhat.com> >> >> >> >> Heyi Guo (2): >> hw/arm/acpi: simplify AML bit and/or statement >> hw/arm/acpi: enable SHPC native hot plug >> >> hw/arm/virt-acpi-build.c | 21 +++++++++++++-------- >> 1 file changed, 13 insertions(+), 8 deletions(-) >> > > . >
On Sat, 30 Nov 2019 at 03:47, Guoheyi <guoheyi@huawei.com> wrote: > > Hi Peter, Igor, > > I couldn't find these 2 patches in the latest tree. Could you help to > merge them? In future I recommend pinging unapplied patches with a shorter delay than nine months :-) In QEMU's process, unless somebody has specifically said they've picked up the patch, it still "belongs" to the submitter to chase if it hasn't been applied. In this case I simply didn't see Igor's request that I take it -- the chances of me actually reading any particular list email even if it's cc'd to me are not good. I tried applying them to target-arm.next but unfortunately they break 'make check': TEST check-qtest-aarch64: tests/bios-tables-test acpi-test: Warning! DSDT binary file mismatch. Actual [aml:/tmp/aml-4IELC0], Expected [aml:tests/data/acpi/virt/DSDT]. acpi-test: Warning! DSDT mismatch. Actual [asl:/tmp/asl-AOELC0.dsl, aml:/tmp/aml-4IELC0], Expected [asl:/tmp/asl-XL7KC0.dsl, aml:tests/data/acpi/virt/DSDT]. ** ERROR:/home/petmay01/linaro/qemu-from-laptop/qemu/tests/bios-tables-test.c:477:test_acpi_asl: assertion failed: (all_tables_match) ERROR - Bail out! ERROR:/home/petmay01/linaro/qemu-from-laptop/qemu/tests/bios-tables-test.c:477:test_acpi_asl: assertion failed: (all_tables_match) Aborted (core dumped) /home/petmay01/linaro/qemu-from-laptop/qemu/tests/Makefile.include:918: recipe for target 'check-qtest-aarch64' failed Could you fix and resubmit, please? thanks -- PMM
在 2019/12/6 21:50, Peter Maydell 写道: > On Sat, 30 Nov 2019 at 03:47, Guoheyi <guoheyi@huawei.com> wrote: >> Hi Peter, Igor, >> >> I couldn't find these 2 patches in the latest tree. Could you help to >> merge them? > In future I recommend pinging unapplied patches with a shorter > delay than nine months :-) Tha's really a long time... > In QEMU's process, unless somebody > has specifically said they've picked up the patch, it still > "belongs" to the submitter to chase if it hasn't been > applied. In this case I simply didn't see Igor's request > that I take it -- the chances of me actually reading any > particular list email even if it's cc'd to me are not good. One of the reasons that I didn't check it earlier is that we don't really use PCI SHPC in our production version, for Linux ITS driver can only allocate a fixed range of MSI interrupts for a PCI-bridge during initialization, so a later plugged-in PCI device may not be able to get enough MSI interrupts and then fall back to legacy INTx. However, I think it is still better to let guest OS make the decision. > > I tried applying them to target-arm.next but unfortunately > they break 'make check': > > TEST check-qtest-aarch64: tests/bios-tables-test > acpi-test: Warning! DSDT binary file mismatch. Actual > [aml:/tmp/aml-4IELC0], Expected [aml:tests/data/acpi/virt/DSDT]. > acpi-test: Warning! DSDT mismatch. Actual [asl:/tmp/asl-AOELC0.dsl, > aml:/tmp/aml-4IELC0], Expected [asl:/tmp/asl-XL7KC0.dsl, > aml:tests/data/acpi/virt/DSDT]. > ** > ERROR:/home/petmay01/linaro/qemu-from-laptop/qemu/tests/bios-tables-test.c:477:test_acpi_asl: > assertion failed: (all_tables_match) > ERROR - Bail out! > ERROR:/home/petmay01/linaro/qemu-from-laptop/qemu/tests/bios-tables-test.c:477:test_acpi_asl: > assertion failed: (all_tables_match) > Aborted (core dumped) > /home/petmay01/linaro/qemu-from-laptop/qemu/tests/Makefile.include:918: > recipe for target 'check-qtest-aarch64' failed > > Could you fix and resubmit, please? Sure. Thanks, Heyi > > thanks > -- PMM > > .