Message ID | 1553193630-28611-1-git-send-email-sandra@codesourcery.com (mailing list archive) |
---|---|
Headers | show |
Series | Nios II generic board config and semihosting | expand |
Patchew URL: https://patchew.org/QEMU/1553193630-28611-1-git-send-email-sandra@codesourcery.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v6 0/2] Nios II generic board config and semihosting Message-id: 1553193630-28611-1-git-send-email-sandra@codesourcery.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/1553193630-28611-1-git-send-email-sandra@codesourcery.com -> patchew/1553193630-28611-1-git-send-email-sandra@codesourcery.com Switched to a new branch 'test' 25e8e96 Add Nios II semihosting support. 531d106 Add generic Nios II board. === OUTPUT BEGIN === 1/2 Checking commit 531d10673f8d (Add generic Nios II board.) WARNING: Block comments use a leading /* on a separate line #76: FILE: hw/nios2/boot.c:152: + /* The Nios II processor reference guide documents that the WARNING: Block comments use * on subsequent lines #77: FILE: hw/nios2/boot.c:153: + /* The Nios II processor reference guide documents that the + kernel is placed at virtual memory address 0xc0000000, WARNING: Block comments use a trailing */ on a separate line #79: FILE: hw/nios2/boot.c:155: + and adjust the entry to get the address in physical RAM. */ ERROR: else should follow close brace '}' #87: FILE: hw/nios2/boot.c:163: + } + else { WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #98: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #188: FILE: hw/nios2/generic_nommu.c:86: + /* The libgloss linker script doesn't include an exception vector, WARNING: Block comments use * on subsequent lines #189: FILE: hw/nios2/generic_nommu.c:87: + /* The libgloss linker script doesn't include an exception vector, + so use the reset address. Boo. */ WARNING: Block comments use a trailing */ on a separate line #189: FILE: hw/nios2/generic_nommu.c:87: + so use the reset address. Boo. */ WARNING: Block comments use a leading /* on a separate line #192: FILE: hw/nios2/generic_nommu.c:90: + /* The linker script does have a TLB miss memory region declared, WARNING: Block comments use * on subsequent lines #193: FILE: hw/nios2/generic_nommu.c:91: + /* The linker script does have a TLB miss memory region declared, + but this should never be used with no MMU. */ WARNING: Block comments use a trailing */ on a separate line #193: FILE: hw/nios2/generic_nommu.c:91: + but this should never be used with no MMU. */ total: 1 errors, 10 warnings, 154 lines checked Patch 1/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/2 Checking commit 25e8e964d9bf (Add Nios II semihosting support.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #111: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #263: FILE: target/nios2/nios2-semi.c:148: + /* The nios2 semihosting ABI does not provide any way to report this WARNING: Block comments use a leading /* on a separate line #293: FILE: target/nios2/nios2-semi.c:178: + /* FIXME: We've already lost the high bits of the lseek WARNING: Block comments use * on subsequent lines #294: FILE: target/nios2/nios2-semi.c:179: + /* FIXME: We've already lost the high bits of the lseek + return value. */ WARNING: Block comments use a trailing */ on a separate line #294: FILE: target/nios2/nios2-semi.c:179: + return value. */ WARNING: Block comments use a leading /* on a separate line #302: FILE: target/nios2/nios2-semi.c:187: +/* Read the input value from the argument block; fail the semihosting total: 0 errors, 6 warnings, 521 lines checked Patch 2/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1553193630-28611-1-git-send-email-sandra@codesourcery.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com