[v3,0/4] target/mips: Misc fixes and maintenance for 4.1

Message

Aleksandar Markovic June 20, 2019, 10:02 a.m. UTC

From: Aleksandar Markovic <[e-mail]>

This series contains miscelaneous fixes, improvements, and
maintainance items intended to be integrated into QEMU 4.1.
I will gradually add patches by the end of June 2019.

v2->v3:

  - amendeded two patches on cleaning checkpatch warnings

v1->v2:

  - added two patches on cleaning checkpatch warnings

Aleksandar Markovic (4):
  MAINTAINERS: Update file items for MIPS Malta board
  MAINTAINERS: Consolidate MIPS disassembler-related items
  target/mips: Fix some space checkpatch errors in translate.c
  target/mips: Fix if-else-switch-case arms checkpatch errors in
    translate.c

 MAINTAINERS             |   6 +-
 target/mips/translate.c | 445 +++++++++++++++++++++++++++---------------------
 2 files changed, 257 insertions(+), 194 deletions(-)

Comments

Aleksandar Rikalo June 20, 2019, 10:24 a.m. UTC | #1

> From: Aleksandar Markovic <[e-mail]>
> Sent: Thursday, June 20, 2019 12:02 PM
> To: [e-mail]
> Cc: Aleksandar Markovic; Aleksandar Rikalo
> Subject: [PATCH v3 0/4] target/mips: Misc fixes and maintenance for 4.1
>
> From: Aleksandar Markovic <[e-mail]>
>
> This series contains miscelaneous fixes, improvements, and
> maintainance items intended to be integrated into QEMU 4.1.
> I will gradually add patches by the end of June 2019.
>
> v2->v3:
>
>   - amendeded two patches on cleaning checkpatch warnings
>
> v1->v2:
>
>   - added two patches on cleaning checkpatch warnings
>
> Aleksandar Markovic (4):
>   MAINTAINERS: Update file items for MIPS Malta board
>   MAINTAINERS: Consolidate MIPS disassembler-related items
>   target/mips: Fix some space checkpatch errors in translate.c
>   target/mips: Fix if-else-switch-case arms checkpatch errors in
>     translate.c
>
>  MAINTAINERS             |   6 +-
>  target/mips/translate.c | 445 +++++++++++++++++++++++++++---------------------
>  2 files changed, 257 insertions(+), 194 deletions(-)
>
> --
> 2.7.4

For the whole series.
Reviewed-by: Aleksandar Rikalo <[e-mail]>

[e-mail] June 20, 2019, 11:48 a.m. UTC | #2

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v3 0/4] target/mips: Misc fixes and maintenance for 4.1
Type: series
Message-id: [e-mail]

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
317f44916c target/mips: Fix if-else-switch-case arms checkpatch errors in translate.c
62d84de603 target/mips: Fix some space checkpatch errors in translate.c
5f90ea06d5 MAINTAINERS: Consolidate MIPS disassembler-related items
fb2a72d4cf MAINTAINERS: Update file items for MIPS Malta board

=== OUTPUT BEGIN ===
1/4 Checking commit fb2a72d4cffd (MAINTAINERS: Update file items for MIPS Malta board)
2/4 Checking commit 5f90ea06d5da (MAINTAINERS: Consolidate MIPS disassembler-related items)
3/4 Checking commit 62d84de603dd (target/mips: Fix some space checkpatch errors in translate.c)
4/4 Checking commit 317f44916c47 (target/mips: Fix if-else-switch-case arms checkpatch errors in translate.c)
ERROR: space prohibited after that open parenthesis '('
#139: FILE: target/mips/translate.c:3138:
+    if (unlikely( (ctx->CP0_Config5 & (1 << CP0C5_NMS)) &&

ERROR: space prohibited before that close parenthesis ')'
#140: FILE: target/mips/translate.c:3139:
+                 !(ctx->CP0_Config1 & (1 << CP0C1_DL )) &&

ERROR: space prohibited before that close parenthesis ')'
#141: FILE: target/mips/translate.c:3140:
+                 !(ctx->CP0_Config1 & (1 << CP0C1_IL )) &&

ERROR: space prohibited before that close parenthesis ')'
#142: FILE: target/mips/translate.c:3141:
+                 !(ctx->CP0_Config2 & (1 << CP0C2_SL )) &&

ERROR: space prohibited before that close parenthesis ')'
#143: FILE: target/mips/translate.c:3142:
+                 !(ctx->CP0_Config2 & (1 << CP0C2_TL )) &&

ERROR: space prohibited before that close parenthesis ')'
#144: FILE: target/mips/translate.c:3143:
+                 !(ctx->CP0_Config5 & (1 << CP0C5_L2C))     ) ) {

total: 6 errors, 0 warnings, 432 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]