Message ID | 1581381644-13678-1-git-send-email-tsimpson@quicinc.com (mailing list archive) |
---|---|
Headers | show |
Series | Hexagon patch series | expand |
Patchew URL: https://patchew.org/QEMU/1581381644-13678-1-git-send-email-tsimpson@quicinc.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [RFC PATCH 00/66] Hexagon patch series Message-id: 1581381644-13678-1-git-send-email-tsimpson@quicinc.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/1581381644-13678-1-git-send-email-tsimpson@quicinc.com -> patchew/1581381644-13678-1-git-send-email-tsimpson@quicinc.com Switched to a new branch 'test' 7a2b354 Hexagon HVX build infrastructure f445784 Hexagon HVX translation 876116c Hexagon HVX TCG generation e77505e Hexagon HVX helper to commit vector stores (masked and scatter/gather) dc23a1c Hexagon HVX macros referenced in instruction semantics cc6be78 Hexagon HVX macros to interface with the generator 22f408f Hexagon HVX instruction utility functions 3d4f56a Hexagon HVX instruction decoding 40ec295 Hexagon HVX semantics generator 9c5c895 Hexagon HVX import macro definitions 92dce5d Hexagon HVX import semantics ffcca92 Hexagon HVX import instruction encodings d5ebf14 Hexagon HVX support in gdbstub df47f64 Hexagon - Add Hexagon Vector eXtensions (HVX) to core definition 86f9dd7 Hexagon build infrastructure 4a0112d Hexagon Linux user emulation b272b70 Hexagon translation 8bfe3f2 Hexagon TCG generation - step 12 03465b3 Hexagon TCG generation - step 11 bca0e86 Hexagon TCG generation - step 10 3d5e67f Hexagon TCG generation - step 09 f382bf5 Hexagon TCG generation - step 08 5ce4437 Hexagon TCG generation - step 07 9d340b5 Hexagon TCG generation - step 06 9d2028e Hexagon TCG generation - step 05 42b2388 Hexagon TCG generation - step 04 cdca413 Hexagon TCG generation - step 03 8841a20 Hexagon TCG generation - step 02 0e7ecc9 Hexagon TCG generation - step 01 efc508d Hexagon TCG generation helpers - step 5 4860b36 Hexagon TCG generation helpers - step 4 bac1a49 Hexagon TCG generation helpers - step 3 803f77c Hexagon TCG generation helpers - step 2 8b842c6 Hexagon TCG generation helpers - step 1 6c5d03d Hexagon instruction classes 21cb791 Hexagon macros referenced in instruction semantics c26cc78 Hexagon macros to interface with the generator a9c1282 Hexagon opcode data structures 38f3548 Hexagon generater phase 4 - Decode tree 3d4364b Hexagon generator phase 3 - C preprocessor for decode tree a25a1a5 Hexagon generator phase 2 - printinsn-generated.h f0262c4 Hexagon generator phase 2 - op_regs_generated.h c200b92 Hexagon generator phase 2 - op_attribs_generated.h 55b2d7e Hexagon generator phase 2 - opcodes_def_generated.h 38aac21 Hexagon generator phase 2 - qemu_wrap_generated.h 2c859f2 Hexagon generator phase 2 - qemu_def_generated.h e149804 Hexagon generator phase 1 - C preprocessor for semantics 2a9b0de Hexagon instruction utility functions 6d20bd9 Hexagon instruction class definitions 9510854 Hexagon arch import - instruction encoding 0b9bf23 Hexagon arch import - macro definitions 53dc5e2 Hexagon arch import - instruction semantics definitions b8b3fc7 Hexagon instruction printing 4f5c5b2 Hexagon instruction/packet decode 7ec0047 Hexagon register map 2b98b28 Hexagon instruction attributes d22b29a Hexagon register fields 86ce4af Hexagon architecture types ea357b9 Hexagon instruction and packet types c0d62e7 Hexagon GDB Stub 8fdc6fa Hexagon CPU Scalar Core Helpers edc29eb Hexagon Disassembler d909607 Hexagon register names 10b1312 Hexagon CPU Scalar Core Definition 52e9d22 Hexagon ELF Machine Definition 950dc7d Hexagon Maintainers === OUTPUT BEGIN === 1/66 Checking commit 950dc7d420ac (Hexagon Maintainers) 2/66 Checking commit 52e9d224e833 (Hexagon ELF Machine Definition) 3/66 Checking commit 10b1312bed65 (Hexagon CPU Scalar Core Definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 584 lines checked Patch 3/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/66 Checking commit d9096078a0ab (Hexagon register names) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 97 lines checked Patch 4/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/66 Checking commit edc29ebfa061 (Hexagon Disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 ERROR: space prohibited between function name and open parenthesis '(' #95: FILE: include/disas/dis-asm.h:439: +int print_insn_hexagon (bfd_vma, disassemble_info*); total: 1 errors, 1 warnings, 70 lines checked Patch 5/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/66 Checking commit 8fdc6fa51e8a (Hexagon CPU Scalar Core Helpers) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 469 lines checked Patch 6/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/66 Checking commit c0d62e717802 (Hexagon GDB Stub) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 total: 0 errors, 1 warnings, 58 lines checked Patch 7/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/66 Checking commit ea357b91b9cb (Hexagon instruction and packet types) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 133 lines checked Patch 8/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/66 Checking commit 86ce4afc3459 (Hexagon architecture types) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 42 lines checked Patch 9/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/66 Checking commit d22b29a47e51 (Hexagon register fields) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #84: FILE: target/hexagon/reg_fields.h:33: +#define DEF_REG_FIELD(TAG, NAME, START, WIDTH, DESCRIPTION) \ + TAG, total: 1 errors, 1 warnings, 177 lines checked Patch 10/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/66 Checking commit 2b98b286ca95 (Hexagon instruction attributes) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #37: FILE: target/hexagon/attribs.h:22: +#define DEF_ATTRIB(NAME, ...) A_##NAME, total: 1 errors, 1 warnings, 436 lines checked Patch 11/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/66 Checking commit 7ec004742ef2 (Hexagon register map) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 38 lines checked Patch 12/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/66 Checking commit 4f5c5b2f679e (Hexagon instruction/packet decode) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #121: FILE: target/hexagon/decode.c:95: +#define DECODE_SEPARATOR_BITS(START, WIDTH) NULL, START, WIDTH ERROR: Macros with multiple statements should be enclosed in a do - while loop #901: FILE: target/hexagon/q6v_decode.c:51: +#define DECODE_OPINFO(TAG, BEH) \ + case TAG: \ + { BEH } \ + break; \ + total: 2 errors, 1 warnings, 1214 lines checked Patch 13/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/66 Checking commit b8b3fc71ff35 (Hexagon instruction printing) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 ERROR: Macros with multiple statements should be enclosed in a do - while loop #60: FILE: target/hexagon/printinsn.c:45: +#define DEF_PRINTINFO(TAG, FMT, ...) \ + case TAG: \ + snprintf(buf, n, FMT, __VA_ARGS__);\ + break; total: 1 errors, 1 warnings, 119 lines checked Patch 14/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/66 Checking commit 53dc5e206306 (Hexagon arch import - instruction semantics definitions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 6262 lines checked Patch 15/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/66 Checking commit 0b9bf231147a (Hexagon arch import - macro definitions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100755 total: 0 errors, 1 warnings, 3970 lines checked Patch 16/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/66 Checking commit 95108542b93a (Hexagon arch import - instruction encoding) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 2558 lines checked Patch 17/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/66 Checking commit 6d20bd9668f4 (Hexagon instruction class definitions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 52 lines checked Patch 18/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/66 Checking commit 2a9b0de6e028 (Hexagon instruction utility functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #1705: FILE: target/hexagon/fma_emu.c:518: + /* result zero */ \ WARNING: Block comments use a leading /* on a separate line #1713: FILE: target/hexagon/fma_emu.c:526: + /* Normalize right */ \ WARNING: Block comments use a leading /* on a separate line #1714: FILE: target/hexagon/fma_emu.c:527: + /* We want MANTBITS bits of mantissa plus the leading one. */ \ WARNING: Block comments use a leading /* on a separate line #1715: FILE: target/hexagon/fma_emu.c:528: + /* That means that we want MANTBITS+1 bits, or 0x000000000000FF_FFFF */ \ WARNING: Block comments use a leading /* on a separate line #1716: FILE: target/hexagon/fma_emu.c:529: + /* So we need to normalize right while the high word is non-zero and \ WARNING: Block comments should align the * on each line #1717: FILE: target/hexagon/fma_emu.c:530: + /* So we need to normalize right while the high word is non-zero and \ + * while the low word is nonzero when masked with 0xffe0_0000_0000_0000 */ \ WARNING: Block comments use a leading /* on a separate line #1723: FILE: target/hexagon/fma_emu.c:536: + /* \ WARNING: Block comments use a leading /* on a separate line #1734: FILE: target/hexagon/fma_emu.c:547: + /* \ WARNING: Block comments use a leading /* on a separate line #1741: FILE: target/hexagon/fma_emu.c:554: + /* \ WARNING: Block comments use a leading /* on a separate line #1751: FILE: target/hexagon/fma_emu.c:564: + /* OK, we're relatively canonical... now we need to round */ \ WARNING: Block comments use a leading /* on a separate line #1756: FILE: target/hexagon/fma_emu.c:569: + /* Chop and we're done */ \ WARNING: Block comments use a leading /* on a separate line #1770: FILE: target/hexagon/fma_emu.c:583: + /* round up if guard is 1, down if guard is zero */ \ WARNING: Block comments use a leading /* on a separate line #1773: FILE: target/hexagon/fma_emu.c:586: + /* exactly .5, round up if odd */ \ WARNING: Block comments use a leading /* on a separate line #1780: FILE: target/hexagon/fma_emu.c:593: + /* \ WARNING: Block comments use a leading /* on a separate line #1790: FILE: target/hexagon/fma_emu.c:603: + /* Overflow? */ \ WARNING: Block comments use a leading /* on a separate line #1792: FILE: target/hexagon/fma_emu.c:605: + /* Yep, inf result */ \ WARNING: Block comments use a leading /* on a separate line #1815: FILE: target/hexagon/fma_emu.c:628: + /* Underflow? */ \ WARNING: Block comments use a leading /* on a separate line #1817: FILE: target/hexagon/fma_emu.c:630: + /* Leading one means: No, we're normal. So, we should be done... */ \ total: 0 errors, 19 warnings, 2094 lines checked Patch 19/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/66 Checking commit e1498047e852 (Hexagon generator phase 1 - C preprocessor for semantics) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 ERROR: suspicious ; after while (0) #78: FILE: target/hexagon/gen_semantics.c:59: + } while (0); ERROR: suspicious ; after while (0) #85: FILE: target/hexagon/gen_semantics.c:66: + } while (0); total: 2 errors, 1 warnings, 92 lines checked Patch 20/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/66 Checking commit 2c859f2e31ea (Hexagon generator phase 2 - qemu_def_generated.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100755 ERROR: please use python3 interpreter #21: FILE: target/hexagon/do_qemu.py:1: +#!/usr/bin/env python total: 1 errors, 1 warnings, 773 lines checked Patch 21/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/66 Checking commit 38aac214033b (Hexagon generator phase 2 - qemu_wrap_generated.h) 23/66 Checking commit 55b2d7ee57f9 (Hexagon generator phase 2 - opcodes_def_generated.h) 24/66 Checking commit c200b920adee (Hexagon generator phase 2 - op_attribs_generated.h) 25/66 Checking commit f0262c416b0e (Hexagon generator phase 2 - op_regs_generated.h) 26/66 Checking commit a25a1a5fb267 (Hexagon generator phase 2 - printinsn-generated.h) 27/66 Checking commit 3d4364b80632 (Hexagon generator phase 3 - C preprocessor for decode tree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #82: FILE: target/hexagon/gen_dectree_import.c:63: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS, ERROR: Macros with complex values should be enclosed in parenthesis #91: FILE: target/hexagon/gen_dectree_import.c:72: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS, ERROR: suspicious ; after while (0) #196: FILE: target/hexagon/gen_dectree_import.c:177: + } while (0); total: 3 errors, 1 warnings, 205 lines checked Patch 27/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 28/66 Checking commit 38f354878e1b (Hexagon generater phase 4 - Decode tree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100755 ERROR: please use python3 interpreter #18: FILE: target/hexagon/dectree.py:1: +#!/usr/bin/env python total: 1 errors, 1 warnings, 354 lines checked Patch 28/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 29/66 Checking commit a9c12828a0a2 (Hexagon opcode data structures) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #62: FILE: target/hexagon/opcodes.c:47: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) REGINFO, ERROR: Macros with complex values should be enclosed in parenthesis #72: FILE: target/hexagon/opcodes.c:57: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS, ERROR: Macros with complex values should be enclosed in parenthesis #82: FILE: target/hexagon/opcodes.c:67: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS, ERROR: Macros with complex values should be enclosed in parenthesis #192: FILE: target/hexagon/opcodes.c:177: +#define ATTRIBS(...) , ## __VA_ARGS__, 0 total: 4 errors, 1 warnings, 290 lines checked Patch 29/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 30/66 Checking commit c26cc7855c0b (Hexagon macros to interface with the generator) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 388 lines checked Patch 30/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/66 Checking commit 21cb791e87ca (Hexagon macros referenced in instruction semantics) 32/66 Checking commit 6c5d03d78e52 (Hexagon instruction classes) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #159: FILE: target/hexagon/iclass.h:27: +#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS) ICLASS_FROM_TYPE(TYPE), ERROR: Macros with complex values should be enclosed in parenthesis #165: FILE: target/hexagon/iclass.h:33: +#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS) ICLASS_FROM_TYPE(TYPE), total: 2 errors, 1 warnings, 155 lines checked Patch 32/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/66 Checking commit 8b842c6bae96 (Hexagon TCG generation helpers - step 1) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 323 lines checked Patch 33/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/66 Checking commit 803f77c188b0 (Hexagon TCG generation helpers - step 2) 35/66 Checking commit bac1a49d71b5 (Hexagon TCG generation helpers - step 3) 36/66 Checking commit 4860b36f7100 (Hexagon TCG generation helpers - step 4) 37/66 Checking commit efc508d11f14 (Hexagon TCG generation helpers - step 5) 38/66 Checking commit 0e7ecc9f6e6d (Hexagon TCG generation - step 01) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 85 lines checked Patch 38/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 39/66 Checking commit 8841a205e773 (Hexagon TCG generation - step 02) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 411 lines checked Patch 39/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/66 Checking commit cdca41309a5b (Hexagon TCG generation - step 03) 41/66 Checking commit 42b2388a7c59 (Hexagon TCG generation - step 04) 42/66 Checking commit 9d2028ea87d8 (Hexagon TCG generation - step 05) 43/66 Checking commit 9d340b52603f (Hexagon TCG generation - step 06) 44/66 Checking commit 5ce443777fa5 (Hexagon TCG generation - step 07) 45/66 Checking commit f382bf58bd76 (Hexagon TCG generation - step 08) 46/66 Checking commit 3d5e67f03159 (Hexagon TCG generation - step 09) 47/66 Checking commit bca0e86184c9 (Hexagon TCG generation - step 10) 48/66 Checking commit 03465b36b627 (Hexagon TCG generation - step 11) 49/66 Checking commit 8bfe3f253a63 (Hexagon TCG generation - step 12) 50/66 Checking commit b272b705e025 (Hexagon translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 814 lines checked Patch 50/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 51/66 Checking commit 4a0112d25d95 (Hexagon Linux user emulation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 1118 lines checked Patch 51/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 52/66 Checking commit 86f9dd78305c (Hexagon build infrastructure) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #49: new file mode 100644 WARNING: line over 80 characters #72: FILE: scripts/qemu-binfmt-conf.sh:139: +hexagon_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xa4\x00' ERROR: line over 90 characters #73: FILE: scripts/qemu-binfmt-conf.sh:140: +hexagon_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff' total: 1 errors, 2 warnings, 1675 lines checked Patch 52/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 53/66 Checking commit df47f6485af0 (Hexagon - Add Hexagon Vector eXtensions (HVX) to core definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #231: new file mode 100644 total: 0 errors, 1 warnings, 274 lines checked Patch 53/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 54/66 Checking commit d5ebf1424f5f (Hexagon HVX support in gdbstub) 55/66 Checking commit ffcca926c2c1 (Hexagon HVX import instruction encodings) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 857 lines checked Patch 55/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 56/66 Checking commit 92dce5d65a9d (Hexagon HVX import semantics) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 2838 lines checked Patch 56/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 57/66 Checking commit 9c5c89526c8f (Hexagon HVX import macro definitions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 1135 lines checked Patch 57/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 58/66 Checking commit 40ec29548134 (Hexagon HVX semantics generator) 59/66 Checking commit 3d4f56a9ccc5 (Hexagon HVX instruction decoding) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #80: new file mode 100644 total: 0 errors, 1 warnings, 792 lines checked Patch 59/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 60/66 Checking commit 22f408ff7edb (Hexagon HVX instruction utility functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 303 lines checked Patch 60/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 61/66 Checking commit cc6be785ec5b (Hexagon HVX macros to interface with the generator) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 232 lines checked Patch 61/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 62/66 Checking commit dc23a1c1d57f (Hexagon HVX macros referenced in instruction semantics) ERROR: suspicious ; after while (0) #118: FILE: target/hexagon/mmvec/macros.h:332: + } while (0); ERROR: suspicious ; after while (0) #125: FILE: target/hexagon/mmvec/macros.h:339: + } while (0); total: 2 errors, 0 warnings, 440 lines checked Patch 62/66 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 63/66 Checking commit e77505e3acac (Hexagon HVX helper to commit vector stores (masked and scatter/gather)) 64/66 Checking commit 876116c3afab (Hexagon HVX TCG generation) 65/66 Checking commit f445784ebe8f (Hexagon HVX translation) 66/66 Checking commit 7a2b354a3898 (Hexagon HVX build infrastructure) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1581381644-13678-1-git-send-email-tsimpson@quicinc.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 2/11/20 2:31 AM, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/1581381644-13678-1-git-send-email-tsimpson@quicinc.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > [...]> ERROR: please use python3 interpreter > #21: FILE: target/hexagon/do_qemu.py:1: > +#!/usr/bin/env python Yay my Perl fu worked \o/ > > total: 1 errors, 1 warnings, 773 lines checked > > Patch 21/66 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 22/66 Checking commit 38aac214033b (Hexagon generator phase 2 - qemu_wrap_generated.h) > 23/66 Checking commit 55b2d7ee57f9 (Hexagon generator phase 2 - opcodes_def_generated.h) > 24/66 Checking commit c200b920adee (Hexagon generator phase 2 - op_attribs_generated.h) > 25/66 Checking commit f0262c416b0e (Hexagon generator phase 2 - op_regs_generated.h) > 26/66 Checking commit a25a1a5fb267 (Hexagon generator phase 2 - printinsn-generated.h) > 27/66 Checking commit 3d4364b80632 (Hexagon generator phase 3 - C preprocessor for decode tree) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #15: > new file mode 100644 > > ERROR: Macros with complex values should be enclosed in parenthesis > #82: FILE: target/hexagon/gen_dectree_import.c:63: > +#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS, > > ERROR: Macros with complex values should be enclosed in parenthesis > #91: FILE: target/hexagon/gen_dectree_import.c:72: > +#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS, > > ERROR: suspicious ; after while (0) > #196: FILE: target/hexagon/gen_dectree_import.c:177: > + } while (0); > > total: 3 errors, 1 warnings, 205 lines checked > > Patch 27/66 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 28/66 Checking commit 38f354878e1b (Hexagon generater phase 4 - Decode tree) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #13: > new file mode 100755 > > ERROR: please use python3 interpreter > #18: FILE: target/hexagon/dectree.py:1: > +#!/usr/bin/env python > > total: 1 errors, 1 warnings, 354 lines checked > [...]
On 2/11/20 1:39 AM, Taylor Simpson wrote: > This series adds support for the Hexagon processor with Linux user support > > Hexagon is Qualcomm's very long instruction word (VLIW) digital signal > processor(DSP). We also support Hexagon Vector eXtensions (HVX). HVX > is a wide vector coprocessor designed for high performance computer vision, > image processing, machine learning, and other workloads. > > This series of patches supports the following versions of the Hexagon core > Scalar core: v67 > https://developer.qualcomm.com/downloads/qualcomm-hexagon-v67-programmer-s-reference-manual > HVX extension: v66 > https://developer.qualcomm.com/downloads/qualcomm-hexagon-v66-hvx-programmer-s-reference-manual > > We presented an overview of the project at the 2019 KVM Forum. > https://kvmforum2019.sched.com/event/Tmwc/qemu-hexagon-automatic-translation-of-the-isa-manual-pseudcode-to-tiny-code-instructions-of-a-vliw-architecture-niccolo-izzo-revng-taylor-simpson-qualcomm-innovation-center > > The patches up to and including "Hexagon build infractructure" implement the > base Hexagon core and the remainder add HVX. Once the build infrastructure > patch is applied, you can build and qemu will execute non-HVX Hexagon programs. > > We have a parallel effort to make the Hexagon Linux toolchain publically > available. > > > *** Required patches *** > > In order to build, we need this patch > https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg01203.html > > In order to run pthread_cancel, we need this patch series > https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg00834.html > https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg00832.html > https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg00833.html > https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg00835.html > https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg00836.html > > > *** Testing *** > > The port passes the following tests > Directed unit tests > MUSL libc test suite (good coverage of Linux system calls) > Compiler intrinsics test suite (good coverage of instructions) > Hexagon machine learning library unit tests Link/references please? > make check-tcg TIMEOUT=60 > > *** Known checkpatch issues *** > > The following are known checkpatch errors in the series > include/disas/dis-asm.h space prohibited > (Follow convention of other targets on prior lines) > target/hexagon/reg_fields.h Complex macro > target/hexagon/attribs.h Complex macro > target/hexagon/decode.c Complex macro > target/hexagon/q6v_decode.c Macro needs do - while > target/hexagon/printinsn.c Macro needs do - while > target/hexagon/gen_semantics.c Suspicious ; after while (0) > target/hexagon/gen_dectree_import.c Complex macro > target/hexagon/gen_dectree_import.c Suspicious ; after while (0) > target/hexagon/opcodes.c Complex macro > target/hexagon/iclass.h Complex macro > scripts/qemu-binfmt-conf.sh Line over 90 characters > target/hexagon/mmvec/macros.h Suspicious ; after while (0) > > The following are known checkpatch warnings in the series > target/hexagon/fma_emu.c Comments inside macro definition > scripts/qemu-binfmt-conf.sh Line over 80 characters > > > *** Tour of the code *** > > The qemu-hexagon implementation is a combination of qemu and the Hexagon > architecture library (aka archlib). The three primary directories with > Hexagon-specific code are > > qemu/target/hexagon > This has all the instruction and packet semantics > qemu/target/hexagon/imported > These files are imported with very little modification from archlib > *.idef Instruction semantics definition > macros.def Mapping of macros to instruction attributes > encode*.def Encoding patterns for each instruction > iclass.def Instruction class definitions used to determine > legal VLIW slots for each instruction > qemu/linux-user/hexagon > Helpers for loading the ELF file and making Linux system calls, > signals, etc > > We start with a script that generates qemu helper for each instruction. This > is a two step process. The first step is to use the C preprocessor to expand > macros inside the architecture definition files. This is done in > target/hexagon/semantics.c. This step produces > <BUILD_DIR>/hexagon-linux-user/semantics_generated.pyinc. > That file is consumed by the do_qemu.py script. This script generates > several files. All of the generated files end in "_generated.*". The > primary file produced is > <BUILD_DIR>/hexagon-linux-user/qemu_def_generated.h > > Qemu helper functions have 3 parts > DEF_HELPER declaration indicates the signature of the helper > gen_helper_<NAME> will generate a TCG call to the helper function > The helper implementation > > In the qemu_def_generated.h file, there is a DEF_QEMU macro for each user-space > instruction. The file is included several times with DEF_QEMU defined > differently, depending on the context. The macro has four arguments > The instruction tag > The semantics_short code > DEF_HELPER declaration > Call to the helper > Helper implementation > > Here's an example of the A2_add instruction. > Instruction tag A2_add > Assembly syntax "Rd32=add(Rs32,Rt32)" > Instruction semantics "{ RdV=RsV+RtV;}" > > By convention, the operands are identified by letter > RdV is the destination register > RsV, RtV are source registers > > The generator uses the operand naming conventions (see large comment in > do_qemu.py) to determine the signature of the helper function. Here is the > result for A2_add from qemu_def_generated.h > > DEF_QEMU(A2_add,{ RdV=RsV+RtV;}, > #ifndef fWRAP_A2_add > DEF_HELPER_3(A2_add, s32, env, s32, s32) > #endif > , > { > /* A2_add */ > DECL_RREG_d(RdV, RdN, 0, 0); > DECL_RREG_s(RsV, RsN, 1, 0); > DECL_RREG_t(RtV, RtN, 2, 0); > READ_RREG_s(RsV, RsN); > READ_RREG_t(RtV, RtN); > fWRAP_A2_add( > do { > gen_helper_A2_add(RdV, cpu_env, RsV, RtV); > } while (0), > { RdV=RsV+RtV;}); > WRITE_RREG_d(RdN, RdV); > FREE_RREG_d(RdV); > FREE_RREG_s(RsV); > FREE_RREG_t(RtV); > /* A2_add */ > }, > #ifndef fWRAP_A2_add > int32_t HELPER(A2_add)(CPUHexagonState *env, int32_t RsV, int32_t RtV) > { > uint32_t slot = 4; slot = slot; > int32_t RdV = 0; > { RdV=RsV+RtV;} > COUNT_HELPER(A2_add); > return RdV; > } > #endif > ) > > For each operand, there are macros for DECL, FREE, READ, WRITE. These are > defined in macros.h. Note that we append the operand type to the macro name, > which allows us to specialize the TCG code tenerated. For read-only operands, > DECL simply declares the TCGv variable (no need for tcg_temp_local_new()), > and READ will assign from the TCGv corresponding to the GPR, and FREE doesn't > have to do anything. Also, note that the WRITE macros update the disassembly > context to be processed when the packet commits (see "Packet Semantics" below). > > Note the fWRAP_A2_add macro around the gen_helper call. Each instruction has a fWRAP_<tag> macro that takes 2 arguments > gen_helper call > C semantics (aka short code) > > This allows the code generator to override the auto-generated code. In some > cases this is necessary for correct execution. We can also override for > faster emulation. For example, calling a helper for add is more expensive > than generating a TCG add operation. > > The qemu_wrap_generated.h file contains a default fWRAP_<tag> for each > instruction. The default is to invoke the gen_helper code. > #ifndef fWRAP_A2_add > #define fWRAP_A2_add(GENHLPR, SHORTCODE) GENHLPR > #endif > > The helper_overrides.h file has any overrides. For example, > #define fWRAP_A2_add(GENHLPR, SHORTCODE) \ > tcg_gen_add_tl(RdV, RsV, RtV) > > This file is included twice > 1) In genptr.c, it overrides the semantics of the desired instructions > 2) In helper.h, it prevents the generation of helpers for overridden > instructions. Notice the #ifndef fWRAP_A2_add above. > > The instruction semantics C code heavily on macros. In cases where the C > semantics are specified only with macros, we can override the default with > the short semantics option and #define the macros to generate TCG code. One > example is Y2_dczeroa (dc == data cache, zero == zero out the cache line, > a == address: zero out the data cache line at the given address): > Instruction tag Y2_dczeroa > Assembly syntax "dczeroa(Rs32)" > Instruction semantics "{fEA_REG(RsV); fDCZEROA(EA);}" > > In helper_overrides.h, we use the shortcode > #define fWRAP_Y2_dczeroa(GENHLPR, SHORTCODE) SHORTCODE > > In other cases, just a little bit of wrapper code needs to be written. > #define fWRAP_tmp(SHORTCODE) \ > { \ > TCGv tmp = tcg_temp_new(); \ > SHORTCODE; \ > tcg_temp_free(tmp); \ > } > > For example, some load instructions use a temporary for address computation. > The SL2_loadrd_sp instruction needs a temporary to hold the value of the stack > pointer (r29) > Instruction tag SL2_loadrd_sp > Assembly syntax "Rdd8=memd(r29+#u5:3)" > Instruction semantics "{fEA_RI(fREAD_SP(),uiV); fLOAD(1,8,u,EA,RddV);}" > > In helper_overrides.h you'll see > #define fWRAP_SL2_loadrd_sp(GENHLPR, SHORTCODE) fWRAP_tmp(SHORTCODE) > > There are also cases where we brute force the TCG code generation. The > allocframe and deallocframe instructions are examples. Other examples are > instructions with multiple definitions. These require special handling > because qemu helpers can only return a single value. > > In addition to instruction semantics, we use a generator to create the decode > tree. This generation is also a two step process. The first step is to run > target/hexagon/gen_dectree_import.c to produce > <BUILD_DIR>/hexagon-linux-user/iset.py > This file is imported by target/hexagon/dectree.py to produce > <BUILD_DIR>/hexagon-linux-user/dectree_generated.h > > *** Key Files *** > > cpu.h > > This file contains the definition of the CPUHexagonState struct. It is the > runtime information for each thread and contains stuff like the GPR and > predicate registers. > > macros.h > mmvec/macros.h > > The Hexagon arch lib relies heavily on macros for the instruction semantics. > This is a great advantage for qemu because we can override them for different > purposes. You will also notice there are sometimes two definitions of a macro. > The QEMU_GENERATE variable determines whether we want the macro to generate TCG > code. If QEMU_GENERATE is not defined, we want the macro to generate vanilla > C code that will work in the helper implementation. > > translate.c > > The functions in this file generate TCG code for a translation block. Some > important functions in this file are > > gen_start_packet - initialize the data structures for packet semantics > gen_commit_packet - commit the register writes, stores, etc for a packet > decode_packet - disassemble a packet and generate code > > genptr.c > genptr_helpers.h > helper_overrides.h > > These file create a function for each instruction. It is mostly composed of > fWRAP_<tag> definitions followed by including qemu_def_generated.h. The > genptr_helpers.h file contains helper functions that are invoked by the macros > in helper_overrides.h and macros.h > > op_helper.c > > This file contains the implementations of all the helpers. There are a few > general purpose helpers, but most of them are generated by including > qemu_def_generated.h. There are also several helpers used for debugging. > > > *** Packet Semantics *** > > VLIW packet semantics differ from serial semantics in that all input operands > are read, then the operations are performed, then all the results are written. > For exmaple, this packet performs a swap of registers r0 and r1 > { r0 = r1; r1 = r0 } > Note that the result is different if the instructions are executed serially. > > Packet semantics dictate that we defer any changes of state until the entire > packet is committed. We record the results of each instruction in a side data > structure, and update the visible processor state when we commit the packet. > > The data structures are divided between the runtime state and the translation > context. > > During the TCG generation (see translate.[ch]), we use the DisasContext to > track what needs to be done during packet commit. Here are the relevant > fields > > ctx_reg_log list of registers written > ctx_reg_log_idx index into ctx_reg_log > ctx_pred_log list of predicates written > ctx_pred_log_idx index into ctx_pred_log > ctx_store_width width of stores (indexed by slot) > > During runtime, the following fields in CPUHexagonState (see cpu.h) are used > > new_value new value of a given register > reg_written boolean indicating if register was written > new_pred_value new value of a predicate register > new_pred_written boolean indicating if predicate was written > mem_log_stores record of the stores (indexed by slot) > > For Hexagon Vector eXtensions (HVX), the following fields are used > > future_VRegs > tmp_VRegs > future_ZRegs > ZRegs_updated > VRegs_updated_tmp > VRegs_updated > VRegs_select > > *** Debugging *** > > You can turn on a lot of debugging by changing the HEX_DEBUG macro to 1 in > internal.h. This will stream a lot of information as it generates TCG and > executes the code. > > To track down nasty issues with Hexagon->TCG generation, we compare the > execution results with actual hardware running on a Hexagon Linux target. > Run qemu with the "-d cpu" option. Then, we can diff the results and figure > out where qemu and hardware behave differently. > > The stacks are located at different locations. We handle this by changing > env->stack_adjust in translate.c. First, set this to zero and run qemu. > Then, change env->stack_adjust to the difference between the two stack > locations. Then rebuild qemu and run again. That will produce a very > clean diff. > > Here are some handy places to set breakpoints > > At the call to gen_start_packet for a given PC (note that the line number > might change in the future) > br translate.c:602 if ctx->base.pc_next == 0xdeadbeef > The helper function for each instruction is named helper_<TAG>, so here's > an example that will set a breakpoint at the start > br helper_V6_vgathermh > If you have the HEX_DEBUG macro set, the following will be useful > At the start of execution of a packet for a given PC > br helper_debug_start_packet if env->gpr[41] == 0xdeadbeef > At the end of execution of a packet for a given PC > br helper_debug_commit_end if env->this_PC == 0xdeadbeef Most of this cover should go into a document in the repository, which might be the first patch of your series. > > Taylor Simpson (66): > Hexagon Maintainers > Hexagon ELF Machine Definition > Hexagon CPU Scalar Core Definition > Hexagon register names > Hexagon Disassembler > Hexagon CPU Scalar Core Helpers > Hexagon GDB Stub > Hexagon instruction and packet types > Hexagon architecture types > Hexagon register fields > Hexagon instruction attributes > Hexagon register map > Hexagon instruction/packet decode > Hexagon instruction printing > Hexagon arch import - instruction semantics definitions > Hexagon arch import - macro definitions > Hexagon arch import - instruction encoding > Hexagon instruction class definitions > Hexagon instruction utility functions > Hexagon generator phase 1 - C preprocessor for semantics > Hexagon generator phase 2 - qemu_def_generated.h > Hexagon generator phase 2 - qemu_wrap_generated.h > Hexagon generator phase 2 - opcodes_def_generated.h > Hexagon generator phase 2 - op_attribs_generated.h > Hexagon generator phase 2 - op_regs_generated.h > Hexagon generator phase 2 - printinsn-generated.h > Hexagon generator phase 3 - C preprocessor for decode tree > Hexagon generater phase 4 - Decode tree > Hexagon opcode data structures > Hexagon macros to interface with the generator > Hexagon macros referenced in instruction semantics > Hexagon instruction classes > Hexagon TCG generation helpers - step 1 > Hexagon TCG generation helpers - step 2 > Hexagon TCG generation helpers - step 3 > Hexagon TCG generation helpers - step 4 > Hexagon TCG generation helpers - step 5 > Hexagon TCG generation - step 01 > Hexagon TCG generation - step 02 > Hexagon TCG generation - step 03 > Hexagon TCG generation - step 04 > Hexagon TCG generation - step 05 > Hexagon TCG generation - step 06 > Hexagon TCG generation - step 07 > Hexagon TCG generation - step 08 > Hexagon TCG generation - step 09 > Hexagon TCG generation - step 10 > Hexagon TCG generation - step 11 > Hexagon TCG generation - step 12 While the TCG patch subjects are not verbose, I appreciate how you split them into digestable patches. > Hexagon translation > Hexagon Linux user emulation > Hexagon build infrastructure > Hexagon - Add Hexagon Vector eXtensions (HVX) to core definition > Hexagon HVX support in gdbstub > Hexagon HVX import instruction encodings > Hexagon HVX import semantics > Hexagon HVX import macro definitions > Hexagon HVX semantics generator > Hexagon HVX instruction decoding > Hexagon HVX instruction utility functions > Hexagon HVX macros to interface with the generator > Hexagon HVX macros referenced in instruction semantics > Hexagon HVX helper to commit vector stores (masked and scatter/gather) > Hexagon HVX TCG generation > Hexagon HVX translation > Hexagon HVX build infrastructure
Hi Taylor, On 2/11/20 1:39 AM, Taylor Simpson wrote: > This series adds support for the Hexagon processor with Linux user support > [...]> MAINTAINERS | 8 + > configure | 9 + > default-configs/hexagon-linux-user.mak | 1 + > disas/Makefile.objs | 1 + > disas/hexagon.c | 56 + > include/disas/dis-asm.h | 1 + > include/elf.h | 2 + > linux-user/elfload.c | 16 + > linux-user/hexagon/cpu_loop.c | 173 ++ > linux-user/hexagon/signal.c | 276 ++ > linux-user/hexagon/sockbits.h | 18 + > linux-user/hexagon/syscall_nr.h | 346 +++ > linux-user/hexagon/target_cpu.h | 44 + > linux-user/hexagon/target_elf.h | 38 + > linux-user/hexagon/target_fcntl.h | 18 + > linux-user/hexagon/target_signal.h | 34 + > linux-user/hexagon/target_structs.h | 46 + > linux-user/hexagon/target_syscall.h | 32 + > linux-user/hexagon/termbits.h | 18 + > linux-user/syscall.c | 2 + > linux-user/syscall_defs.h | 33 + > scripts/qemu-binfmt-conf.sh | 6 +- > target/hexagon/Makefile.objs | 109 + > target/hexagon/arch.c | 664 +++++ > target/hexagon/arch.h | 62 + > target/hexagon/attribs.h | 32 + > target/hexagon/attribs_def.h | 404 +++ > target/hexagon/conv_emu.c | 370 +++ > target/hexagon/conv_emu.h | 50 + > target/hexagon/cpu-param.h | 26 + > target/hexagon/cpu.c | 356 +++ > target/hexagon/cpu.h | 207 ++ > target/hexagon/cpu_bits.h | 37 + > target/hexagon/decode.c | 792 +++++ > target/hexagon/decode.h | 39 + > target/hexagon/dectree.py | 354 +++ > target/hexagon/do_qemu.py | 1198 ++++++++ > target/hexagon/fma_emu.c | 918 ++++++ > target/hexagon/fma_emu.h | 30 + > target/hexagon/gdbstub.c | 111 + > target/hexagon/gen_dectree_import.c | 205 ++ > target/hexagon/gen_semantics.c | 101 + > target/hexagon/genptr.c | 62 + > target/hexagon/genptr.h | 25 + > target/hexagon/genptr_helpers.h | 1022 +++++++ > target/hexagon/helper.h | 38 + > target/hexagon/helper_overrides.h | 1850 ++++++++++++ > target/hexagon/hex_arch_types.h | 42 + > target/hexagon/hex_regs.h | 97 + > target/hexagon/iclass.c | 109 + > target/hexagon/iclass.h | 46 + > target/hexagon/imported/allext.idef | 25 + > target/hexagon/imported/allext_macros.def | 25 + > target/hexagon/imported/allextenc.def | 20 + > target/hexagon/imported/allidefs.def | 92 + > target/hexagon/imported/alu.idef | 1335 +++++++++ > target/hexagon/imported/branch.idef | 344 +++ > target/hexagon/imported/compare.idef | 639 +++++ > target/hexagon/imported/encode.def | 126 + > target/hexagon/imported/encode_pp.def | 2283 +++++++++++++++ > target/hexagon/imported/encode_subinsn.def | 150 + > target/hexagon/imported/float.idef | 498 ++++ > target/hexagon/imported/iclass.def | 52 + > target/hexagon/imported/ldst.idef | 421 +++ > target/hexagon/imported/macros.def | 3970 ++++++++++++++++++++++++++ > target/hexagon/imported/mmvec/encode_ext.def | 830 ++++++ > target/hexagon/imported/mmvec/ext.idef | 2809 ++++++++++++++++++ > target/hexagon/imported/mmvec/macros.def | 1110 +++++++ > target/hexagon/imported/mpy.idef | 1269 ++++++++ > target/hexagon/imported/shift.idef | 1211 ++++++++ > target/hexagon/imported/subinsns.idef | 152 + > target/hexagon/imported/system.idef | 302 ++ > target/hexagon/insn.h | 149 + > target/hexagon/internal.h | 54 + > target/hexagon/macros.h | 1499 ++++++++++ > target/hexagon/mmvec/decode_ext_mmvec.c | 673 +++++ > target/hexagon/mmvec/decode_ext_mmvec.h | 24 + > target/hexagon/mmvec/macros.h | 668 +++++ > target/hexagon/mmvec/mmvec.h | 87 + > target/hexagon/mmvec/system_ext_mmvec.c | 265 ++ > target/hexagon/mmvec/system_ext_mmvec.h | 38 + > target/hexagon/op_helper.c | 507 ++++ > target/hexagon/opcodes.c | 223 ++ > target/hexagon/opcodes.h | 67 + > target/hexagon/printinsn.c | 93 + > target/hexagon/printinsn.h | 26 + > target/hexagon/q6v_decode.c | 416 +++ > target/hexagon/reg_fields.c | 28 + > target/hexagon/reg_fields.h | 40 + > target/hexagon/reg_fields_def.h | 109 + > target/hexagon/regmap.h | 38 + > target/hexagon/translate.c | 906 ++++++ > target/hexagon/translate.h | 112 + > tests/tcg/configure.sh | 4 +- > tests/tcg/hexagon/float_convs.ref | 748 +++++ > tests/tcg/hexagon/float_madds.ref | 768 +++++ > 96 files changed, 35737 insertions(+), 2 deletions(-) Please look at the file scripts/git.orderfile and if possible install it before your next version (please wait at least 1 week between version, for a so big series!). This script order files in patch in a way easier to review by mail.
Hi all, I've made the changes from Philippe's review of the patch series. If there is no more feedback, I'll prepare v2 and send it to the list. Thanks, Taylor > -----Original Message----- > From: Philippe Mathieu-Daudé <philmd@redhat.com> > Sent: Tuesday, February 11, 2020 9:32 AM > To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org > Cc: richard.henderson@linaro.org; laurent@vivier.eu; riku.voipio@iki.fi; > aleksandar.m.mail@gmail.com > Subject: Re: [RFC PATCH 00/66] Hexagon patch series > > > Please look at the file scripts/git.orderfile and if possible install it > before your next version (please wait at least 1 week between version, > for a so big series!). This script order files in patch in a way easier > to review by mail.