From patchwork Tue Sep 29 11:01:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pavel Dovgalyuk X-Patchwork-Id: 11805615 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4C202139F for ; Tue, 29 Sep 2020 11:02:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD0BF20C09 for ; Tue, 29 Sep 2020 11:02:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD0BF20C09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ispras.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:38090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNDOz-0003xU-TL for patchwork-qemu-devel@patchwork.kernel.org; Tue, 29 Sep 2020 07:02:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNDNh-0002RG-Ko for qemu-devel@nongnu.org; Tue, 29 Sep 2020 07:01:13 -0400 Received: from mail.ispras.ru ([83.149.199.84]:35018) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNDNf-0002YT-0W for qemu-devel@nongnu.org; Tue, 29 Sep 2020 07:01:13 -0400 Received: from [127.0.1.1] (unknown [62.118.151.149]) by mail.ispras.ru (Postfix) with ESMTPSA id B77C740F9AAE; Tue, 29 Sep 2020 11:01:04 +0000 (UTC) Subject: [PATCH v6 00/14] Reverse debugging From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Tue, 29 Sep 2020 14:01:04 +0300 Message-ID: <160137726426.31007.12061315974029139983.stgit@pasha-ThinkPad-X280> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Received-SPF: pass client-ip=83.149.199.84; envelope-from=pavel.dovgalyuk@ispras.ru; helo=mail.ispras.ru X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/29 07:01:05 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, wrampazz@redhat.com, pavel.dovgalyuk@ispras.ru, ehabkost@redhat.com, alex.bennee@linaro.org, mtosatti@redhat.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, philmd@redhat.com, zhiwei_liu@c-sky.com, rth@twiddle.net Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed normally. Reverse debugging is possible in the replay mode, when at least one snapshot was created at the record or replay phase. QEMU can use these snapshots for travelling back in time with GDB. Running the execution in replay mode allows using GDB reverse debugging commands: - reverse-stepi (or rsi): Steps one instruction to the past. QEMU loads on of the prior snapshots and proceeds to the desired instruction forward. When that step is reaches, execution stops. - reverse-continue (or rc): Runs execution "backwards". QEMU tries to find breakpoint or watchpoint by loaded prior snapshot and replaying the execution. Then QEMU loads snapshots again and replays to the latest breakpoint. When there are no breakpoints in the examined section of the execution, QEMU finds one more snapshot and tries again. After the first snapshot is processed, execution stops at this snapshot. The set of patches include the following modifications: - gdbstub update for reverse debugging support - functions that automatically perform reverse step and reverse continue operations - hmp/qmp commands for manipulating the replay process - improvement of the snapshotting for saving the execution step in the snapshot parameters - avocado-based acceptance tests for reverse debugging The patches are available in the repository: https://github.com/ispras/qemu/tree/rr-200901 v6 changes: - removed passing err variable without checking it's value after v5 changes: - disabled reverse debugging tests for gitlab-based testing due to the unidentified timeout problem v4 changes: - added VM snapshot creation on gdb connect (suggested by Alex Bennée) - removed useless calls to error_free - updated poll interrupt processing - minor changes v3 changes: - rebased to support the new build system - bumped avocado framework version for using fixed remote gdb client v2 changes: - rebased to the latest upstream version - fixed replaying of the POLL interrupts after the latest debug changes --- Pavel Dovgaluk (11): replay: provide an accessor for rr filename qcow2: introduce icount field for snapshots qapi: introduce replay.json for record/replay-related stuff replay: introduce info hmp/qmp command replay: introduce breakpoint at the specified step replay: implement replay-seek command replay: flush rr queue before loading the vmstate gdbstub: add reverse step support in replay mode gdbstub: add reverse continue support in replay mode replay: describe reverse debugging in docs/replay.txt tests/acceptance: add reverse debugging test Pavel Dovgalyuk (3): replay: don't record interrupt poll migration: introduce icount field for snapshots replay: create temporary snapshot at debugger connection MAINTAINERS | 2 accel/tcg/cpu-exec.c | 21 ++ accel/tcg/translator.c | 1 block/qapi.c | 18 +- block/qcow2-snapshot.c | 9 + block/qcow2.h | 3 blockdev.c | 10 + docs/interop/qcow2.txt | 5 docs/replay.txt | 46 +++++ exec.c | 8 + gdbstub.c | 64 ++++++ hmp-commands-info.hx | 11 + hmp-commands.hx | 50 +++++ include/block/snapshot.h | 1 include/monitor/hmp.h | 4 include/sysemu/replay.h | 26 +++ migration/savevm.c | 17 +- qapi/block-core.json | 11 + qapi/meson.build | 1 qapi/misc.json | 18 -- qapi/qapi-schema.json | 1 qapi/replay.json | 121 ++++++++++++ replay/meson.build | 1 replay/replay-debugging.c | 332 +++++++++++++++++++++++++++++++++ replay/replay-events.c | 4 replay/replay-internal.h | 6 - replay/replay.c | 22 ++ softmmu/cpus.c | 19 ++ stubs/replay.c | 15 + tests/acceptance/reverse_debugging.py | 208 +++++++++++++++++++++ tests/qemu-iotests/267.out | 48 ++--- 31 files changed, 1039 insertions(+), 64 deletions(-) create mode 100644 qapi/replay.json create mode 100644 replay/replay-debugging.c create mode 100644 tests/acceptance/reverse_debugging.py -- Pavel Dovgalyuk